From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AC9C433FE for ; Thu, 10 Nov 2022 15:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AD0D6B0071; Thu, 10 Nov 2022 10:18:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75C796B0074; Thu, 10 Nov 2022 10:18:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64E998E0001; Thu, 10 Nov 2022 10:18:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5679E6B0071 for ; Thu, 10 Nov 2022 10:18:22 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3A4D44146B for ; Thu, 10 Nov 2022 15:18:22 +0000 (UTC) X-FDA: 80117888844.18.4578D45 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id D81F11A000B for ; Thu, 10 Nov 2022 15:18:21 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFCE9619DA; Thu, 10 Nov 2022 15:18:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18DBCC433C1; Thu, 10 Nov 2022 15:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668093500; bh=P1veQsKG59JRNLlKHFjt59W4QFwwnV8LOv0rq5XQ56w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PypWXxbwE2Wx2kOKCsexwtBMj8zgdFyua7vGiENW2rNoaz2AQR9Fu/UvXmZ6eAZql MOITHP6LTJcUZA7uNxVFVBlHKMNIsYkNSRCVS6qLfHkV0/jxJHz7QMKhxY6Y/ZCtJn P7bt0RGOpexvl/NMzf1Kmj3BF+w0tEkb3t37OcBt1eti/URlyqAYXrD5nO36iUSaTm ixzfD732dRYISonQIEHuTx8Nq+1vEoAy7ejxrB3JYcotl+TrakRX4E1YGEp4XLFI31 q5xEWcjTqnlfP1M8aQqVp+48kEONe43RBIEh7Rnf0lcTHiqv3hKtL+gLTl+6fFt4ec hwi8diJlyS4Xg== Date: Thu, 10 Nov 2022 08:18:18 -0700 From: Nathan Chancellor To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCHv5 04/13] zram: Introduce recompress sysfs knob Message-ID: References: <20221109115047.2921851-1-senozhatsky@chromium.org> <20221109115047.2921851-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668093501; a=rsa-sha256; cv=none; b=GBoJwcqXqyMBXHCws5TXI6tMIQq6A7l12C3SM0A61gutv7LTNaTM2LA0PCCEcgLHQwloKP W0YrzrmyY2ENEt1Hi41GxW8eLOKZTmpxy03K0YF3e13F6G6Nq3qdu6mBo8RU2WGMJrgOE/ NELwOg6gGVviK84n+LCGGtjMA/6Ka8s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PypWXxbw; spf=pass (imf19.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668093501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vigi2y4Mrbrfo+FeDFEwfou9sAdFRcusWWTqggSUfXI=; b=wigupFZfS0w5jzHmmFg7iADqlUMdPt0y8pOUTDitMieCi32txceACl8RMkUxrio8stD/vz eGpjtaLiSf34k8XhDxgN7zUGVO+REX6XTydBpOtKXiKbKpZlqhDMufyrEzPRbCCHqvv5yI EeAq91QMwluJudTQZFKxkp4U9g3tfEI= X-Stat-Signature: hmqfomfxnc5g1h3xz3yhew9wkrcd414a X-Rspamd-Queue-Id: D81F11A000B Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PypWXxbw; spf=pass (imf19.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1668093501-88340 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 10, 2022 at 11:38:57PM +0900, Sergey Senozhatsky wrote: > On (22/11/10 23:31), Sergey Senozhatsky wrote: > > On (22/11/10 06:09), Nathan Chancellor wrote: > > [..] > > > drivers/block/zram/zram_drv.c:1894:10: note: initialize the variable 'err' to silence this warning > > > int err; > > > ^ > > > = 0 > > > 7 errors generated. > > > > > > Is the fix just to initialize err to 0 as it suggests or should there be > > > a different fix? > > > > Yes, that's the correct fix. Thanks for catching this. We had "err = 0" > > in v4 of this patch set, but it somehow didn't make it to v5. > > Nathan, I just sent a simple one-liner patch. If you don't mind, > may we ask Andrew to take it as a fixup (folded) patch? Yup, sounds like a plan to me, thanks for the quick response and fix! Cheers, Nathan