From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9350AC433FE for ; Thu, 10 Nov 2022 14:39:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FD2C6B0071; Thu, 10 Nov 2022 09:39:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 186686B0072; Thu, 10 Nov 2022 09:39:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 026D16B0074; Thu, 10 Nov 2022 09:39:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E483D6B0071 for ; Thu, 10 Nov 2022 09:39:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8C5AAAB25D for ; Thu, 10 Nov 2022 14:39:04 +0000 (UTC) X-FDA: 80117789808.14.73678C9 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf10.hostedemail.com (Postfix) with ESMTP id DD5ECC0007 for ; Thu, 10 Nov 2022 14:39:03 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id p21so1530857plr.7 for ; Thu, 10 Nov 2022 06:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2PGUxq/3jr/sRYtdOzve4iX/PaZyflMzPk7cd+r6fN8=; b=cfHSUeylFvDkPA50hnFYS1kPYhccS/gXTdhk7dZcWCY4605DOV1f4Xi273Lj/y6vOy m4h1gHDigu+arY2xQfOtUwQz988fUn9JRzenlO8tBvu/aFyi19PxZDBd86c+m7XEEfqY eURXFhAT5EqdnGpQoYJ901hNlQrk0pxuDqQbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2PGUxq/3jr/sRYtdOzve4iX/PaZyflMzPk7cd+r6fN8=; b=fxrNgAbsSOF8IV/KiDKorkL0id4ZZCJaAm0ZE9/r9SuX+yqfeRb34zJSDG/TXeu8dD KdRaQ/cTSYVSHcp2C6yTF/vyxrH22wVc8nqfRHajp5MzOeG8kWbX9HzevWWZWwwHmL7N 6DNZzhujRIrAfPQraw3g1kxq1qXPvuF2IK0KBdQfC0I1PZcQUH2C3HMIHLwDWbofiG0A g7owG+W09onlTED6rbGxwPmNlQgiX5uOVS6wzLMoX4uTjFCyY5A3i/EA3S7Xt2vEOU/r TtF3i1QvDlVzQsXqT4zU+zn4GIEa82MeLfK3QxLvzQEFO/eO76GsfDquoIY10T00H+my /OiA== X-Gm-Message-State: ACrzQf3/vDESSHrWBGsTG3V/jof/CUPnOqTqG6j1Gp7stTWKZ1DLBGsN WtFLwZDwFrTgyLUDEDUDLLcpDw== X-Google-Smtp-Source: AMsMyM7cQ+Eg0HOXosvU60zj4qjXokv+g7kNRrpz9O7C0hdw5QOxrd11RmRIwahFoKAXxzBg023KCQ== X-Received: by 2002:a17:90b:84:b0:213:de0c:1253 with SMTP id bb4-20020a17090b008400b00213de0c1253mr58789136pjb.74.1668091142796; Thu, 10 Nov 2022 06:39:02 -0800 (PST) Received: from google.com ([240f:75:7537:3187:2129:96b6:e6b9:b930]) by smtp.gmail.com with ESMTPSA id w25-20020aa79559000000b0056b8181861esm10601355pfq.19.2022.11.10.06.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:39:02 -0800 (PST) Date: Thu, 10 Nov 2022 23:38:57 +0900 From: Sergey Senozhatsky To: Nathan Chancellor , Andrew Morton Cc: Minchan Kim , Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Sergey Senozhatsky Subject: Re: [PATCHv5 04/13] zram: Introduce recompress sysfs knob Message-ID: References: <20221109115047.2921851-1-senozhatsky@chromium.org> <20221109115047.2921851-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668091144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2PGUxq/3jr/sRYtdOzve4iX/PaZyflMzPk7cd+r6fN8=; b=xRgj0wvpv9po/NB8vMM+9xcr3aIKlPr2pxjEuS4oDkKL8Lywo7GbudEwuK3f/yPozBj7G6 qGtMD1fHeS3XS5L1NpQLoljyuxmrj0JF9D8QtKP6VOn06scyl2vXRzN6enSOuC6JRNQ8Du n5mqZN1TJFyHK/GTfA7FadWsdzQuTYs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cfHSUeyl; spf=pass (imf10.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668091144; a=rsa-sha256; cv=none; b=OOSM8jo7ZZP/B/ztMCe3XHfl/kVIy+0T3o4W9gC1ppnmZOkatifj/NCItHzIoSe/Es3sWx HZrZuCjZo4gO4xrz8P6c4ofcbPjuer/lkvFMBfCKMJaEhnoD9SdtG/RI7iyLdd99dBO4wf Ia9bvqusXzW+STsXzXoSjeoXlMP5DAA= X-Rspam-User: X-Stat-Signature: cai316azhak8n43dex5nyc4s18uw3mqs X-Rspamd-Queue-Id: DD5ECC0007 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cfHSUeyl; spf=pass (imf10.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam07 X-HE-Tag: 1668091143-925787 X-Bogosity: Ham, tests=bogofilter, spamicity=0.034881, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/10 23:31), Sergey Senozhatsky wrote: > On (22/11/10 06:09), Nathan Chancellor wrote: > [..] > > drivers/block/zram/zram_drv.c:1894:10: note: initialize the variable 'err' to silence this warning > > int err; > > ^ > > = 0 > > 7 errors generated. > > > > Is the fix just to initialize err to 0 as it suggests or should there be > > a different fix? > > Yes, that's the correct fix. Thanks for catching this. We had "err = 0" > in v4 of this patch set, but it somehow didn't make it to v5. Nathan, I just sent a simple one-liner patch. If you don't mind, may we ask Andrew to take it as a fixup (folded) patch?