From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D66EC433FE for ; Thu, 10 Nov 2022 14:31:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4D616B0071; Thu, 10 Nov 2022 09:31:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFD446B0072; Thu, 10 Nov 2022 09:31:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC5046B0074; Thu, 10 Nov 2022 09:31:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA59C6B0071 for ; Thu, 10 Nov 2022 09:31:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 684331615DD for ; Thu, 10 Nov 2022 14:31:58 +0000 (UTC) X-FDA: 80117771916.10.30F504B Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf19.hostedemail.com (Postfix) with ESMTP id AF8581A000E for ; Thu, 10 Nov 2022 14:31:57 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id b1-20020a17090a7ac100b00213fde52d49so1645934pjl.3 for ; Thu, 10 Nov 2022 06:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yKZ49Hq5cxRBRGuGWZmrWmyUCChzQiTYq0wPx6wHlvc=; b=EHHqa2wvLN4L0h+BDA+s7vsVb5mNPysYohstSXuowrBlnagzJejUduUwbh+UwOJGma sPx4kJMLuI/Sf5LBbDMOPEtM8+HvB+lA5eUWBNSuFFS6a/c0nCaYcGxerABB3rMzLRDY npaxx1QtDVmujfUgvXcRQclUJek9MYBes323s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yKZ49Hq5cxRBRGuGWZmrWmyUCChzQiTYq0wPx6wHlvc=; b=CvUJacbIKUisfiNXQVqy8ZlxoMsC9GzBgOXobxi/c9x+LQS7M2b751+aId52mKJthv yRk6zhMg96m2PATUGbEubYXHfx5MxECqP+pN0k1VgtsDmWawla8lLgjLABwyzXdcjTxO pCx3Bgd2rTqiTLLqTJ/c4BLHv+nLqC+o98V3yw7DXuA1ikTncOsF1+a196tnk32ZNB7t kHdyw9NcMuWU/c/FteH5juSSm7e9ySZAkJ1q/YQIPhb5JoK6vmed9w2CfmoM7ANo1dXa aKFADlhc3so487TuY6TN3qfvKcJMDbE19eTZ04nv9JTqIKWsy016Sq93NtNJe9QEMmEM 7FWw== X-Gm-Message-State: ACrzQf04fFp7ywgM4+6SGucdKlSVgNn94GUv0BGdkvnWg7QNECT4KaB8 TjDJpZW9uCZVYzx6SvWXiuLFqY6pEoULPg== X-Google-Smtp-Source: AMsMyM5FM6+Inj4VnlE00+/2ySDhZb9ew7QK2Sfkx1aMTS/XaSkyEbT5L3/ntwCsotmKq8D+ABCOoQ== X-Received: by 2002:a17:90a:784c:b0:213:5b03:62e with SMTP id y12-20020a17090a784c00b002135b03062emr65667417pjl.241.1668090716334; Thu, 10 Nov 2022 06:31:56 -0800 (PST) Received: from google.com ([240f:75:7537:3187:2129:96b6:e6b9:b930]) by smtp.gmail.com with ESMTPSA id p189-20020a6229c6000000b0056c08c87196sm10192940pfp.48.2022.11.10.06.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:31:55 -0800 (PST) Date: Thu, 10 Nov 2022 23:31:51 +0900 From: Sergey Senozhatsky To: Nathan Chancellor Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , Nitin Gupta , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCHv5 04/13] zram: Introduce recompress sysfs knob Message-ID: References: <20221109115047.2921851-1-senozhatsky@chromium.org> <20221109115047.2921851-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668090717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yKZ49Hq5cxRBRGuGWZmrWmyUCChzQiTYq0wPx6wHlvc=; b=6dcluS3Pd991XHLP88kQF+GQlRdLI834hZ3gtnvkFDGiG0sO3W1Y/TGSgWQDZA/XMfWA// 3XOLiZtWBkPIfXHFCOLh5zOK/RoxiwONfqQKAxi+V2UzOkB/7xM+e5RsuaOuyfBrefnTwh 3WjW+aWAyRpUlxYCmzrZTpRrD0tv/wA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EHHqa2wv; spf=pass (imf19.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668090717; a=rsa-sha256; cv=none; b=r1r3NvLUg3QM40s5hD2ai6P9+HXmqzVqG/CbgKwgRC10z7CiLckqGKPKIk57cVKEIQM+xo mIzSA+sC1EtbkOKPmy0iDsvhyRTn2E1eY8GrgbRjE+CW9T5NIx8xXQ/hkrLf1ZEre8hAHI O24vTGeDmEE5kxINZJCAkKV1CBNRqqI= X-Rspamd-Queue-Id: AF8581A000E X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EHHqa2wv; spf=pass (imf19.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: qk7sq4kaitn99mjiaqmzygazxn3w4wn3 X-HE-Tag: 1668090717-752966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.152765, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/10 06:09), Nathan Chancellor wrote: [..] > drivers/block/zram/zram_drv.c:1894:10: note: initialize the variable 'err' to silence this warning > int err; > ^ > = 0 > 7 errors generated. > > Is the fix just to initialize err to 0 as it suggests or should there be > a different fix? Yes, that's the correct fix. Thanks for catching this. We had "err = 0" in v4 of this patch set, but it somehow didn't make it to v5.