From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97775C433FE for ; Thu, 10 Nov 2022 17:53:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00C886B0071; Thu, 10 Nov 2022 12:53:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFEA66B0072; Thu, 10 Nov 2022 12:53:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9FAA8E0001; Thu, 10 Nov 2022 12:53:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C8D336B0071 for ; Thu, 10 Nov 2022 12:53:35 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8B2E5C094E for ; Thu, 10 Nov 2022 17:53:35 +0000 (UTC) X-FDA: 80118279990.21.B437483 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 0EABC40002 for ; Thu, 10 Nov 2022 17:53:34 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id z5-20020a17090a8b8500b00210a3a2364fso6200141pjn.0 for ; Thu, 10 Nov 2022 09:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2oKQDlB6eYx+fAXvKZFnqwvhnIR4JQKKCXs9/v8+asA=; b=USq4b5Vh1OXggTCD0w44axvUCuw0wgwmRJONRIlB95PFBRewtOpmoKc7I2XbMFe+Jt py6SLDlrcfHe9Q3VO4+7dfiMGs6dPX9qHKjrdWteekp4+U/DoQ8k4+BtA12MyhPAKSwW oWUbDGwbmbtRu0HlyiAF1gzP3/dmYGn+4ag1yp2zQxUQz3Y8R8NAepQDJa1zRgnFTAwp 482q2MupCDGAkGCVertYK1p6MwGRwEAvRckuUOPwVBujunwWETFLz4d1bnde8cgKCLkj 6U6T7ZnM4yWVZOheoRcwISEPaZCMlXQ5G+O2GSFI15kWlhWhoPX3ZMRej3KuRu/bUqnC oRxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2oKQDlB6eYx+fAXvKZFnqwvhnIR4JQKKCXs9/v8+asA=; b=59zViDxbH8/MVTfj6V4sjwR8Yt8aWJ4twXXfuTo7nJnLX8CAwAFhdMpp6/wY9oK1me 0nE0/qD2xDniCG2yPAFYCtbD39UIWhG/UnY12tBD/Ml/6mvs5Sd3zR8sqiceFPZqEPnq 0+wbX+ui4K4shBH2lkYWTDfwrKAeHhfk0mAlwuDYamJzJcwHAGgu0h8c8DUV23vLon6F y/nMJkUF2mD3TYG7I/I6/bppZDZuMbe5o793nX6ndq+6ZGfCFsHLbF5JMcVJYTN+6nMm jkutOz+zCMOacYBhRIO1EvJ7KEBUK3eaEu3pMDA3cgJOWIhybSCnyWr1QfstjjzA0GAA LoPQ== X-Gm-Message-State: ANoB5pkp2pq09JkVkJEPARX1SVRZt7LxDRjv90XSTMZbWgoGcZJ70E1V ZBilgY5LuYdZ3EFp29MpDhtwpg== X-Google-Smtp-Source: AA0mqf5Tm7voUfqlq46fUuj/FQZ0U+LCKMGUSx8RMJOkkJOakWUAIRLRpdmCoJrBserqv+E6AVAQEA== X-Received: by 2002:a17:903:120f:b0:188:82fc:e259 with SMTP id l15-20020a170903120f00b0018882fce259mr18758217plh.61.1668102813812; Thu, 10 Nov 2022 09:53:33 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i13-20020a170902c94d00b00172e19c5f8bsm11666966pla.168.2022.11.10.09.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 09:53:33 -0800 (PST) Date: Thu, 10 Nov 2022 17:53:29 +0000 From: Sean Christopherson To: Chao Peng Cc: Fuad Tabba , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song , wei.w.wang@intel.com Subject: Re: [PATCH v9 4/8] KVM: Use gfn instead of hva for mmu_notifier_retry Message-ID: References: <20221025151344.3784230-1-chao.p.peng@linux.intel.com> <20221025151344.3784230-5-chao.p.peng@linux.intel.com> <20221104022813.GA4129873@chaop.bj.intel.com> <20221108071624.GA76278@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108071624.GA76278@chaop.bj.intel.com> ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=USq4b5Vh; spf=pass (imf11.hostedemail.com: domain of seanjc@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668102815; a=rsa-sha256; cv=none; b=KREAVEilo8vctsV+y+dhHtiTNQ0EatrXlVxaR/BIByP4XDZ1eGvj0py1FCIF7W8vkVaCHA obmziDQaopVGefB6bg2rdOjmTXJnKQ9wiSR1YjXj8ELue5KxAOJFt/EpkvOpoPpNHrGX49 oO6f21NElztp0Jap/Dj2Xlbh3CVwqn4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668102815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2oKQDlB6eYx+fAXvKZFnqwvhnIR4JQKKCXs9/v8+asA=; b=M3TKjQaewmhvhNjRd1WNUYx5cDjj5F8E0Rgr5WOCS9vzhNzCrIihpBjr/6sSL8WR2/OyRz 3WTPGvhYLG0BlS8yexRaCDfbwDGAeL0VT7JnRzm7w3jnHA+JKYhtum6f5UV10f4egTIV5l m1NUwDTgq2oQZGsyvBCrsXG0PfI9+pg= X-Stat-Signature: uj1zphk9ueyf59nnrrdcucrombrpjj6d X-Rspamd-Queue-Id: 0EABC40002 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=USq4b5Vh; spf=pass (imf11.hostedemail.com: domain of seanjc@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam11 X-HE-Tag: 1668102814-862169 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 08, 2022, Chao Peng wrote: > On Fri, Nov 04, 2022 at 10:29:48PM +0000, Sean Christopherson wrote: > > The APICv case that this was added for could very well be broken because of > > this, and the resulting failures would be an absolute nightmare to debug. > > Given the apicv_inhibit should be rare, the change looks good to me. > Just to be clear, your will send out this fix, right? Ya, I'll post an official patch.