From: Johannes Weiner <hannes@cmpxchg.org>
To: Hongchen Zhang <zhanghongchen@loongson.cn>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Hugh Dickins <hughd@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] mm: vmscan: fix extreme overreclaim and swap floods
Date: Sat, 12 Nov 2022 09:23:41 -0500 [thread overview]
Message-ID: <Y2+sbbirX11Vo+XM@cmpxchg.org> (raw)
In-Reply-To: <17f04d65-020e-a52d-41e8-0d540e32b475@loongson.cn>
On Tue, Sep 20, 2022 at 02:12:17PM +0800, Hongchen Zhang wrote:
> On 2022/8/3 am 12:28, Johannes Weiner wrote:
> > @@ -2988,8 +2988,6 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
> > nr_scanned = targets[lru] - nr[lru];
> > nr[lru] = targets[lru] * (100 - percentage) / 100;
> > nr[lru] -= min(nr[lru], nr_scanned);
> We should not just remove the following line because kswapd may also call
> this function and there is no side effect to do scan adjust for kswapd,so it
> may be better to change like this:
> + if (current_is_kswapd())
> scan_adjusted = true;
> > -
> > - scan_adjusted = true
There is no scan_adjusted after this patch.
If you're saying that kswapd should set proportional_reclaim
unconditionally, then no, it should not. Proportional reclaim is not
safe at lower priority levels, as the changelog outlines in detail.
prev parent reply other threads:[~2022-11-12 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 16:28 Johannes Weiner
2022-08-03 0:06 ` Andrew Morton
2022-08-03 13:28 ` Johannes Weiner
2022-08-03 17:27 ` Rik van Riel
2022-08-04 9:38 ` Mel Gorman
2022-08-08 13:54 ` Yosry Ahmed
2022-08-08 14:07 ` Yosry Ahmed
2022-08-12 1:59 ` Joonsoo Kim
2022-11-12 22:48 ` Johannes Weiner
2022-09-20 6:12 ` Hongchen Zhang
2022-11-12 14:23 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2+sbbirX11Vo+XM@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=yosryahmed@google.com \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox