From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC214ECAAA1 for ; Fri, 28 Oct 2022 21:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B3E76B0072; Fri, 28 Oct 2022 17:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 563858E0002; Fri, 28 Oct 2022 17:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42B176B0075; Fri, 28 Oct 2022 17:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 33FBC6B0072 for ; Fri, 28 Oct 2022 17:44:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 09BFC4144F for ; Fri, 28 Oct 2022 21:44:56 +0000 (UTC) X-FDA: 80071688592.05.D4ECCD9 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf10.hostedemail.com (Postfix) with ESMTP id A68FAC003D for ; Fri, 28 Oct 2022 21:44:53 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id z5-20020a17090a8b8500b00210a3a2364fso8816459pjn.0 for ; Fri, 28 Oct 2022 14:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MbmaR31M+RApIMzVSM0N1/6XpnX9rZEL8RQBXhLK0ag=; b=rR5GMhkYJW8HNX1LwsZOUwity9IOw73+RU0HPnrrfAeArgyXrmalZPS22RWlwiJLeN Ae3/juCFLSPKYPNaZmuwwAWus+hVMXSo1y0fcxHobo5IJJOD2kuLZlfP8xm1CqZPH0YS qq0Pf1OHsos7X9eAXMxx+FRu6DzhW+uL6NFgXEoLuSmqVBxiI7fnH9VjSprlok4zZlUI T9dgTa6oOd7Pyt/EZvoYHRPM57+qUvmVPnZwzmpND3SlnrDOfmiMSCj8TY5FtMXf6JHD jpa8ZY0olVQww5x3O+VVrodwB9bHNZ0sg+XugjFNVTSU5MSP0CAmj4WqE8/fxSDyfGX7 dOzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MbmaR31M+RApIMzVSM0N1/6XpnX9rZEL8RQBXhLK0ag=; b=4mgFUxFZdox9wDbbFOGWTMxgAUGBPqbWUQpoFxvp84Ek5wNFmWqG9ryNkKS+ajN9S7 3AfC9/hcDjQ/4cgPSxFdofZhPONJWe/kKWe5v1AxJeT8/wM0NCQ9cnG4E672vusM0OY+ Xb9GoBl4w1EnE6eMzOp5blrjuPG+4u8qScyrO8i08UUtvVsgsX7b0rZO23eCh9XK0vNT /AfzZQNViH+M5lJgNM1Nb1AM4nM7sOu730Gt4jnHVAbNsXl5hUygAExLT0faQY83eyYy Zo2EOhugrIlQ2Ti2iLF/+1zSEzChsFuhYCcekaC4bVIlyABoIpHTNgKV98K8DFgsiG6V DvnA== X-Gm-Message-State: ACrzQf2YgXbNKUVS+uo4k3Z0gFOCW0SAb2moYW4gb5bvDRCl1lBK23In 3PWckgrSiTPBUWuyASkZIz47Mw== X-Google-Smtp-Source: AMsMyM7r9lQD7U8RVTx3xIK1OT+oVxp2UU49B4tnIUu5YoP6p1edIGkjpahRem/Xd/3dlZClg7DKhA== X-Received: by 2002:a17:90b:11d4:b0:212:ee83:481 with SMTP id gv20-20020a17090b11d400b00212ee830481mr1399980pjb.36.1666993492108; Fri, 28 Oct 2022 14:44:52 -0700 (PDT) Received: from google.com (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id jj20-20020a170903049400b001867fb4056asm3498591plb.32.2022.10.28.14.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 14:44:51 -0700 (PDT) Date: Fri, 28 Oct 2022 14:44:48 -0700 From: Zach O'Keefe To: Yang Shi Cc: syzbot , Mel Gorman , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] WARNING in alloc_charge_hpage Message-ID: References: <000000000000553fc805ec1380e0@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666993493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MbmaR31M+RApIMzVSM0N1/6XpnX9rZEL8RQBXhLK0ag=; b=fhdW6VWrlXjJ5he1/Gyx2RhgCsPjYwUKUoLwyvwgpsCCWaG7zViyHtNNEhe0q+Kylije10 kdA3kkPsKO6MEIkuzxFF7IBsT+qZ7Rl3GjfV3CNlvMGAC9o8clcLajox9tgyvSLIj46amF sZzAziogFUqlcQoBiCqyJ8s6V7jkLOQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rR5GMhkY; spf=pass (imf10.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666993493; a=rsa-sha256; cv=none; b=SPcNkzV+A678nWZIbcHMi2m6/nJYgQoaqCSI1z+2RxT1ULpAFiG3Cj9tMLRctUwMKEhGR+ IoEUKN79CFShN6v6NQ2qERPSBYtQV2hTc8IhLSN8uGDMoPFZfoBp+vsltXcEMygl0KKL07 TLjHe5U2hj/HVuftkmhkNo9LjWqnnyo= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rR5GMhkY; spf=pass (imf10.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Queue-Id: A68FAC003D X-Rspamd-Server: rspam03 X-Stat-Signature: xja85u7jg1zcqb76fice4xdsnr9tzqow X-HE-Tag: 1666993493-669130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Oct 28 10:37, Yang Shi wrote: > On Fri, Oct 28, 2022 at 12:49 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: a70385240892 Merge tag 'perf_urgent_for_v6.1_rc2' of git:/.. > > git tree: upstream > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=13f4726a880000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=ea03ca45176080bc > > dashboard link: https://syzkaller.appspot.com/bug?extid=0044b22d177870ee974f > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13726f72880000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13b57436880000 > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/5e17f1e83cf3/disk-a7038524.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/f8ef729877f7/vmlinux-a7038524.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+0044b22d177870ee974f@syzkaller.appspotmail.com > > > > ------------[ cut here ]------------ > > WARNING: CPU: 1 PID: 3646 at include/linux/gfp.h:221 __alloc_pages_node include/linux/gfp.h:221 [inline] > > WARNING: CPU: 1 PID: 3646 at include/linux/gfp.h:221 hpage_collapse_alloc_page mm/khugepaged.c:807 [inline] > > WARNING: CPU: 1 PID: 3646 at include/linux/gfp.h:221 alloc_charge_hpage+0x802/0xaa0 mm/khugepaged.c:963 > > It looks like the node requested by the allocation is offlined, and > the allocation is using __GFP_THISNODE. It doesn't sound like > khugepaged specific problem IIUC, I don't see other callsites do > anything to prevent the node from being offlined. > > Shall we remove that warn? The page allocation call will return NULL > anyway. Or we could just ignore the warn? > Thanks for taking a look, Yang. As for the warn -- I don't see the value in the warning at present. As you mention, I don't think it's a khugepaged-thing (as, at least from skimming, other callsites don't take care to expect that the node is online). The allocation might fail -- for a number of reasons -- and I don't think __GFP_THISNODE + offline node is so special to deserve a warn. A different question, is if this particular callsite wants to defend against that possibility. My understanding, which I state without data, is that the performance of accessing remote memory outweighs the benefit of pmd-mapping the memory -- and so I think we rightly fail here. So, my vote is to just remove the warn. Thanks, Zach > > Modules linked in: > > CPU: 1 PID: 3646 Comm: syz-executor210 Not tainted 6.1.0-rc1-syzkaller-00454-ga70385240892 #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022 > > RIP: 0010:__alloc_pages_node include/linux/gfp.h:221 [inline] > > RIP: 0010:hpage_collapse_alloc_page mm/khugepaged.c:807 [inline] > > RIP: 0010:alloc_charge_hpage+0x802/0xaa0 mm/khugepaged.c:963 > > Code: e5 01 4c 89 ee e8 6e f9 ae ff 4d 85 ed 0f 84 28 fc ff ff e8 70 fc ae ff 48 8d 6b ff 4c 8d 63 07 e9 16 fc ff ff e8 5e fc ae ff <0f> 0b e9 96 fa ff ff 41 bc 1a 00 00 00 e9 86 fd ff ff e8 47 fc ae > > RSP: 0018:ffffc90003fdf7d8 EFLAGS: 00010293 > > RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 > > RDX: ffff888077f457c0 RSI: ffffffff81cd8f42 RDI: 0000000000000001 > > RBP: ffff888079388c0c R08: 0000000000000001 R09: 0000000000000000 > > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > > R13: dffffc0000000000 R14: 0000000000000000 R15: 0000000000000000 > > FS: 00007f6b48ccf700(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 00007f6b48a819f0 CR3: 00000000171e7000 CR4: 00000000003506e0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > collapse_file+0x1ca/0x5780 mm/khugepaged.c:1715 > > hpage_collapse_scan_file+0xd6c/0x17a0 mm/khugepaged.c:2156 > > madvise_collapse+0x53a/0xb40 mm/khugepaged.c:2611 > > madvise_vma_behavior+0xd0a/0x1cc0 mm/madvise.c:1066 > > madvise_walk_vmas+0x1c7/0x2b0 mm/madvise.c:1240 > > do_madvise.part.0+0x24a/0x340 mm/madvise.c:1419 > > do_madvise mm/madvise.c:1432 [inline] > > __do_sys_madvise mm/madvise.c:1432 [inline] > > __se_sys_madvise mm/madvise.c:1430 [inline] > > __x64_sys_madvise+0x113/0x150 mm/madvise.c:1430 > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > RIP: 0033:0x7f6b48a4eef9 > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > > RSP: 002b:00007f6b48ccf318 EFLAGS: 00000246 ORIG_RAX: 000000000000001c > > RAX: ffffffffffffffda RBX: 00007f6b48af0048 RCX: 00007f6b48a4eef9 > > RDX: 0000000000000019 RSI: 0000000000600003 RDI: 0000000020000000 > > RBP: 00007f6b48af0040 R08: 0000000000000000 R09: 0000000000000000 > > R10: 0000000000000000 R11: 0000000000000246 R12: 00007f6b48aa53a4 > > R13: 00007f6b48bffcbf R14: 00007f6b48ccf400 R15: 0000000000022000 > > > > > > > > --- > > This report is generated by a bot. It may contain errors. > > See https://goo.gl/tpsmEJ for more information about syzbot. > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > syzbot will keep track of this issue. See: > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > syzbot can test patches for this issue, for details see: > > https://goo.gl/tpsmEJ#testing-patches > >