From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79ECAC38A02 for ; Fri, 28 Oct 2022 13:16:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15E966B0072; Fri, 28 Oct 2022 09:16:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10F806B0073; Fri, 28 Oct 2022 09:16:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F18BD6B0074; Fri, 28 Oct 2022 09:16:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E27426B0072 for ; Fri, 28 Oct 2022 09:16:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A64611C6DF1 for ; Fri, 28 Oct 2022 13:16:05 +0000 (UTC) X-FDA: 80070406290.04.54DD5AC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 771B4C0015 for ; Fri, 28 Oct 2022 13:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666962963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DCIhC8zsshoND/IKtTdIBlXsbzziW2vFBGZp5eT8E28=; b=IvkXuoZBAHVV9tnkU39UwOmtm8+8qkuTYraRAW48zqpY1otpBJmYuHBkdasc2pILaU+/lt OrGlUC3GvuqGtvfjwB1SmwXGWRRpUT/DAxgn/RnvHPafIF3J2dVsoeLjS6Z9bZZ/Byt2j5 4gP/Mn6Gxw/J6vvt3QlhBQp+glyUTDk= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-134-psSZLjtqNbi9b3y98X_YpA-1; Fri, 28 Oct 2022 09:16:02 -0400 X-MC-Unique: psSZLjtqNbi9b3y98X_YpA-1 Received: by mail-il1-f199.google.com with SMTP id z19-20020a056e02089300b002fffe186ac4so5078943ils.8 for ; Fri, 28 Oct 2022 06:16:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DCIhC8zsshoND/IKtTdIBlXsbzziW2vFBGZp5eT8E28=; b=VPWzzO2d+/cN6QTLjw3Lr4rEYrA+krFuqCIoL/rkjsdMiEW6r9sdXfOCYN9yvCQKWd q8u0Ha6VF/UaAsNx8ZcGEL0ZC2ErIEVY5551fT+6SyhWcxJufg4yxGJKDo+eBXKm9FaA R5WNfFc6++6D6B3TmfNqNMhVYyre0l+6qCw+h/MRAZGV90RM2X1s+ax6uZ4GKjEHOGKG 2ToqpE6yxdnqtuLnBDiTcW+JwJFgSM03A0WwIvTfW3U05fUZP/bTpKTweKVTvXXvpWsK I7SQeQkE+1pE+j711D9htTZq+D6uUK+oJCWisl91PLIIr7RLIqa6FzK2RDUXsSiLzCDd itgA== X-Gm-Message-State: ACrzQf3wuw9tK5pRNXykYaIml1g2DJw6+ZTnEM4zOwvJTpawAP/Bkr4p kzWqGVEhFyCPzZZbBPv0+QrbdgoKsdNZtumHDpXHBO8NGJOyhwLjAKhglI1/D6wAGC0Xdk4GkFj oRT43ZEppYUA= X-Received: by 2002:a05:6e02:1583:b0:2d7:a75d:888f with SMTP id m3-20020a056e02158300b002d7a75d888fmr32576754ilu.13.1666962960213; Fri, 28 Oct 2022 06:16:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Go9xf8PhE/RwBk9BCvHfOp+3vYphyvr54+fn/Xwd77w4wrhKWARDKobHygJ+1ZMb3LmhZFQ== X-Received: by 2002:a05:6e02:1583:b0:2d7:a75d:888f with SMTP id m3-20020a056e02158300b002d7a75d888fmr32576741ilu.13.1666962959923; Fri, 28 Oct 2022 06:15:59 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id ay31-20020a5d9d9f000000b006c75c702342sm1493014iob.14.2022.10.28.06.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 06:15:59 -0700 (PDT) Date: Fri, 28 Oct 2022 09:15:57 -0400 From: Peter Xu To: Yuanzheng Song Cc: akpm@linux-foundation.org, david@redhat.com, hughd@google.com, gregkh@linuxfoundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH STABLE 5.10 v2] mm/memory: add non-anonymous page check in the copy_present_page() Message-ID: References: <20221028030705.2840539-1-songyuanzheng@huawei.com> MIME-Version: 1.0 In-Reply-To: <20221028030705.2840539-1-songyuanzheng@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666962964; a=rsa-sha256; cv=none; b=IL6nf0wKS5E7ps67Y4SxhdTJpQppDs/7MYNNkKbNWOY0f41lqnEiU3SMLc/6rqoD0n7neS vbKK3kZRr0Cpm0ujPuMVvcfe3B65jZWwIO600i6tDX73YMkNSMAvqy3VD1nPDvqgV6DOeZ UO/Qs5hVURybFLy4UJsw17eiauns35s= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IvkXuoZB; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666962964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DCIhC8zsshoND/IKtTdIBlXsbzziW2vFBGZp5eT8E28=; b=a7YRNCFNRUun9FNykrMA1aU3LpWSBN6gJxIxMx0QTRCv8F5A/qJc+pSrFLLUI6t0rgKO2I 0pzs0AEVdgkKSfkMY5Sva6w6I22qr0kfQOGm4RMw1LFdyZapii9qk6wO/M+G0A/lsCoF5P RhKV04F4beQJINwrNsECiKffiPqQFpQ= Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IvkXuoZB; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 771B4C0015 X-Stat-Signature: f3iuwd77fi5mnteaprfat7di9y4xs3k3 X-Rspam-User: X-HE-Tag: 1666962964-968433 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 28, 2022 at 03:07:05AM +0000, Yuanzheng Song wrote: > The vma->anon_vma of the child process may be NULL because > the entire vma does not contain anonymous pages. In this > case, a BUG will occur when the copy_present_page() passes > a copy of a non-anonymous page of that vma to the > page_add_new_anon_rmap() to set up new anonymous rmap. > > ------------[ cut here ]------------ > kernel BUG at mm/rmap.c:1044! > Internal error: Oops - BUG: 0 [#1] SMP > Modules linked in: > CPU: 2 PID: 3617 Comm: test Not tainted 5.10.149 #1 > Hardware name: linux,dummy-virt (DT) > pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=--) > pc : __page_set_anon_rmap+0xbc/0xf8 > lr : __page_set_anon_rmap+0xbc/0xf8 > sp : ffff800014c1b870 > x29: ffff800014c1b870 x28: 0000000000000001 > x27: 0000000010100073 x26: ffff1d65c517baa8 > x25: ffff1d65cab0f000 x24: ffff1d65c416d800 > x23: ffff1d65cab5f248 x22: 0000000020000000 > x21: 0000000000000001 x20: 0000000000000000 > x19: fffffe75970023c0 x18: 0000000000000000 > x17: 0000000000000000 x16: 0000000000000000 > x15: 0000000000000000 x14: 0000000000000000 > x13: 0000000000000000 x12: 0000000000000000 > x11: 0000000000000000 x10: 0000000000000000 > x9 : ffffc3096d5fb858 x8 : 0000000000000000 > x7 : 0000000000000011 x6 : ffff5a5c9089c000 > x5 : 0000000000020000 x4 : ffff5a5c9089c000 > x3 : ffffc3096d200000 x2 : ffffc3096e8d0000 > x1 : ffff1d65ca3da740 x0 : 0000000000000000 > Call trace: > __page_set_anon_rmap+0xbc/0xf8 > page_add_new_anon_rmap+0x1e0/0x390 > copy_pte_range+0xd00/0x1248 > copy_page_range+0x39c/0x620 > dup_mmap+0x2e0/0x5a8 > dup_mm+0x78/0x140 > copy_process+0x918/0x1a20 > kernel_clone+0xac/0x638 > __do_sys_clone+0x78/0xb0 > __arm64_sys_clone+0x30/0x40 > el0_svc_common.constprop.0+0xb0/0x308 > do_el0_svc+0x48/0xb8 > el0_svc+0x24/0x38 > el0_sync_handler+0x160/0x168 > el0_sync+0x180/0x1c0 > Code: 97f8ff85 f9400294 17ffffeb 97f8ff82 (d4210000) > ---[ end trace a972347688dc9bd4 ]--- > Kernel panic - not syncing: Oops - BUG: Fatal exception > SMP: stopping secondary CPUs > Kernel Offset: 0x43095d200000 from 0xffff800010000000 > PHYS_OFFSET: 0xffffe29a80000000 > CPU features: 0x08200022,61806082 > Memory Limit: none > ---[ end Kernel panic - not syncing: Oops - BUG: Fatal exception ]--- > > This problem has been fixed by the commit > ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() > and page_try_dup_anon_rmap()"), but still exists in the > linux-5.10.y branch. > > This patch is not applicable to this version because > of the large version differences. Therefore, fix it by > adding non-anonymous page check in the copy_present_page(). > > Cc: stable@vger.kernel.org > Fixes: 70e806e4e645 ("mm: Do early cow for pinned pages during fork() for ptes") > Signed-off-by: Yuanzheng Song Acked-by: Peter Xu -- Peter Xu