From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A550C38A2D for ; Tue, 25 Oct 2022 20:43:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABE608E0002; Tue, 25 Oct 2022 16:43:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6DFC8E0001; Tue, 25 Oct 2022 16:43:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 935B38E0002; Tue, 25 Oct 2022 16:43:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 806D48E0001 for ; Tue, 25 Oct 2022 16:43:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 52D3A1C48B7 for ; Tue, 25 Oct 2022 20:43:22 +0000 (UTC) X-FDA: 80060647044.19.7655D62 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf06.hostedemail.com (Postfix) with ESMTP id B499918000A for ; Tue, 25 Oct 2022 20:43:21 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id l9so6514340qkk.11 for ; Tue, 25 Oct 2022 13:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ub0BSMQoXwxgMbCEulstR2TYu+9kYjLpcZILAjgqG30=; b=VeEO2vjrQ0ESCZCTGDSoSw4KEGYai2RbrNxNuSJSbH7Wg6g1MrSYPkBaDNeAr3eCfb F2VAyCJ2YtPJI00XidiYHZM9FvhW5nYm8DaSOnhf+yXpp/pa8t4qPREUf+5HhNE4ThLz K91Op+1qbhqIJn+nKRLMQtyNg2vi5BCpT3o1y5/Z6RoLT39vhcPMeOUMWXWDObMMJBfJ DPRNrzHsRnR6GW+DRHUbyEgwvosgc31S3Oy7ss3bkOw4Y9ZvJe72aZBpUYmCUeCEq6Uc RnCWPGgSEbUTwpsVeRnancGf3un+CfvGgB8Dt+e7L9z4MhLkeaVSXze/WbCEExoZWeO5 BP1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ub0BSMQoXwxgMbCEulstR2TYu+9kYjLpcZILAjgqG30=; b=DWQUsU6SWNO8zU5SMDbWUt+p7zm/IGadGSEfjDyUrZBvWqGY9aXATS0vu632ha3+0T 8gek7l2sArBkjqH8WbXwuXXHAC4SzuXcJY5CVjjMkLkbX12FeVWaL02pTIW8YrtohAY1 e5+jE/3FbCkgMFCXwJCj1m3A7knNKMxvMQM9kn3tYqJ6sNj1LktW0MNBm/miwIcxk0IQ BJB/ZcDs2A5mGnp2wJ+01Bo4GJv7dkwWh89hA63XkNhL+iYfdIXI1SYZNVJ+eXPc/KbR 08Q+jBbWS34rUJ4BZNTcpTUuYQb+fYxXrYzmrHjSQazqByV7dvTgcVm+GPS6kPl9itQT wnOw== X-Gm-Message-State: ACrzQf1i7fsUVh42oy7GmJL99B7O97r45jwD1Alirma9OaVLnwUayP/S yuvzCyfiuu/Qr7l3z9x5s8BV8A== X-Google-Smtp-Source: AMsMyM7a+tSlftH8MJH8oaBF7rMoToaHIRy3kKzxKarkYUrXhwcfTv5RoobFHvNn42sFhROGPOCGJA== X-Received: by 2002:a05:620a:2995:b0:6ee:e3a0:9fb8 with SMTP id r21-20020a05620a299500b006eee3a09fb8mr28133725qkp.165.1666730600690; Tue, 25 Oct 2022 13:43:20 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::25f1]) by smtp.gmail.com with ESMTPSA id f2-20020a05620a12e200b006eeb185c209sm2580743qkl.50.2022.10.25.13.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 13:43:20 -0700 (PDT) Date: Tue, 25 Oct 2022 16:43:20 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Bergen Subject: Re: [PATCH] mm: vmscan: split khugepaged stats from direct reclaim stats Message-ID: References: <20221025170519.314511-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666730602; a=rsa-sha256; cv=none; b=f3fIJX08fj8rVxRgF8jQVEVg1DNrqXJoS9/s4LIpxMqKy9ORoGBTyq7tpCWrvCTRdggF3I 1iiNo4z6Y0hVDRDIDMMKbvPYRQC8UUhNj6vOloZtmM1np510fdRa1+KqlKCc9M8EN13n50 skzwIwO3JkYdt0StmE3l+GyiSX65ZQw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=VeEO2vjr; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666730602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ub0BSMQoXwxgMbCEulstR2TYu+9kYjLpcZILAjgqG30=; b=OKVuN+655eTP9lG+gKtgd/ve2tWe+hRb/NLYM4k8HUkRN8bmebmj0GRLOosJ9mhA8DToHi hq3NQLDDKcQw9BDJ7lBV0eDzWsINTL2Vmih+VTUEEPOxK397zzKSQ8Ckm5UsbjkW1UDrEZ OipXYV13QYS3E+Z8cFix7n0cFzXMnFc= X-Stat-Signature: h7yo4swbsr7uud64iytbr9mgrwcu8jud X-Rspamd-Queue-Id: B499918000A Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=VeEO2vjr; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666730601-713496 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 06:16:53PM +0100, Matthew Wilcox wrote: > On Tue, Oct 25, 2022 at 01:05:19PM -0400, Johannes Weiner wrote: > > +static int reclaimer_offset(void) > > +{ > > + BUILD_BUG_ON(PGSTEAL_DIRECT - PGSTEAL_KSWAPD != 1); > > + BUILD_BUG_ON(PGSTEAL_KHUGEPAGED - PGSTEAL_KSWAPD != 2); > > + BUILD_BUG_ON(PGDEMOTE_DIRECT - PGDEMOTE_KSWAPD != 1); > > + BUILD_BUG_ON(PGDEMOTE_KHUGEPAGED - PGDEMOTE_KSWAPD != 2); > > + BUILD_BUG_ON(PGSCAN_DIRECT - PGSCAN_KSWAPD != 1); > > + BUILD_BUG_ON(PGSCAN_KHUGEPAGED - PGSCAN_KSWAPD != 2); > > + > > + if (current_is_kswapd()) > > + return 0; > > + if (current_is_khugepaged()) > > + return 2; > > + return 1; > > +} > > Would this be simpler as ... > > BUILD_BUG_ON(PGSTEAL_DIRECT - PGSTEAL_KSWAPD != > PGDEMOTE_DIRECT - PGDEMOTE_KSWAPD); > BUILD_BUG_ON(PGSTEAL_DIRECT - PGSTEAL_KSWAPD != > PGSCAN_DIRECT - PGSCAN_KSWAPD); > BUILD_BUG_ON(PGSTEAL_KHUGEPAGED - PGSTEAL_KSWAPD != > PGDEMOTE_KHUGEPAGED - PGDEMOTE_KSWAPD); > BUILD_BUG_ON(PGSTEAL_KHUGEPAGED - PGSTEAL_KSWAPD != > PGSCAN_KHUGEPAGED - PGDEMOTE_KSWAPD); > > if (current_is_kswapd()) > return 0; > if (current_is_khugepaged()) > return PGSTEAL_KHUGEPAGED - PGSTEAL_KSWAPD; > return PGSTEAL_DIRECT - PGSTEAL_KSWAPD; > > Not that I think we'd ever want to separate them, but it is perhaps a > bit less magic? Yeah that looks better. I'll do that in v2, thanks!