From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09738FA373E for ; Tue, 25 Oct 2022 19:02:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69CA88E0002; Tue, 25 Oct 2022 15:02:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64D048E0001; Tue, 25 Oct 2022 15:02:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53BB98E0002; Tue, 25 Oct 2022 15:02:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A5E68E0001 for ; Tue, 25 Oct 2022 15:02:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A8FF40A15 for ; Tue, 25 Oct 2022 19:02:16 +0000 (UTC) X-FDA: 80060392272.06.F22FA68 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 7F12C140036 for ; Tue, 25 Oct 2022 19:02:15 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id k2so15192325ejr.2 for ; Tue, 25 Oct 2022 12:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wdQpMJv+fAAdPj7JhNoObv56I8k+ulFEDb11lC7AivY=; b=lJlZT5zbsgVFeKCsWmbaL5DSMTf48Ru56giPGXdY/pQohgHr9azEIF3ixhn+tAWh/x pbaOZD2att0kTfKsdsTsl8C7ASExfvIysnxfEkWE1FEyNlSS/fOGJ8oBj4u4jptLgfaO q7rt7ptzzqwkXI+hgKYF1n/wNwKUYygRtFU+CjBdM19VG6l6OWopGfIGo9gDxokz6Oqw BUrWJ6U5FbwDcvIVNRqvvMTjxCiNqF4O/R2GlAoQdy11Zdyl1JlDOEy8a2PKTpxPIgdw fPw6db9HfDJgI6jLVrnWTwMMI+SftXJFg3N2zsQZVPtnbdaQy+RhWAWT4htQIZMRYQbc tLQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wdQpMJv+fAAdPj7JhNoObv56I8k+ulFEDb11lC7AivY=; b=mxKa5FHIpGnRMLqx8U7uIrWnajLq1DPUUhpuuqQRmTF+6oVRtPEr1vyUPNcS8NBt7S nrgDODRRyAYPmwVXO6wew5HlVJFcbWg2sfS+kkM6g/27QroBpucR6ROnj9+eERK+487f CUX2L+Kidbjhwo7F/yr+CSEExP2Ajuij6e0e4PqCbA5oTSvpIx0/KkmkVF9SzgRvhAh6 e5Y1vv8/D2GrTlfUAKie6xvQtOO7Ii0WxBFHTE9Azu3CkT3NogPLO5Sjb0nJ8+Rx3cOz 4+TmCkeYxUMiHpT96yrKfMEmoa5qoFcgydv5uaK5E3WYwsEHbBS//yc5WbcAeNhvs9w7 6ycA== X-Gm-Message-State: ACrzQf0MWenrcrNVv8el4rgcUlcx58tYI8g9InPsTbRj7U7kjm0EuoFx UYQ8nYuYiMZCLVF6a7Jdqw== X-Google-Smtp-Source: AMsMyM7fNS7fCUE8nEqacvdkW1wr5/+kQrklLGOYoO4TKyWPl5HmOInIjZOsek2fd6tLXWvZGAASlQ== X-Received: by 2002:a17:906:5a6a:b0:7a6:bad5:8295 with SMTP id my42-20020a1709065a6a00b007a6bad58295mr11961592ejc.647.1666724534017; Tue, 25 Oct 2022 12:02:14 -0700 (PDT) Received: from p183 ([46.53.248.70]) by smtp.gmail.com with ESMTPSA id s5-20020a056402036500b004623028c594sm1031397edw.49.2022.10.25.12.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 12:02:13 -0700 (PDT) Date: Tue, 25 Oct 2022 22:02:11 +0300 From: Alexey Dobriyan To: Li Zetao Cc: viro@zeniv.linux.org.uk, ebiederm@xmission.com, keescook@chromium.org, akpm@linux-foundation.org, yi.zhang@huawei.com, chengzhihao1@huawei.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/binfmt_elf: Fix memory leak in load_elf_binary() Message-ID: References: <20221024154421.982230-1-lizetao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221024154421.982230-1-lizetao1@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666724535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wdQpMJv+fAAdPj7JhNoObv56I8k+ulFEDb11lC7AivY=; b=xEhapSpu4xRf2aElC3Z5pJuwV1QTLJeXELMIbtPLKXORATjXyOfWFSNNO/2DU/5LWTnCcl i7Jii6LemWbjWKvFQCRlXg+25QJLY+lXb4YTEJfb3NKwEquzOTyY+aeyfixTuUXXvGV7CL g/sIsnWYtIAWtHPE0iwAixOn/UiTgRI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lJlZT5zb; spf=pass (imf09.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666724535; a=rsa-sha256; cv=none; b=oVriaojHNzsz296/WaKvj4CZRtyLaoPl+uK/4gSaahfoh/TivCWaerfQu1lPqryfgKIhQA Ki1FFgexOFWP1+M5RMnMqDQIEutsBLZv1ti52asoUGOGfdFT1aOcCJ88kMrQNBNlEZ+tKT pRUcAPVqMJVvcnnvsP/NCgmzA2YA/0c= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7F12C140036 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lJlZT5zb; spf=pass (imf09.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: bzbs6rephhz1rb63ynajgin1chhakkag X-HE-Tag: 1666724535-14079 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 11:44:21PM +0800, Li Zetao wrote: > If "interp_elf_ex" fails to allocate memory in load_elf_binary(), > the program will take the "out_free_ph" error handing path, > resulting in "interpreter" file resource is not released. Yes :-( > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -911,7 +911,7 @@ static int load_elf_binary(struct linux_binprm *bprm) > interp_elf_ex = kmalloc(sizeof(*interp_elf_ex), GFP_KERNEL); > if (!interp_elf_ex) { > retval = -ENOMEM; > - goto out_free_ph; > + goto out_free_file; Reviewed-by: Alexey Dobriyan