From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C39CC04A95 for ; Tue, 25 Oct 2022 15:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9B788E0002; Tue, 25 Oct 2022 11:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4BF78E0001; Tue, 25 Oct 2022 11:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A14BA8E0002; Tue, 25 Oct 2022 11:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 92EDA8E0001 for ; Tue, 25 Oct 2022 11:44:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 45324140E1D for ; Tue, 25 Oct 2022 15:44:56 +0000 (UTC) X-FDA: 80059894992.29.AA97B77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id C837E4001C for ; Tue, 25 Oct 2022 15:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666712695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QfBxSc/Q/Rl1HQ7uZjJdrWCzL0Cr32j4KHcNRwl17rE=; b=gZXhId0ZaDgEOlKpeq6sht6DXWLm2Tvtmj6jgNaKD+HCXwnnSPGpdnCQ47YUttGtGUBk4C E1Gg8gg+8j5KA2Mj7q2xBY3ckjnLGf2ggkHKhh8hV2C1gsUGZ3e68rm1D6LNNlHHZ5BKV8 O5vnYVd/iILfGiyi5ny3q2BnptWfsmk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-578-aT06aI9RPFSPjwGQMVzUpg-1; Tue, 25 Oct 2022 11:44:44 -0400 X-MC-Unique: aT06aI9RPFSPjwGQMVzUpg-1 Received: by mail-qv1-f71.google.com with SMTP id ln3-20020a0562145a8300b004b8c29a7d50so7261204qvb.15 for ; Tue, 25 Oct 2022 08:44:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QfBxSc/Q/Rl1HQ7uZjJdrWCzL0Cr32j4KHcNRwl17rE=; b=qAxISbGn+AyXJOk0BncZAzgdGEapTPCD2kjcZAcg2/64TwJNl8aGoeVQ/+aqAG6lYC WmpLtkl6fCCZi2Ii75tP/NGSxkQ4/qeyNkK04ovzZmpaqOcd9Lvw8Q8wrWdTzZnMPQnS ITt6BQXLwmMKcRnhvnNP8Zo0/iThHGTwprX5O5o+JGXa5p/2s6AXkAhyhhV7ovT37DBs llunvoHgVOm0HsVuK3yrhoVCcS4zPIDc9CapmwKL8DdP3qUtr85SHMP7TFWG9yg9QwR8 dZp8EcOKvlbO0CbjYoV4yds1Q/BDumRyav8RZUowxT7+TCiF+8jL2xs+79f7d8DYRVZa eWnA== X-Gm-Message-State: ACrzQf2Bdbh/GLWcfiv5y42D56AiTQQsnqYBp+nXyT7iuxkyaQwwiFax ZEvg629Ttnjo8pV5cEH4mPb6z2jh8iNxwynONYloMB7JsKBAb6cmT454ZpuC98eHtZ0JWzHBhw4 QeoVy4QGiB0E= X-Received: by 2002:ac8:5f89:0:b0:39c:e5a2:6db9 with SMTP id j9-20020ac85f89000000b0039ce5a26db9mr31619742qta.138.1666712684051; Tue, 25 Oct 2022 08:44:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM42N6ywBWBizXln5NRrhisEsi7LnXik9WLoAdJztzrqoMBMafUeCmrqJ3IWYkRC7rvbzueHRQ== X-Received: by 2002:ac8:5f89:0:b0:39c:e5a2:6db9 with SMTP id j9-20020ac85f89000000b0039ce5a26db9mr31619731qta.138.1666712683848; Tue, 25 Oct 2022 08:44:43 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id s14-20020a05620a254e00b006cf8fc6e922sm2234747qko.119.2022.10.25.08.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 08:44:43 -0700 (PDT) Date: Tue, 25 Oct 2022 11:44:42 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Huang Ying , Andrew Morton , HORIGUCHI NAOYA , Miaohe Lin , Andrea Arcangeli Subject: Re: [PATCH RFC 2/2] mm: Use pte markers for swap errors Message-ID: References: <20221024204830.1342169-1-peterx@redhat.com> <20221024204830.1342169-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gZXhId0Z; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666712695; a=rsa-sha256; cv=none; b=xTLgYZqGONV3UkWKdvWZN/R9bi6Bh9Uvps2yJBt8E2nuAxhB6xAZ7aIF2xOvI52oJbtZRu gP0b4TlLIOdErYEKUgDPSdrxegIcswX7vkoRb9/v3Js0iIAQ4YEco9ye/c4crTu3Baai5b maY3S9Vtstb01FvWvi6dKxbt04w8OkQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666712695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QfBxSc/Q/Rl1HQ7uZjJdrWCzL0Cr32j4KHcNRwl17rE=; b=n92bwL8aGvMID5MBCugAZ1auHmJbStb8HPtkZSpnKwtA+cL76Ujl5Sh49u4qYHJ8c/RqmX pG6JmYMAKHJawyDIiCwmJVPgXl1e8cvYjqRKLzvWjJplZHFs6PPrmVR/4ajwmX9J/q8K35 LZAOF0s9MlCUCeJZQXBw4LXtNJMXhIw= X-Rspamd-Queue-Id: C837E4001C Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gZXhId0Z; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: ccsmf5yxicfxc9b1ddh7icbtsfhzngy1 X-HE-Tag: 1666712695-16048 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 05:31:43PM +0200, David Hildenbrand wrote: > > -#define PTE_MARKER_UFFD_WP BIT(0) > > -#define PTE_MARKER_MASK (PTE_MARKER_UFFD_WP) > > +#define PTE_MARKER_UFFD_WP BIT(0) > > +#define PTE_MARKER_SWAP_ERROR BIT(1) > > I'd suggest to keep the term SWAPIN. An error happened during swapin, which > is why the page is corrupted. Sure thing. -- Peter Xu