From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035D4C04A95 for ; Tue, 25 Oct 2022 14:43:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 895A58E0003; Tue, 25 Oct 2022 10:43:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 846488E0001; Tue, 25 Oct 2022 10:43:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EA728E0003; Tue, 25 Oct 2022 10:43:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5FF248E0001 for ; Tue, 25 Oct 2022 10:43:51 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 39610160CF8 for ; Tue, 25 Oct 2022 14:43:51 +0000 (UTC) X-FDA: 80059741062.14.DD521C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B3D251C0004 for ; Tue, 25 Oct 2022 14:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666709030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pxb6hLNBaPYX709qS8Dsh8K7Uk4NY/7ppFr76EjMPTQ=; b=SoUpCAqjvIGdBvmp6otMCdCXcO1tZ77BWNu2d39ZqBxb+AuDY7PHLG/3QtXZ4W0ClWRAkd Fw7DimUbzbO9J4Xtpskejvo/OVKznC/Ig/lUx+/UaGQxviNkyFgF86r4K4vXc1gFsTsK2n mjRwdtkdHRa8qt4feQAm+e5gAru254o= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-547-DfDp0twlPlKnFanYBq8ZSA-1; Tue, 25 Oct 2022 10:43:48 -0400 X-MC-Unique: DfDp0twlPlKnFanYBq8ZSA-1 Received: by mail-qv1-f69.google.com with SMTP id q16-20020a0ce210000000b004ba8976d3aaso6819938qvl.5 for ; Tue, 25 Oct 2022 07:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pxb6hLNBaPYX709qS8Dsh8K7Uk4NY/7ppFr76EjMPTQ=; b=n1Bo2phFEJK6CGJgvu6IjuhiHZzIsGip15RnywgsA4iVXhVxmaQ2O9hoLwkmB8LL+4 089uDbQt7RPGcjyKv/721LwYKGD5Dz0me5sVVB5PxoGwRg8YwXscpSXTV7y0zrV79puh E5Jp0OVE/R5RsubhonIEXobSw4Ti+RqAfyez7uwoARAqBTvsWhR346htK6XyB79TidDY X20FY7eNzB/xWxcnoqEoNHk+jdpT463Oyxybd5XIfCZVViQCZrkvprcS/mdGgY29lTTs SDrYdgDh6TpRAFZOHYHhqiAFiFV0DIyQcE0WnQZsQho4pA+zfz1TBbqBcY14KW/ca+c2 1Hog== X-Gm-Message-State: ACrzQf2J3ABuRDhUGL9gCVOo5H/cyoaA8FFb4v3UVTBsxz5TYKld404X h9U1YHJET8Yuj1FURzSL8lxJdsXq05LjVvAOegEjBjIlT/Zx3FTI61hQ/en3lA+0FtlTw65aPCi X0WUvxGXMXhk= X-Received: by 2002:ac8:5fc5:0:b0:39c:bb48:e42f with SMTP id k5-20020ac85fc5000000b0039cbb48e42fmr31816271qta.586.1666709028241; Tue, 25 Oct 2022 07:43:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7GfOvBIe3eVSO7BOHXT4+eelhHEZ0ULsG5cnoD9Qz3T3NoGoqp3jXdbO0dGqNFN3eQPDey7A== X-Received: by 2002:ac8:5fc5:0:b0:39c:bb48:e42f with SMTP id k5-20020ac85fc5000000b0039cbb48e42fmr31816250qta.586.1666709027994; Tue, 25 Oct 2022 07:43:47 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id h10-20020a05620a400a00b006f8665f483fsm396408qko.85.2022.10.25.07.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 07:43:47 -0700 (PDT) Date: Tue, 25 Oct 2022 10:43:45 -0400 From: Peter Xu To: Anatoly Pugachev Cc: David Miller , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , "Kirill A . Shutemov" , Alistair Popple , Andrea Arcangeli , Minchan Kim , Andrew Morton , David Hildenbrand , Andi Kleen , Nadav Amit , Huang Ying , Vlastimil Babka , sparclinux@vger.kernel.org Subject: Re: dpkg fails on sparc64 (was: [PATCH v4 4/7] mm/thp: Carry over dirty bit when thp splits on pmd) Message-ID: References: <20220811161331.37055-1-peterx@redhat.com> <20220811161331.37055-5-peterx@redhat.com> <20221021160603.GA23307@u164.east.ru> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666709030; a=rsa-sha256; cv=none; b=KjrGFAerDUFFvsfEicTXziS27Nn8QnkZyTdvUs1Kvwr+amL9gH/h738duh0HAtl2keRs07 fC5EOcXChPfVFLaR7dQ7ZtjKtXHh4g7eJTYM2Y5FnAUABPY45B52mAFSyVue3xI22RmtBL hzp1+OdsMKQ9yGGHFbAEM9zmRlQDOLc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SoUpCAqj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666709030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxb6hLNBaPYX709qS8Dsh8K7Uk4NY/7ppFr76EjMPTQ=; b=dYweZ1E9UF98J9RfeHaS8yAJfj60GkeDuwWCb0UduHUWNskVmTI9G3Io9SnvgC/TZ2Dyem iOtJJKiviNiqWzWjiXwwndU21V/Dul8wOzTv7dD5s7N3C3dC6rpa3QCBLMSMN8Q+TolpeB SBAvh8uhdfSzCnjjZK9m8dwe6gzwg7o= X-Stat-Signature: ha75jkr54nzx8jnwgtfmz8fiu7owmkkx X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B3D251C0004 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SoUpCAqj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1666709030-829064 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 01:22:45PM +0300, Anatoly Pugachev wrote: > On Sun, Oct 23, 2022 at 10:53 PM Peter Xu wrote: > > On Fri, Oct 21, 2022 at 07:06:03PM +0300, Anatoly Pugachev wrote: > > > > > > Link: https://lkml.kernel.org/r/20220811161331.37055-5-peterx@redhat.com > > > > > > So, v6.0-rc3-176-g0d206b5d2e0d) does not segfault dpkg, > > > v6.0-rc3-177-g0ccf7f168e17 segfaults it on package install. > > > > > > dpkg test was (apt) install/remove some packages, segfaults only on install > > > (not remove). > > > > > > Reverted 0ccf7f168e17bb7eb5a322397ba5a841f4fbaccb from top of v6.1-rc1 and > > > tried to compile kernel, but got error > > > > > > mm/huge_memory.c: In function ‘__split_huge_pmd_locked’: > > > mm/huge_memory.c:2129:17: error: ‘dirty’ undeclared (first use in this function) > > > 2129 | dirty = is_migration_entry_dirty(entry); > > > | ^~~~~ > > > mm/huge_memory.c:2129:17: note: each undeclared identifier is reported only once for each function it appears in > > > make[2]: *** [scripts/Makefile.build:250: mm/huge_memory.o] Error 1 > > > > > > So can't test v6.1-rc1 with patch reverted... > > > > Sorry to know this, and thanks for the report and debugging. The revert > > won't work because dirty variable is used in later patch for the swap path > > too. I've attached a partial (and minimum) revert, feel free to try. > > Peter, > > tested again with 6.1.0-rc2 already, non patched kernel segfaulting > dpkg, using your patch makes dpkg > (or kernel) to behave properly. > Thanks! Thanks for the quick feedback. > > > I had a feeling that it's somehow related to the special impl of sparc64 > > pte_mkdirty() where a kernel patching mechanism is used to share code > > between sun4[uv]. I'd assume your machine is sun4v? As that's the one > > that needs the patching, iiuc. > > kernel boot log reports > ARCH: SUN4V Then it's expected but unfortunate too, as QEMU doesn't seem to have support on sun4v so I cannot even try that out with a VM. https://wiki.qemu.org/Documentation/Platforms/SPARC I'd also expect there's nothing useful in either dmesg or relevant logs because it's segv, but please share if you find anything that may be helpful. Maybe we need to have the minimum revert for v6.1 before we have more clues. Thanks, -- Peter Xu