From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/6] zsmalloc/zram: configurable zspage size
Date: Tue, 25 Oct 2022 10:26:01 +0700 [thread overview]
Message-ID: <Y1dXSeqwX/WfUcjt@debian.me> (raw)
In-Reply-To: <20221024161213.3221725-1-senozhatsky@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]
On Tue, Oct 25, 2022 at 01:12:07AM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> Some use-cases and/or data patterns may benefit from
> larger zspages. Currently the limit on the number of physical
> pages that are linked into a zspage is hardcoded to 4. Higher
> limit changes key characteristics of a number of the size
> clases, improving compactness of the pool and redusing the
> amount of memory zsmalloc pool uses.
>
> For instance, the huge size class watermark is currently set
> to 3264 bytes. With order 3 zspages we have more normal classe
> and huge size watermark becomes 3632. With order 4 zspages
> huge size watermark becomes 3840.
>
> Commit #1 has more numbers and some analysis.
>
> Sergey Senozhatsky (6):
> zsmalloc: turn zspage order into runtime variable
> zsmalloc/zram: pass zspage order to zs_create_pool()
> zram: add pool_page_order device attribute
> Documentation: document zram pool_page_order attribute
> zsmalloc: break out of loop when found perfect zspage order
> zsmalloc: make sure we select best zspage size
>
> Documentation/admin-guide/blockdev/zram.rst | 31 +++++--
> drivers/block/zram/zram_drv.c | 44 ++++++++-
> drivers/block/zram/zram_drv.h | 2 +
> include/linux/zsmalloc.h | 15 +++-
> mm/zsmalloc.c | 98 +++++++++++++--------
> 5 files changed, 145 insertions(+), 45 deletions(-)
>
Sorry, I can't cleanly apply this patch series due to conflicts in
patch [1/6]. On what tree and commit the series is based?
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-10-25 3:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:12 Sergey Senozhatsky
2022-10-24 16:12 ` [PATCH 1/6] zsmalloc: turn zspage order into runtime variable Sergey Senozhatsky
2022-10-24 16:12 ` [PATCH 2/6] zsmalloc/zram: pass zspage order to zs_create_pool() Sergey Senozhatsky
2022-10-24 16:12 ` [PATCH 3/6] zram: add pool_page_order device attribute Sergey Senozhatsky
2022-10-24 16:12 ` [PATCH 4/6] Documentation: document zram pool_page_order attribute Sergey Senozhatsky
2022-10-24 16:12 ` [PATCH 5/6] zsmalloc: break out of loop when found perfect zspage order Sergey Senozhatsky
2022-10-24 16:12 ` [PATCH 6/6] zsmalloc: make sure we select best zspage size Sergey Senozhatsky
2022-10-25 3:26 ` Bagas Sanjaya [this message]
2022-10-25 3:42 ` [PATCH 0/6] zsmalloc/zram: configurable " Sergey Senozhatsky
2022-10-25 8:40 ` Bagas Sanjaya
2022-10-25 4:30 ` Sergey Senozhatsky
2022-10-25 7:57 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1dXSeqwX/WfUcjt@debian.me \
--to=bagasdotme@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox