From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A08C38A2D for ; Tue, 25 Oct 2022 00:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C56B80008; Mon, 24 Oct 2022 20:18:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7751D80007; Mon, 24 Oct 2022 20:18:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D6780008; Mon, 24 Oct 2022 20:18:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 50E7A80007 for ; Mon, 24 Oct 2022 20:18:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 368FDA022A for ; Tue, 25 Oct 2022 00:18:36 +0000 (UTC) X-FDA: 80057560632.25.82DF5B1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id C62BF140012 for ; Tue, 25 Oct 2022 00:18:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E22996160B; Tue, 25 Oct 2022 00:18:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF8EC433C1; Tue, 25 Oct 2022 00:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666657114; bh=AYNdIGacxRsDkqocIdm5GNxDukzwT3N86R37lmpGthw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OxqbxjdKpmB3+CnDOp3iJ8sY6QEbf1qioxINM48yPl/uWugtareVrEJRYbz5C97QR 9gP53yqhwnT86+tbO0pgLXO0Pgi9CuqybZhi8BAlWwhpaDFn7LDerwJ1nLMBnw+zXM AT1eH7Z75b7XscisWDWQ7GD/AovVDsTUX17wWsw//vXAOWBYMiDRpvoOtGbYcr4mcK oaQBY/VA15XfiP3eXgQv8hEnaqjxVU3SN1I2tmIJmGn5A4IjmC6gZWbUVpXPtEsnD5 hFeW3PymY4RSQvOLgxoH1FVEKKe9yQ5nwfIGOsuy07/WNQmF3mldkqAbBZaS2r7jz8 7nXeUFgMLiIDw== Date: Mon, 24 Oct 2022 17:18:33 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: xfs , Shiyang Ruan , Andrew Morton , Linux Memory Management List Subject: Re: [PATCH] xfs: fix incorrect return type for fsdax fault handlers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666657115; a=rsa-sha256; cv=none; b=vZ6djnguQMH9HXY7dkyEOt5IuGruoJCG1gTzFcwuSUlWeChVhTS8+/M/GnK4PlWrC52Pp5 C64xCtI9vCtnY5YB3f8CmgAViZIebgslS0YpAKpWuv46zhUbGykZLtDO6EUJgZ2jNiLyZu pmZ2KpsNkkB3AIkWLtdUjcSYZ+rLDa0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OxqbxjdK; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666657115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2WyOuV/d8Icr1oJQc8r7CdiVQVxohzEHdWgqSDclvC0=; b=D/IrURyL9GukUcJeNzVvtsokkmZgPh20FyztStTIZ1SGziduBKeH/dVTF4yYELeO5ssUrT vPcTufYr4cHoV2mRgYvP3OgvGQHdhElP802tDCuvw4qz7Y5TCgVXiMh4SeQc3HYCvShAjH KIEb20IC8Px6KLK8WkBTR6u4oIyyruY= X-Stat-Signature: 4qs1nxb83swb9p7iw8pfzrfo53gx8nwk X-Rspamd-Queue-Id: C62BF140012 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OxqbxjdK; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666657115-637744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 10:56:48PM +0100, Matthew Wilcox wrote: > On Mon, Oct 24, 2022 at 02:32:18PM -0700, Darrick J. Wong wrote: > > Fix the incorrect return type for these two functions, and make the > > !fsdax version return SIGBUS since there is no vm_fault_t that maps to > > zero. > > Hmm? You should be able to return 0 without sparse complaining. Yes I know, but is that the correct return value for "someone is calling the wrong function, everything is fubar, please stop the world now"? --D