From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9263EC38A2D for ; Mon, 24 Oct 2022 23:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E07AD80008; Mon, 24 Oct 2022 19:22:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB80180007; Mon, 24 Oct 2022 19:22:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6D880008; Mon, 24 Oct 2022 19:22:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BC0EA80007 for ; Mon, 24 Oct 2022 19:22:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 94C5F16034F for ; Mon, 24 Oct 2022 23:22:56 +0000 (UTC) X-FDA: 80057420352.03.426FEA9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 125B0140036 for ; Mon, 24 Oct 2022 23:22:55 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C0FC614CF; Mon, 24 Oct 2022 23:22:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A877C433B5; Mon, 24 Oct 2022 23:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666653774; bh=FwAE6oKpyntTkSzv1E3KQuVNYUeqmWq1Gpucgi/lq70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C2rqczwfPcMBbfjB0dsagHifmvhSIx/eJsGs8w1RTgDcEm39rDFdFKfuhKOf1HJ2d +zk8l7VfNdUVICTq4HRQDbPu5UETZCsS4AoLgIPmJ8Tzu7llzwnB28I2krH457Gnsk PBwq1XUGMhZNLOkYoHzBKVH6KhCTUM3cSFRAO3BLsE2R4WGdQp308lsFhEVKWRpObv OuKBmCU6adguZTjaekp839K36KR+bJ1hWuIcJBGKsYCJLCiYku8NYvk0f2k+UzMCih 03Bctq6RxgZfu40XlW1dp4dosO5HxFSWOmeMuDSpOCPPEFapb7UlLD4Zo/NbgsBlS1 j0PBLGmmjG3yw== Date: Mon, 24 Oct 2022 16:22:53 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: xfs , Shiyang Ruan , Andrew Morton , Linux Memory Management List Subject: Re: [PATCH] xfs: fix incorrect return type for fsdax fault handlers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666653776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2txhr9fh47i9KHwOKnhtjsf7P9NQoU9FDpG3zVe2Q/U=; b=pDvKcX9/7LI+BcOZmDSwwqZkd3P2ks0iCwZpP8ntRzRnoYLgGWt7XC58Kx7kNPLcWoqUAK lmEG04CcEg5mrWtfa2x51v9ql3h4PoZduaR+FeiJf0as452BuB+90ZJPAk+OfPL8fSZkmZ YAZ1v++fnqTvp0dGWeqP7dcTdsQ7vAM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C2rqczwf; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666653776; a=rsa-sha256; cv=none; b=Yh1u0RvgW/xfflwlaDboJkzcq3bXJrzm2OVtPjDOEz5R8wFjxKZOnswdb/Ir+266x2eN7R SACuuNBLV5KD88sRbZghO93bCRtyR/ddIQnP1QHAqLXmPqzUKP6+NK5w0PSFQjMRksCGJ8 FGmiTxS67SUTGKNIHHBmC2DajlV9BCg= X-Rspamd-Queue-Id: 125B0140036 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C2rqczwf; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: uhpzw1wio5qgu7emg7mj5e54jhmayhp5 X-HE-Tag: 1666653775-988098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 10:56:48PM +0100, Matthew Wilcox wrote: > On Mon, Oct 24, 2022 at 02:32:18PM -0700, Darrick J. Wong wrote: > > Fix the incorrect return type for these two functions, and make the > > !fsdax version return SIGBUS since there is no vm_fault_t that maps to > > zero. > > Hmm? You should be able to return 0 without sparse complaining. What does (vm_fault_t)0 do? And why wouldn't we want to induce a segfault if someone calls the fsdax fault function when fsdax isn't supported? --D