From: "Darrick J. Wong" <djwong@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: xfs <linux-xfs@vger.kernel.org>,
Shiyang Ruan <ruansy.fnst@fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] xfs: fix incorrect return type for fsdax fault handlers
Date: Mon, 24 Oct 2022 16:22:53 -0700 [thread overview]
Message-ID: <Y1ceTY4clIYOsRqA@magnolia> (raw)
In-Reply-To: <Y1cKIEmT2R9INlDT@casper.infradead.org>
On Mon, Oct 24, 2022 at 10:56:48PM +0100, Matthew Wilcox wrote:
> On Mon, Oct 24, 2022 at 02:32:18PM -0700, Darrick J. Wong wrote:
> > Fix the incorrect return type for these two functions, and make the
> > !fsdax version return SIGBUS since there is no vm_fault_t that maps to
> > zero.
>
> Hmm? You should be able to return 0 without sparse complaining.
What does (vm_fault_t)0 do? And why wouldn't we want to induce a
segfault if someone calls the fsdax fault function when fsdax isn't
supported?
--D
next prev parent reply other threads:[~2022-10-24 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 21:32 Darrick J. Wong
2022-10-24 21:56 ` Matthew Wilcox
2022-10-24 23:22 ` Darrick J. Wong [this message]
2022-10-25 0:18 ` Darrick J. Wong
2022-10-25 18:02 ` Matthew Wilcox
2022-10-25 22:30 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1ceTY4clIYOsRqA@magnolia \
--to=djwong@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox