From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33D6C38A2D for ; Mon, 24 Oct 2022 21:57:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6803F940008; Mon, 24 Oct 2022 17:57:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63080940007; Mon, 24 Oct 2022 17:57:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51FD9940008; Mon, 24 Oct 2022 17:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 46065940007 for ; Mon, 24 Oct 2022 17:57:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 04669A87F5 for ; Mon, 24 Oct 2022 21:57:00 +0000 (UTC) X-FDA: 80057203842.25.7E78A5A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 3803814000E for ; Mon, 24 Oct 2022 21:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w7/GdyrirYqDY2yNiE1oq5a88QHllQcaNdsPM4o9pt0=; b=LNVo02OjR4qfust6qwn6n57m1D FI8O6x93heJfA520X/L/qXt9M+cxXr7e3sCxkr56AfpfLLl1W/PrLE8SFAqyUeVjKlyam81+2Pr+6 peDNUSrxW4k2N/8c6yE7U4jcjxMjpBwBH0kw1LZ5HJ9NNgIAL56jf7si4OGHeFr8I+PXpwbv9VNvr AhtGFq4vkU+8Pot+nBiobBsFPPr5l7Y5KYn9uKSwfXaVVMc+deLQLZS1lAZhy/HmbSmc2rQhRhtE5 oAsmNMbYggmGc/ww8TgiAT1T6BgvN/W9A6PkzP9u3MCwqg68fl8TdgvymQqI23nMsGNHxFNU7Aio+ hhEayM/w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1on5RA-00FmMc-Fy; Mon, 24 Oct 2022 21:56:48 +0000 Date: Mon, 24 Oct 2022 22:56:48 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: xfs , Shiyang Ruan , Andrew Morton , Linux Memory Management List Subject: Re: [PATCH] xfs: fix incorrect return type for fsdax fault handlers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666648620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w7/GdyrirYqDY2yNiE1oq5a88QHllQcaNdsPM4o9pt0=; b=s9Xr1POQkJxr3lQ1TXlit1M3+aVNizpqSBGc89NN7KsmZCM4RnLbP0jwmBQQE8ofwgtemz PS0O531vWBO0q4Xc/evuPX+oM24U45OC9qsF0y1P6xi1mIQH4wQKEIv38uF/QpVB/q4Py0 BF1Cxy7LwZtWizN7Gl9N0oypiSCyLHk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LNVo02Oj; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666648620; a=rsa-sha256; cv=none; b=jL6Kbw9t0cUxL1JaDYXxH5c0ERVT/I+dku1k6RqjDU2VaZ7T+r6K7ecwhSu3zVEUfUfMnS zmy+xeIKC5Pj0hYkspfWUGbRPnfv+zHRgNC589F4sdov8Y7O740TuYAdYliVakw+uv1Alo hkMiIJj3q1arFjDJ3dH9SOZ/Pn338Q0= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3803814000E X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LNVo02Oj; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 3qoxj6r1zj8egiy9ewk6ym87kxps11sa X-HE-Tag: 1666648619-205903 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 02:32:18PM -0700, Darrick J. Wong wrote: > Fix the incorrect return type for these two functions, and make the > !fsdax version return SIGBUS since there is no vm_fault_t that maps to > zero. Hmm? You should be able to return 0 without sparse complaining.