From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77681ECAAA1 for ; Mon, 24 Oct 2022 17:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0C2B940008; Mon, 24 Oct 2022 13:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBC27940007; Mon, 24 Oct 2022 13:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D843E940008; Mon, 24 Oct 2022 13:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C5C7E940007 for ; Mon, 24 Oct 2022 13:38:36 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D9C6A099A for ; Mon, 24 Oct 2022 17:38:36 +0000 (UTC) X-FDA: 80056552632.08.B10308D Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E97340023 for ; Mon, 24 Oct 2022 17:38:36 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id 3-20020a17090a0f8300b00212d5cd4e5eso7962604pjz.4 for ; Mon, 24 Oct 2022 10:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0SvrvFQbZJt7iDWYQmvN7U67sbT18oYJVK+RPEPBAvQ=; b=lBfQbxfMjOYjjVVAu8Vi6VTVn3QT2ScttZTJRCZEyujkbH41Lr59JYJaEDwAm7pt1t xQHy3VUPrWmEbVZjCCVcjLgWGySPQaYJCHJPZXXfB9WICSairI3xhRn6w5RneS6fcuWs /191zHzVa7wDwYUhDCFcjM4GRScANHBAO79dOIy3ApqLWhQi9/XrD8zFjQ59v/P+xNX+ xCDcOvsK2t9vrJTU/hZ2WISRGkQOiie6exyOzS2FB51a0dRO79nJx/fuTr3i97V6HY7g OB9U2D97jOpYl0v4LoveN4mkBtLxqpTOwov+hYOErIJUGhPpMGlWmHvoU50PvC7DibgP 4LwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0SvrvFQbZJt7iDWYQmvN7U67sbT18oYJVK+RPEPBAvQ=; b=19E8HY7p/PI4LZFUFUaYJGVZt/G86NdMLB9ddumyl8fStxY0tZb8NxjleSSYcOvQ+1 gvErNAmu1hpaVb3ukehLU7xBEwWEezgLUow8LDmZCBMIm+9PggfVAq+SxWgo+aPoqqbK 2Eo1+fnxu9IG1LgO//BgMUQpjIfCYs9UHO9PZjqcA5XsZTE/G2kCV6psrK9bPerZ1Dk0 NeD0Ey0M9c8tdLMkP7c2qhJZM8njjbSJVXKXfFSHrCi/Erux5HmJf8JZdEdA+wQZpm/p CjicrjHQzZgjg12hoEruIBECoJlAQmNsrlOI/YhPSkSdLKk/la9n2LtTTGdBOJfrYSNR RKTw== X-Gm-Message-State: ACrzQf0TRG7/OojciJ/aFJhMO+dyMrbbnm8hhNV//6CBf2AEJB9SiB2n fa3Ab7Lju458xXLkQeifTEc= X-Google-Smtp-Source: AMsMyM4ul+peWSJ5kBk/E8QtIu9ueJjvVDpG7haldk/47PgjDGdFhd9fWLyOZSUan3A6isvrAKnaMA== X-Received: by 2002:a17:90b:3e82:b0:20d:2fa1:d071 with SMTP id rj2-20020a17090b3e8200b0020d2fa1d071mr75370882pjb.58.1666633115028; Mon, 24 Oct 2022 10:38:35 -0700 (PDT) Received: from biggie ([103.230.148.187]) by smtp.gmail.com with ESMTPSA id t18-20020aa79472000000b0056bf5e54961sm72858pfq.161.2022.10.24.10.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 10:38:34 -0700 (PDT) Date: Mon, 24 Oct 2022 23:08:28 +0530 From: Gautam Menghani To: Zach O'Keefe Cc: Steven Rostedt , akpm@linux-foundation.org, mhiramat@kernel.org, shy828301@gmail.com, vbabka@suse.cz, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/khugepaged: add tracepoint to collapse_file() Message-ID: References: <20221024150922.129814-1-gautammenghani201@gmail.com> <20221024111621.3ba17e2c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666633116; a=rsa-sha256; cv=none; b=GyMuFspdKbAZXZBWz+9UVZeRX/YPrAOxSyPuGFAhBrdKpAcBL0W5MckoGawge4Nsvw3BrH nbHwaauhxgezRIpriSnpeUY/UWS78q+tF7Wv6L7cQIKQWDcCKf9LBqbh87lEXn10L2enlY 7Zj0mlIacFbpMW53zrQApKZTWzBUEZk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lBfQbxfM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of gautammenghani201@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=gautammenghani201@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666633116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0SvrvFQbZJt7iDWYQmvN7U67sbT18oYJVK+RPEPBAvQ=; b=cpxB0abLljGWxmgylN53ErLxt2wIlZhAM1of5X9xAUS2M5ZrD22554SeHZZQ05ZebsqdRs uTuOWf+H73OulfaAeq+jOfZYxX8jYt6lowvGxd78jMhaKa1I1n6cxQq2JVMX925WW6qFJ+ o/8VzKfb4+2yhO0LAyrH0GuzMn4IyCU= X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lBfQbxfM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of gautammenghani201@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=gautammenghani201@gmail.com X-Rspamd-Server: rspam11 X-Stat-Signature: gxxkpy6p9ej7a74txds3w8n7jfijobgw X-Rspamd-Queue-Id: 3E97340023 X-HE-Tag: 1666633116-616773 X-Bogosity: Ham, tests=bogofilter, spamicity=0.008488, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 09:44:16AM -0700, Zach O'Keefe wrote: > Thanks for your mail, Gautam. > > > I try to keep dereferences out of the calling path as much as possible > > (adds to I$ at the call site). > > This was probably due to the way I handled > trace_mm_khugepaged_scan_file(). Perhaps that can be cleaned up at the > same time as this patch, for consistency. > Yes sure I'll send a patch for cleaning this up. > Also, no qualms about adding this tracepoint; there are a few scan > result codes that overlap between hpage_collapse_scan_file() and those > possibly returned in collapse_file() such that, if we only have the > one tracepoint in hpage_collapse_scan_file(), it could be ambiguous > what callsite the error path stemmed from. Luckily this hasn't been an > issue thus far. > > Lastly, a few other items we might care about capturing: > > - is_shmem (perhaps the filename is enough to know this - but I know > at least once during development I was caught off-guard b/c a mount I > thought to be file-backed turned out to be tmpfs (and something I > didn't think to question until I had wasted some time on other > paths)). > - index Yes noted.