From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B7AECAAA1 for ; Mon, 24 Oct 2022 17:09:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A18F7940008; Mon, 24 Oct 2022 13:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A164940007; Mon, 24 Oct 2022 13:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86924940008; Mon, 24 Oct 2022 13:09:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 739A3940007 for ; Mon, 24 Oct 2022 13:09:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2D8131C6684 for ; Mon, 24 Oct 2022 17:09:52 +0000 (UTC) X-FDA: 80056480224.17.596C53A Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf28.hostedemail.com (Postfix) with ESMTP id B8203C0024 for ; Mon, 24 Oct 2022 17:09:51 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id b5so9180212pgb.6 for ; Mon, 24 Oct 2022 10:09:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gz6IbE5QNnnx6hJZ/M0UjY5y91KtBmJ2N2+vRHclsWk=; b=1xDD5Da4wdWCUSPgdC/OX+S16WaIYS65J6sUyFvwaUpbWNF40mAOqJ9LT6ON1078EW 740VJQdX3PvP8UFhuUxIjYSKVihOjzoV1o/VpqUCsL4eWpRQ41EweHtWSOIm092Kwi73 2mhzLxI1+iVXmgybo61MLuZml06n3/0d2qi4dvdb8b2Dead5PbBmIqo16wb5LLL0O5z/ MRDl+qwqhW/lG9w60U2HEZqlXH6/CTtMowukJQz+pHWIx41Z8L5jP8ZBbUhgtm620yoz 13l7AO0vH5B64Kw7+l4ClPP/olTTLcg46kgKEwZlN5qfPCH1DKwSO6SFehtr/yTiEDHr y8jQ== X-Gm-Message-State: ACrzQf0C3ezBAyZ6tSYenEZ208knUrO7SK4/+jHXamkLkt44ZHfmejSI l1x3QhAVN19kAs/OP9ngPPv7iM73hw4= X-Google-Smtp-Source: AMsMyM6+WSzSlEp+quC0KcmnxizQlZQIWdYnzAzRiVq53wrWRx03JpIdIaymZqYO8E/TtoMFvpImfA== X-Received: by 2002:a05:6a00:1687:b0:565:a932:f05a with SMTP id k7-20020a056a00168700b00565a932f05amr34363733pfc.21.1666631390642; Mon, 24 Oct 2022 10:09:50 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id j7-20020a17090276c700b0017f73caf588sm829plt.218.2022.10.24.10.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 10:09:50 -0700 (PDT) Date: Mon, 24 Oct 2022 10:09:47 -0700 From: Dennis Zhou To: Baoquan He , Andrew Morton Cc: linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , linux-mm@kvack.org Subject: Re: [PATCH 0/8] Cleanup and optimization patches for percpu Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024081435.204970-1-bhe@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666631391; a=rsa-sha256; cv=none; b=q6cnD4B91vNvaEPSjFXjjUsbR9hg08d7HSgrYnt08fg2bvIaFJIKOYRUDuu/aND7LpGxO5 977gfoavq1fIFEqfCzRK2XZ/R9l+0/pvwRYyMLRPwOfy/1ZohK+nKA0z6VbKt7lX0wf6En McGejYR+nSYSpKsl/qsVkoRTMsgNN+c= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666631391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gz6IbE5QNnnx6hJZ/M0UjY5y91KtBmJ2N2+vRHclsWk=; b=YuGMUTkhqOacVFNzbZOkxhKI65wntfWl8HhQ5mSCFbyyuF9EdyGjvxKz17Wxq/BSttIcxo g/3tq4YZ1JEuQJ8DwSHlFUooAyd+ZlOA/FzNPfGGYcDPBigCVFYj2xlnr/st6PlL+yaR6k FVUNoJr4uEyYO6QAmFvoKANgn1WZDxM= X-Rspamd-Queue-Id: B8203C0024 Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: imp1i48ajqi747d6is7xak3d5gtkzeiw X-HE-Tag: 1666631391-863660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Mon, Oct 24, 2022 at 04:14:27PM +0800, Baoquan He wrote: > These were found out when reading percpu code, and queued in my local > branch for long time. Send them out for reviewing. > > Baoquan He (8): > mm/percpu: remove unused pcpu_map_extend_chunks > mm/percpu: use list_first_entry_or_null in pcpu_reclaim_populated() > mm/percpu: Update the code comment when creating new chunk > mm/percpu: add comment to state the empty populated pages accounting > mm/percpu: replace the goto with break > mm/percpu.c: remove the lcm code since block size is fixed at page > size > mm/percpu: remove unused PERCPU_DYNAMIC_EARLY_SLOTS > mm/slub, percpu: correct the calculation of early percpu allocation > size > > include/linux/percpu.h | 7 +++---- > mm/percpu.c | 44 +++++++++++++++++------------------------- > mm/slub.c | 3 ++- > 3 files changed, 23 insertions(+), 31 deletions(-) > > -- > 2.34.1 > > Thanks for the clean ups. The empty page accounting is more subtle than I remember. Andrew, I think for these cleanups it'd be easiest for you to pick these up. Thanks, Dennis