From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C00FA373F for ; Mon, 24 Oct 2022 17:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 982F6940008; Mon, 24 Oct 2022 13:00:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93314940007; Mon, 24 Oct 2022 13:00:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821E2940008; Mon, 24 Oct 2022 13:00:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 764A3940007 for ; Mon, 24 Oct 2022 13:00:44 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 267A4160D31 for ; Mon, 24 Oct 2022 17:00:44 +0000 (UTC) X-FDA: 80056457208.08.A8F8BC0 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf25.hostedemail.com (Postfix) with ESMTP id F2543A004D for ; Mon, 24 Oct 2022 17:00:42 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id h2so3045498pgp.4 for ; Mon, 24 Oct 2022 10:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Cf/TLxQsRJaAY7fW9M9+2EYkzBjkKpnwfAzuDgLjY4Q=; b=236/DFG4yUKT4nCmoevRVsKwEC+zDO8scNPYIKJuOguXZS5cgHiY0AVwCn2lIKa6Pa XLOFTNHcrXrzL0Xg2EQ6s0EyD3xAfce3kdSyYN6nj4EhLl/Eo5nup7Ts5jAdcAHA34fE Czm3awrkFer6vvvxYtMc/AEJ/vQYCaoNz12m7rdW3rmlfGJ6V6rOnEZNNyXinyMU61l8 0QGjrrSPYTh1JNeOTmSbIH9R1VzPtGI5VeM/iRUAextx3b0Kdv4X62zn4XH/iDlloahP 18HcmQ8MuaoVe1bpXlfSPoLIXwUz15AdC2PjyCYZXloFg2zGXfPXVfTcwPJCq/Gl9ZL2 8FnQ== X-Gm-Message-State: ACrzQf3JAj7orrCorTXgTzHqcJKOrvfjUa6UqpqG8jg3UqVbpqEEBKYT didqt4YcH8lZUrRz3kCiU98= X-Google-Smtp-Source: AMsMyM4gKJpuD0QQTvrs1NIr7py9UPRLcUMEZTkGNLj5y1BXHCzxdHlVoStAQ87RXqzr/YQ6bnZWuw== X-Received: by 2002:a63:5643:0:b0:44d:b691:1da1 with SMTP id g3-20020a635643000000b0044db6911da1mr29665429pgm.450.1666630841929; Mon, 24 Oct 2022 10:00:41 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id i4-20020a1709026ac400b00186a68ec086sm1936026plt.193.2022.10.24.10.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 10:00:41 -0700 (PDT) Date: Mon, 24 Oct 2022 10:00:38 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 6/8] mm/percpu.c: remove the lcm code since block size is fixed at page size Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> <20221024081435.204970-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024081435.204970-7-bhe@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666630843; a=rsa-sha256; cv=none; b=MeVfvWCSDfHjifn4Gz0xqCVrmnWEI9CmsbUH91eMXxQahVPngcGkjbd7xJeqzhR0NQlabq /hdjUj4y/12FiT+vgeZQC3MP5b4AtNHYOlhEpiYqWEHIXLxWCJtxDBQ5eLvVvAW7XPrhAH VPUWedj8wjbr6G+A0Se6cD3o0SDMFKQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf25.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666630843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cf/TLxQsRJaAY7fW9M9+2EYkzBjkKpnwfAzuDgLjY4Q=; b=ElPKwxIpqK8W3dU4jyb+vekRgzs4BbxITazUSrHrcf1/o2uuBGDrP6t9yVF4Uq5Rnk5mgJ PDgma1qjWVFfp75ZvdAW1AdjAKQNU3d/bkD0PzbyrhjoNn+NRyTRCrMKIX8ZryiTRUsD+W oFbijW7Bw/kk23IlwYqUSlD4wE/cjE8= X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf25.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-Rspamd-Server: rspam11 X-Stat-Signature: rkjn7c36fzwya8xafj4ycy5ijofxrnw3 X-Rspamd-Queue-Id: F2543A004D X-HE-Tag: 1666630842-550488 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 04:14:33PM +0800, Baoquan He wrote: > Since commit b239f7daf553 ("percpu: set PCPU_BITMAP_BLOCK_SIZE to > PAGE_SIZE"), the PCPU_BITMAP_BLOCK_SIZE has been set to page size > fixedly. So the lcm code in pcpu_alloc_first_chunk() doesn't make > sense any more, clean it up. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 954abf916c7d..96191f7b61ba 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -72,7 +72,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1347,7 +1346,7 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr, > int map_size) > { > struct pcpu_chunk *chunk; > - unsigned long aligned_addr, lcm_align; > + unsigned long aligned_addr; > int start_offset, offset_bits, region_size, region_bits; > size_t alloc_size; > > @@ -1355,14 +1354,7 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr, > aligned_addr = tmp_addr & PAGE_MASK; > > start_offset = tmp_addr - aligned_addr; > - > - /* > - * Align the end of the region with the LCM of PAGE_SIZE and > - * PCPU_BITMAP_BLOCK_SIZE. One of these constants is a multiple of > - * the other. > - */ > - lcm_align = lcm(PAGE_SIZE, PCPU_BITMAP_BLOCK_SIZE); > - region_size = ALIGN(start_offset + map_size, lcm_align); > + region_size = ALIGN(start_offset + map_size, PAGE_SIZE); > > /* allocate chunk */ > alloc_size = struct_size(chunk, populated, > -- > 2.34.1 > > Acked-by: Dennis Zhou Thanks, Dennis