From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E47CECAAA1 for ; Mon, 24 Oct 2022 17:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2CE4940008; Mon, 24 Oct 2022 13:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDCEC940007; Mon, 24 Oct 2022 13:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCCCC940008; Mon, 24 Oct 2022 13:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AEE80940007 for ; Mon, 24 Oct 2022 13:00:14 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8218E160D32 for ; Mon, 24 Oct 2022 17:00:14 +0000 (UTC) X-FDA: 80056455948.30.4FC7BF9 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf23.hostedemail.com (Postfix) with ESMTP id 132FE140009 for ; Mon, 24 Oct 2022 17:00:13 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id ez6so8578488pjb.1 for ; Mon, 24 Oct 2022 10:00:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AXEhQBaYJcsY09QjqAQ/xiILbCbyndNxr5VQjFtEgKQ=; b=I/qDee7WB7L96hwjSakimjKib6+bwkxjAwKIFRlhAxP0hTITirO1F37FtS+dJEmeXX ChWGu6lQOYHxc6gSkbbv4qqHMYJqKfV7szX7FLCRBiwYRmNmb8LtZqUwuJZSZbmXsYZF eAGbWaLsAmUiVqr1ngYFbKRKIBYojoGqQ9o4MXg0yTEx/1tqEndTzUy08ljBB01rZsD2 EfdsWOIe0wUP8b1vp8PXmUSc4p4hhas/CDZ2iobzUBJm/oB0l7t8SgafBW8lpqOYflSz ZdPNPTYpQHLu4ExEr69MYKndxFqdRegpI+FxY/yDfudmA+8FIdp1DFB29BRocDKaLAU/ zqHQ== X-Gm-Message-State: ACrzQf28GY6TqYPAVRr6nlE7PEMzeVzA6eVrE+7CnL+T5YeJ+DHnZOkW nuopZPMoAzl2PGK2fq0EAAE= X-Google-Smtp-Source: AMsMyM7A9M3yUshFCPJyOZ62hibLjAF/FHYr9gcDzJC8CXGxdicRR8u2cDReyV6WUYpbsjxjoRtxAA== X-Received: by 2002:a17:90b:1d0f:b0:20d:1ec3:f732 with SMTP id on15-20020a17090b1d0f00b0020d1ec3f732mr38720175pjb.84.1666630812805; Mon, 24 Oct 2022 10:00:12 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id q14-20020a170902a3ce00b00186748fe6ccsm6530456plb.214.2022.10.24.10.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 10:00:12 -0700 (PDT) Date: Mon, 24 Oct 2022 10:00:09 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 5/8] mm/percpu: replace the goto with break Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> <20221024081435.204970-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024081435.204970-6-bhe@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666630814; a=rsa-sha256; cv=none; b=YUEb6uXiF4+tPpktm8aPlhDBU5NxE5dusrjikvoj1EBurNwLWDv5k+1U9gFddy9Ssj/BIY kA+H4j9X/4FjiqLCUic6IeQj7YUfgBOHUckZhcSxFZzn1v9wUlYxpQSeaA8B0c0wxJKDZE Hhzl9KulswAyiYONixD47Wu3a83zxtM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666630814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AXEhQBaYJcsY09QjqAQ/xiILbCbyndNxr5VQjFtEgKQ=; b=l77ZH+sFBW3syc7t6HAYuGVhjpNMqtYu0UcY33RDcM2IHdCnqYgv8kxihnQfsvWqRPAcaw XMKPnlwE6O/2gTzGN6f4HBAHj87F6UzQZM/MG+G8txw0G66AudB0GV/fz8GvfJYv5inFly q1LmbKEQYiXRxHDg6zY/rbKIrVIdfIs= X-Rspam-User: X-Rspamd-Queue-Id: 132FE140009 Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Stat-Signature: 4qwc1rsqhyr87mdek9pe74qj9itxyqwi X-Rspamd-Server: rspam03 X-HE-Tag: 1666630813-636340 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 04:14:32PM +0800, Baoquan He wrote: > In function pcpu_reclaim_populated(), the line of goto jumping is > unnecessary since the label 'end_chunk' is near the end of the for > loop, use break instead. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 09e407338573..954abf916c7d 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2167,7 +2167,7 @@ static void pcpu_reclaim_populated(void) > /* reintegrate chunk to prevent atomic alloc failures */ > if (pcpu_nr_empty_pop_pages < PCPU_EMPTY_POP_PAGES_HIGH) { > reintegrate = true; > - goto end_chunk; > + break; > } > > /* > @@ -2203,7 +2203,6 @@ static void pcpu_reclaim_populated(void) > end = -1; > } > > -end_chunk: > /* batch tlb flush per chunk to amortize cost */ > if (freed_page_start < freed_page_end) { > spin_unlock_irq(&pcpu_lock); > -- > 2.34.1 > > Acked-by: Dennis Zhou Thanks, Dennis