From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7789BC38A2D for ; Mon, 24 Oct 2022 16:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E697C940009; Mon, 24 Oct 2022 12:54:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19D4940007; Mon, 24 Oct 2022 12:54:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE25F940009; Mon, 24 Oct 2022 12:54:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BEB40940007 for ; Mon, 24 Oct 2022 12:54:09 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9336A40C5F for ; Mon, 24 Oct 2022 16:54:09 +0000 (UTC) X-FDA: 80056440618.05.C53BE43 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 36B3920031 for ; Mon, 24 Oct 2022 16:54:08 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id y1so9468123pfr.3 for ; Mon, 24 Oct 2022 09:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IIODV4k/CxyWqDrn3BTYro+Cv7bqOVAWuIcvp79HhCE=; b=angczcGe7VTZDMvqfFnL3cpBAfgnB/I85PNjLm0iQU33s2vtu4l/skJRTGqmoMo/5/ 08Vgbt5XEQNYb1QzOAsVjC4zgn6Es2sI1hktlfN4RLQdJYUdHKW7PX5fY6OV4z8WjqbH 2Sfv+wk41nLQUsD+pxvJJ2pIdx4s7dCDwC18phOPpWsjETE8il+S5QypsDyh30vrZWGs 8wxPaKFCn26F6GR3Q+mBQ1rvNdZ4RgJpur64Rl0y6NvLL9nZoDtoDVPABXR0SgLd0kqG sYiQWM3EIsvZlPJSr1NFoNYZ7bkA61ruAFCKDTxow46uK+NJsAiljrpoeYUjC6WXWpKH oifQ== X-Gm-Message-State: ACrzQf1LwaIKrl677AnV+o4fV/xWm4lAfqjzN2BccIQJaFC7GTHOdE6P XJUcLaGqI1GwwcBSSj7eOl4= X-Google-Smtp-Source: AMsMyM5c2yAMlKT6ppP55adKTTI1IbDFN45o4qH3Q2phSQCzf7CiMRhyLDyABC07sAI/azek2lLnug== X-Received: by 2002:a63:8a42:0:b0:460:58ec:cc66 with SMTP id y63-20020a638a42000000b0046058eccc66mr28924890pgd.195.1666630448231; Mon, 24 Oct 2022 09:54:08 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id b5-20020a170902e94500b001868da70685sm4097249pll.235.2022.10.24.09.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 09:54:07 -0700 (PDT) Date: Mon, 24 Oct 2022 09:54:05 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 3/8] mm/percpu: Update the code comment when creating new chunk Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> <20221024081435.204970-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024081435.204970-4-bhe@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666630449; a=rsa-sha256; cv=none; b=uKepTEd4cAgGyJLRi2QxSrxSzG18UYRxDOjodjmzliQsj7gx4bf7NwdvRS26W5ABoUdMI6 b1k96XH0iJoszVparLTQMsXG6mmsafaJEyWaMzak8hexKog5agk/3EZfibvF9/EAo8tJBN JRDJhW2AizFCKyUTCklEubWZRiFji9M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666630449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IIODV4k/CxyWqDrn3BTYro+Cv7bqOVAWuIcvp79HhCE=; b=RveViWMau9hIpH0eIEoTqTWyDuLV9gM76kN5by5f5PV3/i6bEdbqWmIEdEU17TsBzlD/uM Tuns6e0ag4TsixuPY7ilwoYmgh//ML2QyYGYRDQ+5JnhRO0Bk//LgkH3idqu3O84xwpGhx 67JW4xWxoOkzVL2wOYBZ8GyhgBOMc4k= X-Stat-Signature: 85spo8wmsawamrdh8e1c7hpwff8mcm3m X-Rspamd-Queue-Id: 36B3920031 Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666630448-51639 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 04:14:30PM +0800, Baoquan He wrote: > The lock pcpu_alloc_mutex taking code has been moved to the beginning of > pcpu_allo() if it's non atomic allocation. So the code comment above Typo here ^ pcpu_alloc(). > above pcpu_create_chunk() callsite need be updated. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index a3fde4ac03a4..a8121302a79c 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1817,16 +1817,12 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, > > spin_unlock_irqrestore(&pcpu_lock, flags); > > - /* > - * No space left. Create a new chunk. We don't want multiple > - * tasks to create chunks simultaneously. Serialize and create iff > - * there's still no empty chunk after grabbing the mutex. > - */ > if (is_atomic) { > err = "atomic alloc failed, no space left"; > goto fail; > } > > + /* No space left. Create a new chunk. */ > if (list_empty(&pcpu_chunk_lists[pcpu_free_slot])) { > chunk = pcpu_create_chunk(pcpu_gfp); > if (!chunk) { > -- > 2.34.1 > > Acked-by: Dennis Zhou Thanks, Dennis