From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E581C38A2D for ; Mon, 24 Oct 2022 16:53:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20EBB940009; Mon, 24 Oct 2022 12:53:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19872940007; Mon, 24 Oct 2022 12:53:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0391A940009; Mon, 24 Oct 2022 12:53:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E6402940007 for ; Mon, 24 Oct 2022 12:53:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C44021A0963 for ; Mon, 24 Oct 2022 16:53:03 +0000 (UTC) X-FDA: 80056437846.05.D66B52E Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf20.hostedemail.com (Postfix) with ESMTP id 71F261C0004 for ; Mon, 24 Oct 2022 16:53:03 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id p3so7999569pld.10 for ; Mon, 24 Oct 2022 09:53:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VmgpA6OkYsLwdfzsxv2INipi2Xj6qCgSNWdLB1yHrm8=; b=kv1FZHb4RXzlDP6OejJIGNs+jk8I4kVLQh4gIdIsIS0Z6dKY40Mlw+9CwKLZzUYWHy Kcz/KMxD9JUvbM+QwV/7MMb4m/psG8E0RgrZ2HnSds3fwC4UYqcidNaW8Op42DUf6F61 f1sO31eocBfTL4yFRrKAk240alZ+bExrJTgirtDvVQUUMbNNlCPcfoJ7eqLNWDFNeSNg xCrh0+q6qB+GpEPNLXi75YCHPfNCpPuQbilDwkWrOun3DX4Z4TknJ9Sh8jXlTU0Xif6Q ZhMJmdLK3xMlUejToVEyCm4xjFmo6Bc8nmKLS8C4ZgmrSdg/JQ0dyCQkP33gBXsFuxH0 7XAg== X-Gm-Message-State: ACrzQf3+ZTSJb1bbo1h9SWEezIsz6rMCxT4LaQ7dwN/44QKD4L07VMBz xTYETHiErlxeQucWLO+invg= X-Google-Smtp-Source: AMsMyM6bW4DnZPqZV9F/kwL3i4LeBiBpwKE8ZEGcxsLa53770ie/31U4fbgiZMsM56Gv5HK/2Kzz/w== X-Received: by 2002:a17:903:230b:b0:186:6041:51bf with SMTP id d11-20020a170903230b00b00186604151bfmr23671890plh.24.1666630382267; Mon, 24 Oct 2022 09:53:02 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id ix21-20020a170902f81500b00186aaf1644asm1251plb.87.2022.10.24.09.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 09:53:01 -0700 (PDT) Date: Mon, 24 Oct 2022 09:52:59 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 2/8] mm/percpu: use list_first_entry_or_null in pcpu_reclaim_populated() Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> <20221024081435.204970-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024081435.204970-3-bhe@redhat.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666630383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VmgpA6OkYsLwdfzsxv2INipi2Xj6qCgSNWdLB1yHrm8=; b=hwZv2b4BC3j2d0MeqRvchrGNksF3mXT8ECcDJEm7KWv7t1VlDORxKhKoT2TOd8C0H1C4+Z GrdHMQlxuXvBPFQLoCfgJoJwPMCyPF/dKvtdAeLaOTcYkxNo7lewNVRICIDP85lnCRjUgi XbUxtObZHtvS05pLYX1m2pm1bBs1R4g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666630383; a=rsa-sha256; cv=none; b=DlNcRnrnkh8iRqkDB9KubS5f3aAOQ6SXMrYlSJxS1whT9Iy2ezmixEAj6PzBkhBC/L+jgs inVBq0JXfr9TdzBtGFpM9LkpsLbPuP1IssAcoPWk9Jt97vy48sc+j6wiGrHrij6TK9IUUs umNpd78BWeBm6bdilc9Ic+MOvSp2nB0= Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Stat-Signature: gk8grwq8p9osqw5wq457nsy5t3emmem4 X-Rspamd-Queue-Id: 71F261C0004 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1666630383-429637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 04:14:29PM +0800, Baoquan He wrote: > To replace list_empty()/list_first_entry() pair to simplify code. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 26d8cd2ca323..a3fde4ac03a4 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2143,9 +2143,9 @@ static void pcpu_reclaim_populated(void) > * other accessor is the free path which only returns area back to the > * allocator not touching the populated bitmap. > */ > - while (!list_empty(&pcpu_chunk_lists[pcpu_to_depopulate_slot])) { > - chunk = list_first_entry(&pcpu_chunk_lists[pcpu_to_depopulate_slot], > - struct pcpu_chunk, list); > + while (chunk = list_first_entry_or_null( > + &pcpu_chunk_lists[pcpu_to_depopulate_slot], > + struct pcpu_chunk, list)) { > WARN_ON(chunk->immutable); > > /* > -- > 2.34.1 > With added parenthesis, Acked-by: Dennis Zhou Thanks, Dennis