From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF6AECAAA1 for ; Mon, 24 Oct 2022 11:13:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928D48E0002; Mon, 24 Oct 2022 07:13:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D8EF8E0001; Mon, 24 Oct 2022 07:13:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A1D38E0002; Mon, 24 Oct 2022 07:13:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 66DA48E0001 for ; Mon, 24 Oct 2022 07:13:37 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3C75EC0B14 for ; Mon, 24 Oct 2022 11:13:37 +0000 (UTC) X-FDA: 80055582474.04.1EEEAC8 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf26.hostedemail.com (Postfix) with ESMTP id 7CEFD14000A for ; Mon, 24 Oct 2022 11:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cBDkBr7vYUB7A8Ost1DKjjkaKnH15tbd8dYfxDJQD38=; b=NQ7/5E2VdPz3hqSrREq13WOsYw 7OjbQIhMab1CWMDTYpWIjExQ/7gUPIaEpzsf/d0899RZAiNH8t1OnS+CIfiBCuBixwibhgkePjhab mAhPmzKO2cS5tHi8WUc7IlibUadOJYQeFUXsUe5FEge8mZGnQRZuQit/U1BjKULuvwlUpGnGaH6I/ Cm8tjd/+xsa8C//w99oE4liaPNF3RgYEIfinD29AKjXdGpl92JIUrxIk0iM6EbrqtV8DPAJmEUS5w bSXu6Ac/eDZHWbnwCNMOjoh2sfyj/yMdxk+mrf3f0IO8XzLBz+XHdAPUEr4Q7qDh9htaBvWNsUJAs Au9qgPBg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1omvOR-00632M-O4; Mon, 24 Oct 2022 11:13:24 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AB0BC300445; Mon, 24 Oct 2022 13:13:18 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 875D02C35E216; Mon, 24 Oct 2022 13:13:18 +0200 (CEST) Date: Mon, 24 Oct 2022 13:13:18 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: x86@kernel.org, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Subject: Re: [PATCH 10/13] x86/mm/pae: Be consistent with pXXp_get_and_clear() Message-ID: References: <20221022111403.531902164@infradead.org> <20221022114425.103392961@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="NQ7/5E2V"; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666610016; a=rsa-sha256; cv=none; b=hCkCQwr3DrjxCKR1e1vp//VooHtVMN/P3UkmVz+a7cKc9rc5vCvQeUQ6LlKf2tYut0sB/K /0Ljxy+fSUsLtn09eLa5ftZALiF2KGuV2MFzEDYuG5UTV1a/rfIs2Ts9FCSilM6/fljlLM Yf66vgEj36H+1EBueDU6fy4Q0+qnA7Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666610016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cBDkBr7vYUB7A8Ost1DKjjkaKnH15tbd8dYfxDJQD38=; b=WUYtmmriLus9x9EeEWqAak4mCpZGv48BXyqoQ4Il/zOxNonDUjK25vdKI1CYelWVnR2G2Z 7xaPWOr3ziRlKAsHa1hVUiW+CZ22YH8fEI66NVPOOFNSJncalCtJPYlKJXgXRor/b8QyIW koJDxLv8DW+A3OtTq4VmY3umBYTiVA8= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="NQ7/5E2V"; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: pte4hhyyqnoaarxr9f8wtgmoz4s1b9bk X-Rspamd-Queue-Id: 7CEFD14000A X-HE-Tag: 1666610014-467786 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 10:53:42AM -0700, Linus Torvalds wrote: > On Sat, Oct 22, 2022 at 4:48 AM Peter Zijlstra wrote: > > > > + > > +#define pxx_xchg64(_pxx, _ptr, _val) ({ \ > > + _pxx##val_t *_p = (_pxx##val_t *)_ptr; \ > > + _pxx##val_t _o = *_p; \ > > + do { } while (!try_cmpxchg64(_p, &_o, (_val))); \ > > + native_make_##_pxx(_o); \ > > +}) > > I think this could just be a "xchp64()", but if the pte/pmd code is > the only thing that actually wants this on 32-bit architectures, I'm > certainly ok with making it be specific to just this code, and calling > it "pxx_xchg()". Regular xchg64() didn't work, the casting crud there is required because of how pxx_t is a struct. Now I could obviously do a xchg64(), but then we'd still need this wrapper -- and yeah, I don't know how many other users there are.