From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D62C3A59D for ; Mon, 24 Oct 2022 08:09:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741EB8E0002; Mon, 24 Oct 2022 04:09:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FAE98E0001; Mon, 24 Oct 2022 04:09:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B94C8E0002; Mon, 24 Oct 2022 04:09:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 487CC8E0001 for ; Mon, 24 Oct 2022 04:09:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1216C16019F for ; Mon, 24 Oct 2022 08:09:59 +0000 (UTC) X-FDA: 80055119718.30.75E34EA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id AF9C4100005 for ; Mon, 24 Oct 2022 08:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UwtyZS/lYmNxfO8IfzbqIzyAUJEvEF9ONCF2NviYd8Y=; b=Fcvm9olpUulVNJSzwt/lYCJUHg vZyRSpuk/rl/rVPUPnWQgh9oyUq/fO4f1EGBwkbgr+zXM6ZI1d0h2vhSopYTmlby14THJGywG61c2 YRnyf7Zh4mc5vkO4/YmkkOa7uxTetB7pVBoZX/TlpBqdkU7BgR4ZYEaFoWpLwSN05y6TVI0pGVoM7 kdy+WNZCIv6yVa6qm/1jrMAhrRoZBl/NJWfU2l2HXfFVuna428CejJjhilF+bWQaSq/NAFK8JpkDi hAmD+p0KBIuBcO5ZzQ/KFTBl6CWnv9sQ4weuDAe+V1tk9OLc+XcAXjQC4xwyaly9GKscjRWV7NztT oZw0j77g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1omsX2-00FGt5-Am; Mon, 24 Oct 2022 08:10:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3F37C300242; Mon, 24 Oct 2022 10:09:55 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 203AD2C2328BB; Mon, 24 Oct 2022 10:09:55 +0200 (CEST) Date: Mon, 24 Oct 2022 10:09:55 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: x86@kernel.org, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Subject: Re: [PATCH 04/13] mm: Fix pmd_read_atomic() Message-ID: References: <20221022111403.531902164@infradead.org> <20221022114424.711181252@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Fcvm9olp; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666598998; a=rsa-sha256; cv=none; b=bD5iUWFGpVJTrKfQGhowpzHANlKJuvdzX5aKctbT9lJTfyyFt1UNN/EU2M/6V/zcSkaVpC 9yMEvsq3hFPpjuS1R6/sr7VK1O/oe3qpiUrmTfEfDwVtenh0JUlpObdBEKabUyoP4ngvIY Tr3iNWRrwiDXy8G8RIGp64T+dj5x/Hc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666598998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UwtyZS/lYmNxfO8IfzbqIzyAUJEvEF9ONCF2NviYd8Y=; b=CBcXlIT1OJXHMkbTj/o3iu+Krvd+6XRjBN+ssLpD3p5M+PfntqbeKag7nGRDSxcVmzc0sF UECA8nfP7PTSJ1nF6rQOTTFHiAFIOiDJPtDkxp20N+GRAF/mh4LgqBnTmx9eDGdc/EfvN/ RrPfvPi4kZhf5t8u00eF6RSU5xLL550= X-Stat-Signature: 4481hzqjeufyn38pszpse7aksyice8ir X-Rspamd-Queue-Id: AF9C4100005 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Fcvm9olp; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-HE-Tag: 1666598998-478877 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 10:30:51AM -0700, Linus Torvalds wrote: > On Sat, Oct 22, 2022 at 4:48 AM Peter Zijlstra wrote: > > > > --- a/include/linux/pgtable.h > > +++ b/include/linux/pgtable.h > > @@ -258,6 +258,13 @@ static inline pte_t ptep_get(pte_t *ptep > > } > > #endif > > > > +#ifndef __HAVE_ARCH_PMDP_GET > > +static inline pmd_t pmdp_get(pmd_t *pmdp) > > +{ > > + return READ_ONCE(*pmdp); > > +} > > +#endif > > What, what, what? > > Where did that __HAVE_ARCH_PMDP_GET come from? Copy/paste like from ptep_get(), that has __HAVE_ARCH_PTEP_GET (which does appear to get used, once). Do I break the pattern and simply leave this off, or do I stay consistent even though we hate it a little? ;-)