From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A99C433FE for ; Sat, 22 Oct 2022 04:14:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 082698E0002; Sat, 22 Oct 2022 00:14:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00BCB8E0001; Sat, 22 Oct 2022 00:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEDFE8E0002; Sat, 22 Oct 2022 00:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CAF168E0001 for ; Sat, 22 Oct 2022 00:14:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A8B0A1405E4 for ; Sat, 22 Oct 2022 04:14:18 +0000 (UTC) X-FDA: 80047268196.11.3FE369F Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 58C0C140014 for ; Sat, 22 Oct 2022 04:14:18 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id f9-20020a17090a654900b00210928389f8so8452149pjs.2 for ; Fri, 21 Oct 2022 21:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dFD76B1WOxbM6hvMl4TWkrGv9g+jIBPp+IWZbs4ACgA=; b=WZc9VMxCxukydXe+XWvhnyfUeVIYaHmZ7bBRgW3fMNkv2baBrKCVeEeThIP70aJxI4 oPUEABJa0R93ioGXGKhPeYjsTy04DQpP91xeF7/iGSu+PM1LNTvq/KGjFDdn0i/IfN5t ZF+nnpnxiGooI9FqNZsIgVAyPEIaBjquTJidE6SAmKb8lOcYB5nUVm1INxr47gMtdx1G uP1jXvIVGHevWa9gm6i+EgPZ1ucpN1iBlsgU1DKxcxM+r+omUnNR+0ya9yosffjFp7mr WuCBxNyq4U8XoZ22isN3wJsx8cSeokDKyrViHuJPtg8D8fwSB/ApEyhbRBA9zpuVodXT Lm9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dFD76B1WOxbM6hvMl4TWkrGv9g+jIBPp+IWZbs4ACgA=; b=dmq2MqvAuYlIMEnJeL7SWCDO8vBzvz5Mr0dilOQBFMnZ/DUQ7DiBKZ7GGMGks8xCpy p5wzb8Yoow0eoI+jAQylDoX/iPg9GS58BOlh+XTHaZs4n9VYuuw5o4zEu8ln7WyVCirQ 10jX/i6So8HjAefxxdrMsZVWn1MAKwmZYv5QQoSMDIG3PmnSM4IVS3SBk1+Tf9792dL2 Y8ZQZ/3HZW0O0CW1QnwT8sSjrgHT93IxK088eLgT3GhFDFgtZtpY6uvOwDTaYnMnnGr0 HDx1Ngzqy9bN4SV/AntzimpK+FM9Diy19P+I/Pvjb/NDsZoqlzBUsre9Smk2ZEwmNjF6 j9Mg== X-Gm-Message-State: ACrzQf1zUMZVSyzvYpAFhnrBSGgHpoVyMyw1hkgzEsjRFjWeZBDh9Aly +wxaFw4H2wRe+wsRaQC/f38= X-Google-Smtp-Source: AMsMyM6eSrtheknT3YaeF3DoWSfwMIIDLVJdWV4dFmd36QwgHbCMgHScxt4/NJrBFcuRO/JEBEut/Q== X-Received: by 2002:a17:902:d58c:b0:17f:998a:76cd with SMTP id k12-20020a170902d58c00b0017f998a76cdmr22309000plh.155.1666412057109; Fri, 21 Oct 2022 21:14:17 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id lw12-20020a17090b180c00b0020d67a726easm587012pjb.10.2022.10.21.21.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 21:14:16 -0700 (PDT) Date: Sat, 22 Oct 2022 13:14:10 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove dead code for debug caches on deactivate_slab() Message-ID: References: <20221014114322.97512-1-42.hyeyoo@gmail.com> <82e8147e-f031-6bc2-9395-56d2052e62cb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82e8147e-f031-6bc2-9395-56d2052e62cb@suse.cz> ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WZc9VMxC; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666412058; a=rsa-sha256; cv=none; b=W5GVTrJBGNxX/gGnswJNOY4wNwbbqOINcfcN2YVdJp5x/Wr35QLE42tk7h0b6EzfOhP6i7 1VbLdFIuK5sRjYrKRIbM2+aJiEQisZ+saGFevU1sMjA3+QPUtrMCdV/ZGVcE9TvkX0NkRw tzQcOrxNbNOaIoGGBRShJ4EqRyFCOBc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666412058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dFD76B1WOxbM6hvMl4TWkrGv9g+jIBPp+IWZbs4ACgA=; b=fVNzpNER+Khs8QLuJDfzwZTrTgLReXOP/+rUuMAFHCivXoCnv6ct9HrPSxmOmHV14bm+cd Suoaz1FmGA/6B2YtKCrx3QoPsM8ff9jCvTztu8ONwooeOG3UigPMpTkz3pEViFrcirgABI PPgVGsDu19eHoofZ4kqbN20nHvV6zyY= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WZc9VMxC; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: p4rtdkcqmro8xjishnfzijdbqg1pbemr X-Rspamd-Queue-Id: 58C0C140014 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666412058-502522 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 21, 2022 at 12:43:42PM +0200, Vlastimil Babka wrote: > On 10/14/22 13:43, Hyeonggon Yoo wrote: > > After commit c7323a5ad0786 ("mm/slub: restrict sysfs validation to debug > > caches and make it safe"), SLUB does not take a slab from partial list for > > I'm confused by "SLUB does not take a slab from partial list" here. Did you > mean something like "SLUB never installs (even temporarily) a percpu slab > for debug caches"? Yes. > So that means we never deactivate percpu slabs for debug > caches. Yes. > And since debug caches are also the only ones that use the full > list, we no longer need to care about the full list in deactivate_slab(), right? Yes, You got it right, exactly! Let me rephrase: "After commit c7323a5ad0786 ("mm/slub: restrict sysfs validation to debug caches and make it safe"), SLUB never installs percpu slab for debug caches and thus never deactivates percpu slab for them. Since only some of debug caches care about the full list, SLUB no longer deactivates to full list. Remove dead code in deactivate_slab()." Feel free to change this ;-) > > > debug caches. As deactivation isn't needed anymore, remove dead code. > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Otherwise it looks correct to me, just wanted to clarify I'm not missing > something. You are not missing anything. Thank you for clarification. Hyeonggon > > > --- > > mm/slub.c | 16 ++-------------- > > 1 file changed, 2 insertions(+), 14 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index 96dd392d7f99..e2215240954d 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -2411,7 +2411,7 @@ static void init_kmem_cache_cpus(struct kmem_cache *s) > > static void deactivate_slab(struct kmem_cache *s, struct slab *slab, > > void *freelist) > > { > > - enum slab_modes { M_NONE, M_PARTIAL, M_FULL, M_FREE, M_FULL_NOLIST }; > > + enum slab_modes { M_NONE, M_PARTIAL, M_FREE, M_FULL_NOLIST }; > > struct kmem_cache_node *n = get_node(s, slab_nid(slab)); > > int free_delta = 0; > > enum slab_modes mode = M_NONE; > > @@ -2487,14 +2487,6 @@ static void deactivate_slab(struct kmem_cache *s, struct slab *slab, > > * acquire_slab() will see a slab that is frozen > > */ > > spin_lock_irqsave(&n->list_lock, flags); > > - } else if (kmem_cache_debug_flags(s, SLAB_STORE_USER)) { > > - mode = M_FULL; > > - /* > > - * This also ensures that the scanning of full > > - * slabs from diagnostic functions will not see > > - * any frozen slabs. > > - */ > > - spin_lock_irqsave(&n->list_lock, flags); > > } else { > > mode = M_FULL_NOLIST; > > } > > @@ -2504,7 +2496,7 @@ static void deactivate_slab(struct kmem_cache *s, struct slab *slab, > > old.freelist, old.counters, > > new.freelist, new.counters, > > "unfreezing slab")) { > > - if (mode == M_PARTIAL || mode == M_FULL) > > + if (mode == M_PARTIAL) > > spin_unlock_irqrestore(&n->list_lock, flags); > > goto redo; > > } > > @@ -2518,10 +2510,6 @@ static void deactivate_slab(struct kmem_cache *s, struct slab *slab, > > stat(s, DEACTIVATE_EMPTY); > > discard_slab(s, slab); > > stat(s, FREE_SLAB); > > - } else if (mode == M_FULL) { > > - add_full(s, n, slab); > > - spin_unlock_irqrestore(&n->list_lock, flags); > > - stat(s, DEACTIVATE_FULL); > > } else if (mode == M_FULL_NOLIST) { > > stat(s, DEACTIVATE_FULL); > > } >