From: Matthew Wilcox <willy@infradead.org>
To: Maria Yu <quic_aiquny@quicinc.com>
Cc: akpm@linux-foundation.org, ziy@nvidia.com, david@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mike.kravetz@oracle.com, opendmb@gmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/page_isolation: fix clang deadcode warning
Date: Fri, 21 Oct 2022 04:19:06 +0100 [thread overview]
Message-ID: <Y1IPqhVpiehRBGNS@casper.infradead.org> (raw)
In-Reply-To: <20221021030953.34925-1-quic_aiquny@quicinc.com>
On Fri, Oct 21, 2022 at 11:09:53AM +0800, Maria Yu wrote:
> When !CONFIG_VM_BUG_ON, there is warning of
> clang-analyzer-deadcode.DeadStores:
> Value stored to 'mt' during its initialization
> is never read.
Honestly, the cure is worse than the disease. I'd rather not have a
line that's this long.
> - int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock));
> -
> - VM_BUG_ON(!is_migrate_isolate(mt));
> + VM_BUG_ON(!is_migrate_isolate(get_pageblock_migratetype(pfn_to_page(isolate_pageblock))));
next prev parent reply other threads:[~2022-10-21 3:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 3:09 Maria Yu
2022-10-21 3:19 ` Matthew Wilcox [this message]
2022-10-21 3:26 ` Aiqun(Maria) Yu
2022-10-21 4:17 ` Andrew Morton
2022-10-21 5:21 ` Aiqun(Maria) Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1IPqhVpiehRBGNS@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=opendmb@gmail.com \
--cc=quic_aiquny@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox