From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B76DC4332F for ; Thu, 20 Oct 2022 18:55:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D157E8E0002; Thu, 20 Oct 2022 14:55:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9ECB8E0001; Thu, 20 Oct 2022 14:55:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B184E8E0002; Thu, 20 Oct 2022 14:55:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E3448E0001 for ; Thu, 20 Oct 2022 14:55:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5687CABB30 for ; Thu, 20 Oct 2022 18:55:53 +0000 (UTC) X-FDA: 80042232186.28.2DDDDBE Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf29.hostedemail.com (Postfix) with ESMTP id E24CF120018 for ; Thu, 20 Oct 2022 18:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ge9twkFFihum2Lbs+cWlgSqO0pZ1W0PUTEw5qgoaO+o=; b=KpgIGHglzljXeIcCMpjutMwoHi cCLcWbEhLQrKU/DA5gx8Aq1WMWARgHkCsaz2saXqstk/OBUMrFwh1ZB5DWM8oXsBdjUvL1xy6nPfr MqYob4kPnoTm3TGqhcr4Z1LXB7CXCr+K51Dup8KmwvHeU+UOD4hp9BqtkS2U/eIQ4EHkmpdjuL2Pe tLLgZuwHiCIvPhoN+vJw9JwvUf2Ug64gpGhfJmZVeABP3B9/2HRvqcqvkGVRp4SGl4cixpq9uhVHl 7C+DwHGe98ksWbXMqfYeea36zYPQ05e+hhgzYlkPM3afn4V2d02zpOAAWCYnKB+nHjvGqqKvSywPh 7KWmKkkw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1olahD-00567r-T6; Thu, 20 Oct 2022 18:55:16 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9825730017D; Thu, 20 Oct 2022 20:55:08 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7B98B2C189950; Thu, 20 Oct 2022 20:55:08 +0200 (CEST) Date: Thu, 20 Oct 2022 20:55:08 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Yu Zhao , Andrew Morton , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v14 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220815071332.627393-1-yuzhao@google.com> <20220815071332.627393-9-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=KpgIGHgl; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666292153; a=rsa-sha256; cv=none; b=qOcdRhB8naZBAOZ3mxmBzp/ofBTdXVZWgg3Y8HZwGTHBZNj3yVqycnkXWYW9ynO5wRUNiT 5gWAzaiyoazhINamR0+pA4BODEqA+bFAjriuA2il9nPslWA/Wsm8y6dxCKAGkujzmqmIlN VxmOYt9TYqkhBLRTptwO/mbx0R0eH2U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666292153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ge9twkFFihum2Lbs+cWlgSqO0pZ1W0PUTEw5qgoaO+o=; b=KcfIA78VBRL0a2invSA3zyw2pdBGb3CuVOC3DqamhYKJOl2LMXi/MM3rLUC3o+kpPNeZXW MSlHJ2x+aDMlqFzkOvW7aHRNsovvyKE/uA2r2ZYA3oe/Z6HjSNABCuG/QX7udmSO3uDkiG X8geyQVFRVMBywY+llJLLmGwxrADsb0= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=KpgIGHgl; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Stat-Signature: n8rpztrz6pu15qfc41nd1ypcfgfsbnm3 X-Rspamd-Queue-Id: E24CF120018 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666292150-337111 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 10:35:28AM -0700, Linus Torvalds wrote: > On Thu, Oct 20, 2022 at 7:14 AM Peter Zijlstra wrote: > > > > So I've been sitting on these here patches (and never having time to > > repost them), which is how I noticed in the first place: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=x86/mm.pae > > Well, that seems an improvement. I don't love how GUP_GET_PTE_LOW_HIGH > now affects the PMD too, but if it's ok for all the three users, I > guess it's ok. Maybe rename it now that it's not just the PTE? > > That said, I reacted to that cmpxchg loop: > > } while (cmpxchg64(&pmdp->pmd, old.pmd, 0ULL) != old.pmd); > > is this series just so old (but rebased) that it doesn't use "try_cmpxchg64()"? Yep -- it's *that* old :-/ You're not in fact the first to point that out. I'll make time tomorrow to fix it up and respin and send out. This is as good a time as any to get rid of carrying these patches myself.