From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2CEC433FE for ; Thu, 20 Oct 2022 12:55:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C01278E0002; Thu, 20 Oct 2022 08:55:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB12B8E0001; Thu, 20 Oct 2022 08:55:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA0988E0002; Thu, 20 Oct 2022 08:55:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9ABAD8E0001 for ; Thu, 20 Oct 2022 08:55:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5E17F1A0A45 for ; Thu, 20 Oct 2022 12:55:09 +0000 (UTC) X-FDA: 80041323138.19.16F6C5E Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf03.hostedemail.com (Postfix) with ESMTP id E358D20005 for ; Thu, 20 Oct 2022 12:55:08 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id b18so26205384ljr.13 for ; Thu, 20 Oct 2022 05:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=fh5EydRcU3nZz8dXo/oBnTkKwNMvB8kiOApoxijExX8=; b=HeTBqNE4swL/K8pvHH639ImHABXhtkTLwOqZljezeVYlOZR4/XVUSmwDd7tsSYbBlN OdEd3bvZhZrXKVkU9mVGY4bA5GJfEfOimPEJzgvtYq6sA7NIx933zsk7WRsCWprPAQpZ NCKnprNzweEgUr2CIvk4uKQiVwV5CIs6l+8hCWDm9JK5IjJM1W6XxJrQJlRoT7HkUvmv 71f+snUydhPOPFoaudHSwdFS7zH4z/uAc0d0Xc48pehjDDtPCD7WEXC/CIjb7Na68nBw rOV8XHTVSMPi0ezTvmC9ybd1j6uu5+cxEdzdtf4gc74ic0JY4iGqWR3AKVkaf9fDhsDy LzGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fh5EydRcU3nZz8dXo/oBnTkKwNMvB8kiOApoxijExX8=; b=JDZNYLqiDpggJTODK4xJ5NWfzGACG5joQvtswj6AAYYrBubHY4u+W9HgmYcng2XCV7 zoulHMFoeXGciLDbbH0WwD/Wu3bJZuSxU5MteUGgOGtoEfz4kcsIIdcWc2DgYmXtwSBw qiBivxIKZo4psczF7TPHBXYKYUMZ/0dQUQ8fgElkbzrqmSziJ7tmQORyI+J/mYrXLTW+ 2LwA5FsVDU7GCiYF+EiUofHHyxxPEH3dAapSif+cxlv2JCZr1gjtFNfSaIpuP6r+D6A/ oJRh4IX0FjVv8p14+pcCBzvf0fFPPAMHrGwnmAfd5/zShRQWh5cwBNT3uLQI7wVmJcN1 aCuQ== X-Gm-Message-State: ACrzQf3y5m6qSW8hTBvAeyz8cDLI/9AvgX4nVVcLu1lDB4CUy3IN6+3m LOpH+TIZ0KLwlGvBLH5KD0I= X-Google-Smtp-Source: AMsMyM4K1q2fbk2/EjEtHDfPjSOFpoqqw6n56Jdtjj9jZ/8feXn32GxKS5/Hd6sfzxQsPsk5LAo3WA== X-Received: by 2002:a2e:9ece:0:b0:26d:ce1c:624 with SMTP id h14-20020a2e9ece000000b0026dce1c0624mr4876090ljk.119.1666270507239; Thu, 20 Oct 2022 05:55:07 -0700 (PDT) Received: from pc636 (host-90-235-12-162.mobileonline.telia.com. [90.235.12.162]) by smtp.gmail.com with ESMTPSA id d21-20020a05651233d500b004a2588520f5sm2708899lfg.166.2022.10.20.05.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 05:55:06 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 20 Oct 2022 14:55:03 +0200 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Matthew Wilcox , Nicholas Piggin , Steven Rostedt , Oleksiy Avramchenko Subject: Re: [PATCH v2 5/7] mm: vmalloc: Use trace_purge_vmap_area_lazy event Message-ID: References: <20221018181053.434508-1-urezki@gmail.com> <20221018181053.434508-6-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666270509; a=rsa-sha256; cv=none; b=Svf/HJNlld53VgZauQ0GNsqlfFRwdUULZKYWehlcLAai0m79BB+FV//XS7AJMkQ7gAsGLa k8Wp6j+gDwDvl4symScYUHmtPhZxetn4xnl6DBcXykELE9nB1wFUMLQvT3+C3i/tmU6GiX 6VsopLiZsk3SOXPyW11epNj0hVPjA8Q= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HeTBqNE4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666270509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fh5EydRcU3nZz8dXo/oBnTkKwNMvB8kiOApoxijExX8=; b=lOx2CdxxvPunqSWBv/GIg1GJLfPK8rlmsIQ3Sxue7CGqJCfPVw0HFaoPywt3sIqWxnjGzU GnvNxXGTAoDo6QnbtZwJsIDCgdglaCGcXoI7WyCs0M+06V9KyAH7Q04cW/WKJu2p0jXpzY 6rrglXfQY0NvFRzEAIjYTOz9TjpUZaA= X-Rspamd-Queue-Id: E358D20005 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HeTBqNE4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: xwcys3wunjaid66mfymypwixr1i1z36d X-HE-Tag: 1666270508-356800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > + return num_purged_areas > 0 ? true:false; > > The formatting here is a bit off due to the lack of whitespaces around > the :. But as boolean expression propagate to boolean values this > can be simplified to: > > return num_purged_areas > 0; > Good point! Indeed it is odd. -- Uladzislau Rezki