From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB05BC4332F for ; Thu, 20 Oct 2022 11:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 762198E0002; Thu, 20 Oct 2022 07:25:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7127F8E0001; Thu, 20 Oct 2022 07:25:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6014D8E0002; Thu, 20 Oct 2022 07:25:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4DA3E8E0001 for ; Thu, 20 Oct 2022 07:25:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 259C1140BD3 for ; Thu, 20 Oct 2022 11:25:09 +0000 (UTC) X-FDA: 80041096338.03.D98C770 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id C4DDDC0039 for ; Thu, 20 Oct 2022 11:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z5vCg4fZ++9q6ZHqE1Y7XphjIBR9oZaDjLMJARhZK+k=; b=O0ZufuZpwwy7snW5RWWBTuhTXX 6gO9M0z9COPVX0CrjHptxtBtt02xUZmEGSs/Uws9oVB0tRW3oGssLYxh9Lue0iDc+bn24Xhc/Ot0s pK/7M/DqLC/tVfHLDPhqGAY4hPro963EeoBR4Hxpttvwfsgcs6rQ/nyx285tOrlB5v9d3puFR1++T VxuNXWxs48DWZcemmHpKlTGRZSgr9eVrzE1JLEs1SPyzSRcGV+3C1I3o7cxUtfkFMVW9SakWPa6LS LavdPJQjQBJJhGyHU+/LjiYNIlTDLo/X+vXu5vh0epUkSljMH/6yAwe/uWoF3RBQywJqyKZdVGYK+ H2v+dEcg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1olTfe-00E30Z-4R; Thu, 20 Oct 2022 11:25:06 +0000 Date: Thu, 20 Oct 2022 04:25:06 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Steven Rostedt , Oleksiy Avramchenko Subject: Re: [PATCH v2 5/7] mm: vmalloc: Use trace_purge_vmap_area_lazy event Message-ID: References: <20221018181053.434508-1-urezki@gmail.com> <20221018181053.434508-6-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018181053.434508-6-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666265108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z5vCg4fZ++9q6ZHqE1Y7XphjIBR9oZaDjLMJARhZK+k=; b=w7txBeRt+f9NDCBz6rRAIElIsBwXJJwbv5Vd1Z1RIK/6iu4hazjNtAN6RyAzgK8f/TLcZx nQam1Ncp96m7fLV4wFxR6ZBS/VYQzHQuA1tqQttNbuFg1SB3GLBTTZL6+d7ucSOB2B6MbR ZE02yGxnif4zlJp3FmCJDY4WSKmsKHg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=O0ZufuZp; spf=none (imf28.hostedemail.com: domain of BATV+fbbe1fa021964d819d86+6997+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+fbbe1fa021964d819d86+6997+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666265108; a=rsa-sha256; cv=none; b=Bxg6oQ4h13//GOrrEPiDF2HWl1yxJ/wKyyzGhsca+6jxo9+1CArRGPmAkD1LI+s6cq0fT3 GHWSluAbW1VHbCVA/bHuZtZ4My/hW6jTvcmtAVckDicc0/vupnHlg6ZSv/ya2ceScqgZyP zfFH6Z2gyJZW90zJY/vElk7b/Ijnz60= X-Rspamd-Server: rspam12 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=O0ZufuZp; spf=none (imf28.hostedemail.com: domain of BATV+fbbe1fa021964d819d86+6997+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+fbbe1fa021964d819d86+6997+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: 5fdti8x58mkket3zqakp8y9ocpwq15q8 X-Rspamd-Queue-Id: C4DDDC0039 X-HE-Tag: 1666265108-943920 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + return num_purged_areas > 0 ? true:false; The formatting here is a bit off due to the lack of whitespaces around the :. But as boolean expression propagate to boolean values this can be simplified to: return num_purged_areas > 0; anyway. Otherwise looks good: Reviewed-by: Christoph Hellwig