From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41754C433FE for ; Wed, 19 Oct 2022 21:37:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A0CB6B0072; Wed, 19 Oct 2022 17:37:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451126B0073; Wed, 19 Oct 2022 17:37:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F17C6B0074; Wed, 19 Oct 2022 17:37:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F2656B0072 for ; Wed, 19 Oct 2022 17:37:06 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 908F380D83 for ; Wed, 19 Oct 2022 21:37:05 +0000 (UTC) X-FDA: 80039009610.21.FA071BC Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf11.hostedemail.com (Postfix) with ESMTP id 2EEE440015 for ; Wed, 19 Oct 2022 21:37:04 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id n12so31043104wrp.10 for ; Wed, 19 Oct 2022 14:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rQVk2CI7gUTucSPsYsRuO+Xgt/DLnqyh0SKi8lL+BxQ=; b=kEVsf5yva6tPgrJ28OEjDXh5az9gBpktNnS2hvVjuDF+md4bSzDCTm+yLSoP1QbyCF nmvNyXfObeOLojWLCz86IsZhxLuBaicxiZndWHvw9g8EeVbOQMDwRPb40itjjAn8SR60 nETxvBCs7XCrBF7ofuSBIcD8XDwUg25BGJeeyC5neQwRiSrK8XjG/og8YoSeibMcNzI4 cCTvbda7YB4O3z4MsBZokpHXnboje0jgXWsJ9OvWDu7xGKth403zmdIXNWN0mtOmqzln +KYYaS5K402ENk8RVDvJZG3VhziKJuQt0TNA7vm0tPoHTF1iLlFjc3Yzj4q6WncoJYWS 9GmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rQVk2CI7gUTucSPsYsRuO+Xgt/DLnqyh0SKi8lL+BxQ=; b=UotKz2/i6R7yN+C+/97XkxaeQGEuDWRM9A8ziDBdDT0QFnmvYhHFmzb0zQ3CQrkD68 qtGfJvLd0HerMsJ9PZSV+7s1qYcdnr0VEyC019GG1tTcjqS3DYMf5txYOPL/PA0etrQE V1KYykKxcDNB6xijGwU1gAwpkX0Ldb6Z5sCR96m/WYwzjR8DJpri3pvOWa350TODoq5X eYVbFTJS4n6FG9B82GQDgNIpjpjflPzZDL33ehfNnchFOT21RIBS5xb09newgzYM0Nob OXk9fuNktGgTRpNDUjuUzAUPM2d28UVOlJMypYaUn8+U1oetU20ox8jn6j1/IsMD/A5/ ySBQ== X-Gm-Message-State: ACrzQf2L+G6W6wcrQOyF3EayFRxZu3+cSyc/fYhdTNQz6acp1sLT8Yfd ufEeI+8F6qsfYhxt+3VL5kZqxw== X-Google-Smtp-Source: AMsMyM7qopHlpx/0st3r1u+WJ8I0s2s8sNijf+qUWSM5iyTi/IS/3JDBYAUI/Wlvu3L9ZDi6G/UWsw== X-Received: by 2002:a05:6000:1843:b0:22e:77b0:2e5 with SMTP id c3-20020a056000184300b0022e77b002e5mr6255132wri.215.1666215423700; Wed, 19 Oct 2022 14:37:03 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:b751:df72:2e0f:684c]) by smtp.gmail.com with ESMTPSA id g7-20020a05600c4ec700b003c409244bb0sm1236729wmq.6.2022.10.19.14.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 14:37:02 -0700 (PDT) Date: Wed, 19 Oct 2022 23:36:56 +0200 From: Marco Elver To: youling 257 Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Biggers , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Stephen Rothwell , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 18/43] instrumented.h: add KMSAN support Message-ID: References: <20220915150417.722975-19-glider@google.com> <20221019173620.10167-1-youling257@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666215425; a=rsa-sha256; cv=none; b=XM4Hm4mfCb7ge5k65Z1261NUD8CXBaoxGDJPuMCKwd9i/6gVifeTYMCANa9zgefzsAddk1 yURrwihm5KBKKT0AXa/kO+eaScrDLQ6VcuuD11dynSNRKo55+jIyZS6Yjv11XnLulm0XWV 7rWr1V1JaWREt/CSknmSuq0ywmIu8MY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kEVsf5yv; spf=pass (imf11.hostedemail.com: domain of elver@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666215425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rQVk2CI7gUTucSPsYsRuO+Xgt/DLnqyh0SKi8lL+BxQ=; b=QUJEwaHVTi8EEsvD+V0XQHxLdWtodyco+Rkkb3+psWsKjoSWthNjEHU2P5I+56ibNFllU4 cU4+IBWAoNmkTEXWv5NJElTjFqv16y8KsdbEbAgnCYjylAphKIfgKsXXMtOeW0O7M/HPSU QQrg+OXNB/lb0FBysM+m/7OZ90kBXOA= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kEVsf5yv; spf=pass (imf11.hostedemail.com: domain of elver@google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: g56649rt6ot5b8bwshydi5brnz183xrg X-Rspamd-Queue-Id: 2EEE440015 X-Rspamd-Server: rspam10 X-HE-Tag: 1666215424-99379 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 04:07AM +0800, youling 257 wrote: > That is i did,i already test, remove "u64 __tmp…kmsan_unpoison_memory", no help. > i only remove kmsan_copy_to_user, fix my issue. Ok - does only the below work (without the reverts)? diff --git a/include/linux/kmsan-checks.h b/include/linux/kmsan-checks.h index c4cae333deec..eb05caa8f523 100644 --- a/include/linux/kmsan-checks.h +++ b/include/linux/kmsan-checks.h @@ -73,8 +73,8 @@ static inline void kmsan_unpoison_memory(const void *address, size_t size) static inline void kmsan_check_memory(const void *address, size_t size) { } -static inline void kmsan_copy_to_user(void __user *to, const void *from, - size_t to_copy, size_t left) +static __always_inline void kmsan_copy_to_user(void __user *to, const void *from, + size_t to_copy, size_t left) { } ... because when you say only removing kmsan_copy_to_user() (from instrument_put_user()) works, it really doesn't make any sense. The only explanation would be if the compiler inlining is broken.