From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B116C38A02 for ; Sun, 30 Oct 2022 19:45:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 516556B0071; Sun, 30 Oct 2022 15:45:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C6806B0073; Sun, 30 Oct 2022 15:45:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B4A26B0074; Sun, 30 Oct 2022 15:45:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2FFB36B0071 for ; Sun, 30 Oct 2022 15:45:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 029F016038B for ; Sun, 30 Oct 2022 19:45:07 +0000 (UTC) X-FDA: 80078644296.08.73A1538 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 2E57014000A for ; Sun, 30 Oct 2022 19:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667159106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bT5+mtm9SvOiSWB+WL0RWSIeohhjPs4i/ZgPi5EI8zo=; b=PoClh2O51ymkJ5489xkzu+7JK9d3cRC2g34qs5bZO8zQARzP7TQ98l2rCJBR/fkY5cFB3+ vCDGOj5PvuxlZWMqZJMPmfZWVfAAMnue3wdBB111cPeOoexnj+OlYOtW9RMFfMm1rD9O8B GQceIGxVsqSxLbPjTc7NdxZyIiBFuXU= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-511-gGgPAUgLOVCxa5xzdQ-j6A-1; Sun, 30 Oct 2022 15:45:05 -0400 X-MC-Unique: gGgPAUgLOVCxa5xzdQ-j6A-1 Received: by mail-qk1-f197.google.com with SMTP id ay43-20020a05620a17ab00b006fa30ed61fdso139769qkb.5 for ; Sun, 30 Oct 2022 12:45:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bT5+mtm9SvOiSWB+WL0RWSIeohhjPs4i/ZgPi5EI8zo=; b=EwckzT34ysYnusBHjpkfdO3LMm4AVxTgc8LqeIpNea6T4zM83Uxqef7BMH3O4HFgrF dHgfqj5kfl/2nSJ+pXMepLLxp2VIapHVkQUeOeufc3AZMN9EjnRR761+eKkri3c60WDc uzdO9ZJ7IlZxxSg2Wk6nKqxOQvVzZmx1iD3jDMXY0EiSTE7HOc1Pck9j/WaP+txDRfNo Tyo9wQQVToql7A99tYkRzBdTzx85TuJc47V8U7yN4bV3BM/xemMOaAUpmDi3URu2H+UR lxdS3DHqzMPdAApip8s9RRQFv24Ym3Q8+Oz/Kh9NK9DMa4e1JSuUt9TEnx1Q1M4zt8ar 3Psw== X-Gm-Message-State: ACrzQf2GIYrmlwD6e2M4C8yk8/hf8pVRSlyFIXsh8vaQAJaVlaMGKiC/ rOjXOdJfccncy6mNfvBdlri/0iG4Rl29YIQSTw4Helx2aArQqxcRhBSTxjLZY0IoLQSSdtoKFqp 4eaoj3fbkYAg= X-Received: by 2002:ac8:5b05:0:b0:399:9b82:77b4 with SMTP id m5-20020ac85b05000000b003999b8277b4mr7916920qtw.681.1667159104711; Sun, 30 Oct 2022 12:45:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7DGRAbhY7ngHol5WrR3s5q5A6o6BjH1ZsifAnGgA9PVQrmUO3jQvhvJGCv8i15sQG8OQjvCA== X-Received: by 2002:ac8:5b05:0:b0:399:9b82:77b4 with SMTP id m5-20020ac85b05000000b003999b8277b4mr7916896qtw.681.1667159104500; Sun, 30 Oct 2022 12:45:04 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id fu38-20020a05622a5da600b0039953dcc480sm2596227qtb.88.2022.10.30.12.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 12:45:03 -0700 (PDT) Date: Sun, 30 Oct 2022 15:45:02 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, Baolin Wang , Christophe Leroy , David Hildenbrand , "Aneesh Kumar K . V" , Naoya Horiguchi , Michael Ellerman , Muchun Song , Andrew Morton Subject: Re: [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask Message-ID: References: <20221028181108.119432-1-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20221028181108.119432-1-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PoClh2O5; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667159107; a=rsa-sha256; cv=none; b=a3qh+w62UOLma/0we4H6yLYrPWkBJlX+nOzElf2g3nI4yjeYFSSoWF7u+qTHv0Ng4Btdxp Ik1xcgGEiGSNE5TUX8AkamOOZLvWG+OhnQ97ymZ6fJWqibRcXJXtIIR+WntcfQPYw/Ua2G neQdBx69nJA1QpehgRft+6b6Vdl163M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667159107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bT5+mtm9SvOiSWB+WL0RWSIeohhjPs4i/ZgPi5EI8zo=; b=SXiIsaZZManCsO+BqC2uMtQzfMhmlZhZj2lrQW3+QN/aQMLfOwIr09RhKL7eO2lxcji3RO GnXC+S72fKauviP12znsunQBSEiK5CSCIFb4ZM1ReHM34y7ssNUfNZl8M8Qy4ZjNfzK8LM jP8LbvqG7C7bhvl+vIJK0epKkWBu3TA= X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PoClh2O5; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-Stat-Signature: bmwqcj69eie8kw6ggztnakjzaa8yiwc8 X-Rspamd-Queue-Id: 2E57014000A X-HE-Tag: 1667159107-363970 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 28, 2022 at 11:11:08AM -0700, Mike Kravetz wrote: > +struct page *hugetlb_follow_page_mask(struct vm_area_struct *vma, > + unsigned long address, unsigned int flags) > +{ > + struct hstate *h = hstate_vma(vma); > + struct mm_struct *mm = vma->vm_mm; > + unsigned long haddr = address & huge_page_mask(h); > + struct page *page = NULL; > + spinlock_t *ptl; > + pte_t *pte, entry; > + > + /* > + * FOLL_PIN is not supported for follow_page(). Ordinary GUP goes via > + * follow_hugetlb_page(). > + */ > + if (WARN_ON_ONCE(flags & FOLL_PIN)) > + return NULL; > + > +retry: > + pte = huge_pte_offset(mm, haddr, huge_page_size(h)); > + if (!pte) > + return NULL; > + > + ptl = huge_pte_lock(h, mm, pte); > + entry = huge_ptep_get(pte); > + if (pte_present(entry)) { > + page = pte_page(entry) + > + ((address & ~huge_page_mask(h)) >> PAGE_SHIFT); > + /* > + * Note that page may be a sub-page, and with vmemmap > + * optimizations the page struct may be read only. > + * try_grab_page() will increase the ref count on the > + * head page, so this will be OK. > + * > + * try_grab_page() should always succeed here, because we hold > + * the ptl lock and have verified pte_present(). > + */ > + if (WARN_ON_ONCE(!try_grab_page(page, flags))) { > + page = NULL; > + goto out; > + } > + } else { > + if (is_hugetlb_entry_migration(entry)) { > + spin_unlock(ptl); > + hugetlb_vma_unlock_read(vma); Just noticed it when pulled the last mm-unstable: this line seems to be a left-over of v3, while not needed now? > + __migration_entry_wait_huge(pte, ptl); > + goto retry; > + } > + /* > + * hwpoisoned entry is treated as no_page_table in > + * follow_page_mask(). > + */ > + } > +out: > + spin_unlock(ptl); > + return page; > +} -- Peter Xu