From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7ADFA3740 for ; Mon, 31 Oct 2022 11:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AED66B0071; Mon, 31 Oct 2022 07:36:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 137DC6B0073; Mon, 31 Oct 2022 07:36:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1A288E0001; Mon, 31 Oct 2022 07:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C17826B0071 for ; Mon, 31 Oct 2022 07:36:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 467CA140D18 for ; Mon, 31 Oct 2022 11:36:43 +0000 (UTC) X-FDA: 80081042286.13.6FBE3E3 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf26.hostedemail.com (Postfix) with ESMTP id CFF88140037 for ; Mon, 31 Oct 2022 11:36:42 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id b62so74937pgc.0 for ; Mon, 31 Oct 2022 04:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tk8T8KciNnKClZtt9a7oM7hEZLA8ALbiZujS1/Z8e40=; b=G53K5YU2JkveyKH2PbOn8K0UpNz0e894Cw6udPOu0c1h6+GqY5Pr/RdmUwR25EglGo dVr2iMlunxBMeCd7VlrfZ6FOqnpiIkFTAAWFBSl8Q4XAd+oQB/Dplv4mi0fUeni1/VSA f9bFtE4IRkYFEEa7yjr7imth2RhnTy3FvwawI9TSlIxH9uOrI94cDL04KBgGMBLIrtSv AVcKFyn++ITHCwWzIoHXrY5U4c8CXQGTnk6epkRhbjp5ss3lpRisch5j3fh8/oxJbzfE pNIuzd/lzEpSUpEqec7HqJAOVvTAs4uSf3lCBxm1oWnAucIg6xUZ64QAcLjrN52oe2NN ruRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tk8T8KciNnKClZtt9a7oM7hEZLA8ALbiZujS1/Z8e40=; b=c8CByoIVNAyzsFXexNWhQaQwni5EKcfv6PmiV0lckn0LJiDqZGrbhzCMgtnO2udAUX CYlVcXI6igow4dX/fDNcrhr2y+mvkrNNKNA30GUKI9ZjjCSgwSVlSCe1Bbfj1/620LhY fdMBkopaUlQtGEh0wTVdsHpy4fLzXxhPEGiOFWxOpUjdB5gp14D6gxFrFHON2fLxF894 Y9X822CMLF07glF6HL4DKkRsOc7tOPPEZg9/Hn54PAosSkX41WqqHLzEqGaGBsckcukS wv5IAEEC6VQ5vw3ClEOMbLrXTJlMxQUib4i5LumEOyw5Vy+R2y7Zd7ePKPevD0rr9evH UfTA== X-Gm-Message-State: ACrzQf1VSJphpmFG2ME7+jJHuzfGiLG9ceeENyHfiX8HHhuhqm2uaMza XXJ3dKaMpUJ34waabRnp+Zo= X-Google-Smtp-Source: AMsMyM4f8k2ljHcxbiskh8CAxXa8u4HJT5cN8F4TcPs0gPwUvckU0zmHtc1dUz4LmrD1ReEhoFGIeg== X-Received: by 2002:a05:6a00:14cc:b0:56b:9969:823 with SMTP id w12-20020a056a0014cc00b0056b99690823mr13659260pfu.36.1667216201343; Mon, 31 Oct 2022 04:36:41 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id v17-20020aa799d1000000b0056bb191f176sm4526205pfi.14.2022.10.31.04.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 04:36:40 -0700 (PDT) Date: Mon, 31 Oct 2022 20:36:33 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: John Thomson Cc: Feng Tang , Vlastimil Babka , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Dmitry Vyukov , Jonathan Corbet , Andrey Konovalov , "Hansen, Dave" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , Robin Murphy , John Garry , Kefeng Wang Subject: Re: [PATCH v6 1/4] mm/slub: enable debugging memory wasting of kmalloc Message-ID: References: <20220913065423.520159-1-feng.tang@intel.com> <20220913065423.520159-2-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667216202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tk8T8KciNnKClZtt9a7oM7hEZLA8ALbiZujS1/Z8e40=; b=XAbczn9UTAF5Sc/Dd7rHG+a4IR6I6MHp16807b61G7uBeMR3PUSaN4rmT/puJitXNxfUP6 j/Tbi653ZHhi7oQ1gOaym5nLs35leSvVtY3Tl97VbZRVizJIA+wiKhGgVp5ytpPaB5nbur EZ2sBuw50hI17gCawZOPoghoYlbp4IA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G53K5YU2; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667216202; a=rsa-sha256; cv=none; b=JjiDjIMvGXN3THtXOuaFBnqOf9AA6Bo+lEo5gj/T5wOI/8Q6Moe9gq1XOBRtglmIY60Wpc 41h/F5t5e8oj3Sb5Xq0OH483ZRWqdpq7KY0CqGMAtToZa3ounvAe91Mje0LQZtd8w/Xs6L d6rPvPeOpBD8HGI3Iuvvxb3hHAOWOkw= X-Stat-Signature: j4sfwc8rx7ryet9ht1bg87obthd653mc X-Rspamd-Queue-Id: CFF88140037 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G53K5YU2; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1667216202-369851 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 31, 2022 at 10:05:58AM +0000, John Thomson wrote: > On Mon, 31 Oct 2022, at 02:36, Feng Tang wrote: > > Hi John, > > > > Thanks for the bisecting and reporting! > > > > On Mon, Oct 31, 2022 at 05:30:24AM +0800, Vlastimil Babka wrote: > >> On 10/30/22 20:23, John Thomson wrote: > >> > On Tue, 13 Sep 2022, at 06:54, Feng Tang wrote: > >> >> kmalloc's API family is critical for mm, with one nature that it will > >> >> round up the request size to a fixed one (mostly power of 2). Say > >> >> when user requests memory for '2^n + 1' bytes, actually 2^(n+1) bytes > >> >> could be allocated, so in worst case, there is around 50% memory > >> >> space waste. > >> > > >> > > >> > I have a ralink mt7621 router running Openwrt, using the mips ZBOOT kernel, and appear to have bisected > >> > a very-nearly-clean kernel v6.1rc-2 boot issue to this commit. > >> > I have 3 commits atop 6.1-rc2: fix a ZBOOT compile error, use the Openwrt LZMA options, > >> > and enable DEBUG_ZBOOT for my platform. I am compiling my kernel within the Openwrt build system. > >> > No guarantees this is not due to something I am doing wrong, but any insight would be greatly appreciated. > >> > > >> > > >> > On UART, No indication of the (once extracted) kernel booting: > >> > > >> > transfer started ......................................... transfer ok, time=2.01s > >> > setting up elf image... OK > >> > jumping to kernel code > >> > zimage at: 80BA4100 810D4720 > >> > Uncompressing Linux at load address 80001000 > >> > Copy device tree to address 80B96EE0 > >> > Now, booting the kernel... > >> > >> It's weird that the commit would cause no output so early, SLUB code is > >> run only later. > > > > I noticed your cmdline has console setting, could you enable the > > earlyprintk in cmdline like "earlyprintk=ttyS0,115200" etc to see > > if there is more message printed out. > > Still nothing from vmlinux with earlykprint on UART unless revert. > > > > > Also I want to confirm this is a boot failure and not only a boot > > message missing. > > Yes, boot failure. > Network comes up automatically on successful boot. Not happening when no kernel UART It is really weird that I see no boot issue on my MIPS emulation with almost same config, with different target - Malta board that QEMU supports. it just boot fine. Can you attach debugger to the board? (Which I hadn't tried. I had tried it only to QEMU) [...] > >> > > >> > > >> > possibly relevant config options: > >> > grep -E '(SLUB|SLAB)' .config > >> > # SLAB allocator options > >> > # CONFIG_SLAB is not set > >> > CONFIG_SLUB=y > >> > CONFIG_SLAB_MERGE_DEFAULT=y > >> > # CONFIG_SLAB_FREELIST_RANDOM is not set > >> > # CONFIG_SLAB_FREELIST_HARDENED is not set > >> > # CONFIG_SLUB_STATS is not set > >> > CONFIG_SLUB_CPU_PARTIAL=y > >> > # end of SLAB allocator options > >> > # CONFIG_SLUB_DEBUG is not set > >> > >> Also not having CONFIG_SLUB_DEBUG enabled means most of the code the > >> patch/commit touches is not even active. > >> Could this be some miscompile or code layout change exposing some > >> different bug, hmm. > > Yes, it could be. What happens with clang? > > >> Is it any different if you do enable CONFIG_SLUB_DEBUG ? > > No change > > >> Or change to CONFIG_SLAB? (that would be really weird if not) > > This boots fine > > > I haven't found any clue from the code either, and I compiled > > kernel with the config above and tested booting on an Alder-lake > > desktop and a QEMU, which boot fine. > > > > Could you provide the full kernel config and demsg (in compressed > > format if you think it's too big), so we can check more? > > Attached > > > Thanks, > > Feng > > vmlinux is bigger, and entry point is larger (0x8074081c vs 0x807407dc revert vs 0x8073fcbc), > so that may be it? Or not? > revert + SLUB_DEBUG + SLUB_DEBUG_ON is bigger still, but does successfully boot. > vmlinux entry point is 0x8074705c > > > transfer started ......................................... transfer ok, time=2.01s > setting up elf image... OK > jumping to kernel code > zimage at: 80BA4100 810D6FA0 > Uncompressing Linux at load address 80001000 > Copy device tree to address 80B9EEE0 > Now, booting the kernel... > [ 0.000000] Linux version 6.1.0-rc2 (john@john) (mipsel-openwrt-linux-musl-gc > c (OpenWrt GCC 11.3.0 r19724+16-1521d5f453) 11.3.0, GNU ld (GNU Binutils) 2.37) > #0 SMP Fri Oct 28 03:48:10 2022 > > > I will keep looking. > > Thank you, > -- > John Thomson -- Thanks, Hyeonggon