From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995A4C38A02 for ; Mon, 31 Oct 2022 08:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22F6D6B0071; Mon, 31 Oct 2022 04:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E05F6B0073; Mon, 31 Oct 2022 04:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A80F6B0074; Mon, 31 Oct 2022 04:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D55B56B0071 for ; Mon, 31 Oct 2022 04:43:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 81718AB114 for ; Mon, 31 Oct 2022 08:43:41 +0000 (UTC) X-FDA: 80080606242.18.4E4732F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id E166A20017 for ; Mon, 31 Oct 2022 08:43:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5C1BB80C68; Mon, 31 Oct 2022 08:43:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06681C433D6; Mon, 31 Oct 2022 08:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667205817; bh=ZORsrJ+DI1lsCWe5MTS/iD4Fym79i/CO9pTJG5NNgoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HGtiO1rrn5fISj2g8SbzKS1L2IFtrZ/5xVFdNzxLGc+il2TvvlrPA1ieXr1hxYo4D f2p5Nwk/NuJxY3a5+YVakaNeS0V6VtA+k0EHwGDF9sw/MU49Ag2sFoE9Nt0lOhsAqO 774reLOCQpQZmJE0Rg43U+VqKhWdGLDS9JG+lvgG3dsMrNd641kpQqtQJxGGuSqtaU inEwhnR4TM3ARuYXW39pbmC5p2+zmmeVFAkJnre7drgOhPHwE11mRDJlyD650C3oPn HS8QwoM7xDROPlj83JLVmSBZLJX9brCgCuBP2wqOtVUybNX3uW086ny89Q03qM0XQV O6pbOsMgj9bHg== Date: Mon, 31 Oct 2022 10:43:24 +0200 From: Mike Rapoport To: Rebecca Mckeever Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v3 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw Message-ID: References: <20221031050006.GA15612@sophie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031050006.GA15612@sophie> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667205821; a=rsa-sha256; cv=none; b=cjCMOJIyaDNllkQhVqOXCKmkB5Usb3lf9XmKl32GB1C3A6c8OunjxesjJJ8JIVoKmgdMXG sRdf5nKL96cN5k0TFnrolBGGDxjXlFmw0s4ogstHtr77o5Jl5DpAeYG4vImpfuSwLUHPum ILTNY/mNIqqJyZb2CJB9bDVk+wSCsso= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HGtiO1rr; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667205821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5UH1oBrSIx2KDftSmkyNbqV4WrfdQ7dCMKfxLng0i7c=; b=qJik7jgPX5vrz1uX4e44MDzgnX/+/KaDxUrh+3E7KCReyFGBwu7zBhKUkq3N3Oesz/ul8I at+A2qvK3O1OGEenbbPlUpwtWqMP+lct3juc1MWQW4PQxSANNPtn8PuKzm6P4n5bN6GTYb T2UFX3o7CZECvl04N/BE4oPhk36o+Dg= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HGtiO1rr; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E166A20017 X-Stat-Signature: fhefaoeeor45bzeki71kebag9mwndk4t X-Rspam-User: X-HE-Tag: 1667205820-322119 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Rebecca, On Mon, Oct 31, 2022 at 12:00:06AM -0500, Rebecca Mckeever wrote: > Hi Mike, > > I noticed that the memblock tree has been updated since I sent this > patch set. Do you want me to send an updated patch set applied on top of > the current tree? No need, the only actual conflict is in TODO, I'll fix it while applying. > On Wed, Oct 19, 2022 at 01:34:07PM -0500, Rebecca Mckeever wrote: > > These patches add tests for memblock_alloc_exact_nid_raw(). There are two > > sets of tests: range tests and NUMA tests. The range tests use a normal > > (i.e., UMA) simulated physical memory and set the nid to NUMA_NO_NODE. The > > NUMA tests use a simulated physical memory that is set up with multiple > > NUMA nodes. Additionally, most of the NUMA tests set nid != NUMA_NO_NODE. > > > > For the range tests, the TEST_F_EXACT flag is used to run the same set of > > range tests used for memblock_alloc_try_nid_raw(). The NUMA tests have the > > same setup as the corresponding test for memblock_alloc_try_nid_raw(), but > > several of the memblock_alloc_exact_nid_raw() tests fail to allocate > > memory in setups where the memblock_alloc_try_nid_raw() test would > > allocate memory. Also, some memblock_alloc_exact_nid_raw() tests drop the > > lower limit of the requested range in order to allocate within the > > requested node, but the same setup in a memblock_alloc_try_nid_raw() test > > allocates within the requested range. > > > > --- > > Changelog > > > > v1 -> v2 > > PATCH 0: > > - Add missing memblock_alloc_exact_nid_raw to subject line > > > > v2 -> v3 > > Based on feedback from David Hildenbrand: > > PATCH 1: > > - alloc_nid_api.c, alloc_nid_api.h, common.h: > > + Add TEST_F_EXACT flag so that tests in alloc_nid_api.c can be run > > with that flag to test memblock_alloc_exact_nid_raw() > > - alloc_exact_nid_api.c: > > + Update to run range tests in alloc_nid_api.c with TEST_F_EXACT flag > > instead of using a separate set of tests > > - alloc_nid_api.c: > > + Rename tests and other functions by removing "_try" so that the > > function names are general enough to refer to any of the > > memblock_alloc_*nid*() functions of the memblock API > > --- > > > > Rebecca Mckeever (5): > > memblock tests: introduce range tests for memblock_alloc_exact_nid_raw > > memblock tests: add top-down NUMA tests for > > memblock_alloc_exact_nid_raw > > memblock tests: add bottom-up NUMA tests for > > memblock_alloc_exact_nid_raw > > memblock tests: add generic NUMA tests for > > memblock_alloc_exact_nid_raw > > memblock tests: remove completed TODO item > > > > tools/testing/memblock/Makefile | 2 +- > > tools/testing/memblock/TODO | 7 +- > > tools/testing/memblock/main.c | 2 + > > .../memblock/tests/alloc_exact_nid_api.c | 1113 +++++++++++++++++ > > .../memblock/tests/alloc_exact_nid_api.h | 25 + > > tools/testing/memblock/tests/alloc_nid_api.c | 542 ++++---- > > tools/testing/memblock/tests/alloc_nid_api.h | 1 + > > tools/testing/memblock/tests/common.h | 2 + > > 8 files changed, 1425 insertions(+), 269 deletions(-) > > create mode 100644 tools/testing/memblock/tests/alloc_exact_nid_api.c > > create mode 100644 tools/testing/memblock/tests/alloc_exact_nid_api.h > > > > -- > > 2.25.1 > > > Thanks, > Rebecca -- Sincerely yours, Mike.