From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F1C1C38A02 for ; Mon, 31 Oct 2022 08:17:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B48A6B0071; Mon, 31 Oct 2022 04:17:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 464536B0073; Mon, 31 Oct 2022 04:17:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32BF06B0074; Mon, 31 Oct 2022 04:17:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 060BB6B0071 for ; Mon, 31 Oct 2022 04:17:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2BB39160B50 for ; Mon, 31 Oct 2022 08:17:08 +0000 (UTC) X-FDA: 80080539336.18.148A60A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id 5A8DE80038 for ; Mon, 31 Oct 2022 08:17:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79465B81205; Mon, 31 Oct 2022 08:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66D6DC433B5; Mon, 31 Oct 2022 08:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667204224; bh=URxGX3rN0t4vDzNmnpRLGdtDfedX1xDpndmmWDxKjO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gtizLyWTlicoIYLxEUip8appSngpFlGx70dK3zqlq3RovHYO7gKMpOQ4Mh5qXatxT LxEjp3/8Ndfqq6sCyMkIMc+2pk6Ds24u1eP0qb+/sHcWOTnq6kqFPeI1oUXN4ll+Fe vnMIUqPTjV6MzSAw5o0wMrNbEBEVPA0g+V2YbzqkF+KJa1AuOO8OPTt+Edd6K4Cgoo HB/ayGS9vDJnW5BIF9laUa8v6ZlPvSSO2hdCg6Cfk8VR89TPEfvu+bSwcEbIRbTWsd CokEf+FfcdErmqBzG3zdHwUSdBEnxzh1yY7nze9g4gzDI13JP4WdXp1D6MUCtakIEF Ex6+5XlAdWysQ== Date: Mon, 31 Oct 2022 10:16:51 +0200 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memblock: don't run loop in memblock_add_range() twice Message-ID: References: <20221025070943.363578-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221025070943.363578-1-yajun.deng@linux.dev> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667204227; a=rsa-sha256; cv=none; b=XLKXsch9SOi60/0CfgOILk9UhXCIHLtIotnz5pL1rXV3Un8JvYR4n3Uk1DLNShZR9jvxfV uNv/LF1MduaMG90WkRGbn1E4Z07xooN+Cs9iv6y174OBNe94M281rPTeb8krCzsGQMAJr0 hz98hGO4vwJqIUUC+uFW1Ui/q7cBdg8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gtizLyWT; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667204227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UPxd9YIcwKoWFvFO3Ziiw65Cff8xvEY90OLdTe087Bs=; b=RnCPkqrmWDl+KwLR68HsL8TFTIs6yX4hpC5NYDglw0gTLb2desi5rCMVL7iZqoTUZ885ng Hk+opn0MI8hLGiKVu34vqb7vfDrVp5QlemKOny6zBfUPa/3du31WHRui4NdNoMG5y0t1+g adrTsaYL7X+zDwv3wbEbTYKob90MJKw= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5A8DE80038 X-Rspam-User: X-Stat-Signature: wze6jxffoh7zm5j5ziidqmm5xai1upjy Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gtizLyWT; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1667204227-802943 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002446, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 03:09:43PM +0800, Yajun Deng wrote: > There is no need round twice in memblock_add_range(). > > We can call memblock_double_array() to extend the size if type->cnt > greater or equal to type->max before memblock_insert_region(); otherwise, > we can insert the new region directly. > > v2: > - Add a comment when the allocation is required. > > Signed-off-by: Yajun Deng > --- > mm/memblock.c | 69 ++++++++++++++++++--------------------------------- > 1 file changed, 24 insertions(+), 45 deletions(-) Applied, thanks!