From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A0DFFA3741 for ; Mon, 31 Oct 2022 14:14:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD0E66B0071; Mon, 31 Oct 2022 10:14:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C59D96B0073; Mon, 31 Oct 2022 10:14:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFB4D6B0074; Mon, 31 Oct 2022 10:14:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 85F896B0071 for ; Mon, 31 Oct 2022 10:14:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 214A380D24 for ; Mon, 31 Oct 2022 14:14:44 +0000 (UTC) X-FDA: 80081440488.23.606ECA1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id AF3B64004A for ; Mon, 31 Oct 2022 14:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667225683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LTs94zq/shOCy359RmNZp+4/qUMkgxFrS5T5YTdFLQE=; b=iadQHgxjWA4nOg4uP/1tWX9jxran0mRwmZw+3tdbMepB97epsMXjVDvj9ORfAaNWN3ME70 W9gMfmy19CEvcAlqlGdc27JizvSyPxklnwqtbvwFRZ924SQE97d1TjnsKfJ4PUwNmjaGf6 YjsX6nILAZlMqYrYUGUI/6I748UKxfE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-656-2iq7cH3ZMgSCDz31-bNIrQ-1; Mon, 31 Oct 2022 10:14:41 -0400 X-MC-Unique: 2iq7cH3ZMgSCDz31-bNIrQ-1 Received: by mail-qv1-f72.google.com with SMTP id g12-20020a0cfdcc000000b004ad431ceee0so5811324qvs.7 for ; Mon, 31 Oct 2022 07:14:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LTs94zq/shOCy359RmNZp+4/qUMkgxFrS5T5YTdFLQE=; b=WU8yc0RLDXVlSpdqpNj/tpvhY41sWL/SXm4WUdI6vIMN1E0n4cl7s7NkIA9+AAlApE 1DOUe0Lu1Mc/bYZ2ijPmmAdLmZsLQ5IOhV4tXJu6k9MFysfCE2cyai6Nd076WkCvNKxM e1RsYo9Xpd6p86LD7fP9+r4r5ZbYd5hxv5Yo8xWJdgyi+NGyVECgI4U7BCG2CKLmjFTE AZM3UfK7SJKzmdt8HqA10lYuq6Jea/4UWSO88KnGf7pIRRMjqoUfcLAkI2700EKbEhfF M/at8z0bvuGB8EDKGkeZ0FPYOKc8e7kLk15z0DadiIjer6ilcfxurTVvy+P0Iol+UoEv AaJw== X-Gm-Message-State: ACrzQf0zQdc9xJuFnUbTT4k7MN2Pisyn0ozEu8EejgTXQvHqp22emJt4 l8Zfb8kYkihNzyvlLPMjLoLPKsWAN8AsAbXKeQAKQxCH35aDxsZe/GF/wYjgOdsDErVclOqWDtM DQcgx8an+zA8= X-Received: by 2002:a05:620a:215e:b0:6e7:dafb:a71a with SMTP id m30-20020a05620a215e00b006e7dafba71amr9315730qkm.61.1667225681459; Mon, 31 Oct 2022 07:14:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7bVyEw/34BP+lHFL+RXtnVPg+QNYFQTs2hEwQOQ7unwXixqknY5SeloWiMVBGh7TYvquRTlw== X-Received: by 2002:a05:620a:215e:b0:6e7:dafb:a71a with SMTP id m30-20020a05620a215e00b006e7dafba71amr9315706qkm.61.1667225681219; Mon, 31 Oct 2022 07:14:41 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id h4-20020a05620a284400b006b615cd8c13sm4665283qkp.106.2022.10.31.07.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 07:14:40 -0700 (PDT) Date: Mon, 31 Oct 2022 10:14:39 -0400 From: Peter Xu To: "Huang, Ying" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Miaohe Lin , David Hildenbrand , HORIGUCHI NAOYA , Andrea Arcangeli Subject: Re: [PATCH 0/2] mm: Use pte marker for swapin errors Message-ID: References: <20221030214151.402274-1-peterx@redhat.com> <87h6zkepog.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <87h6zkepog.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iadQHgxj; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667225683; a=rsa-sha256; cv=none; b=Bu6ohtsDDmFGq9y2JGF8NoEjoeVYHPDj5LjkazA/WggYPxhD9wzBO/QrFxtSEe94b2xuxw my9fzbwUWyaSWoHHm8h2FgimSNyBe39VYSgXgH1Uh5wvQ8EKOcOAOwoK0gxistO3fEgxUv sq3hk6Y9i9I6auycvYPXzuqr0jAFbn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667225683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LTs94zq/shOCy359RmNZp+4/qUMkgxFrS5T5YTdFLQE=; b=msyrsqYt4pW3Zq+5mmTSXDCK0V2SKsHAhjxr0feVLPOPpP6zI0t8tJ7ceWu+9ZFk4QgbUS WNAWOokJamb6mmrW9DVk7Hy+TB0tNhzx36TNIhwOXQ4dNAW+YTqlEfw0lcR09YIIGxvDvu Nls9j2yBAMKqxIasEkeA26Q7q5jpDF8= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iadQHgxj; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-Stat-Signature: zy5s453u55wq9g3pkh9xrux9myqwp5ke X-Rspamd-Queue-Id: AF3B64004A X-HE-Tag: 1667225683-868714 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 31, 2022 at 09:40:15AM +0800, Huang, Ying wrote: > Peter Xu writes: > > > rfc->v1: > > - Rename SWAP_ERROR -> SWAPIN_ERROR [David, Miaohe] > > - Added r-bs for Ying and Miaohe > > > > Hi, > > > > This series uses the pte marker to replace the swapin error swap entry, > > then we save one more swap entry slot for swap devices. A new pte marker > > bit is defined. > > Per my understanding, "swap entry" describes one swap page (4KB on x86) > in one swap device. So, the original swapin error implementation uses > one swap file (or swap device) instead of one swap entry. So your patch > saves one swap file (or swap device). Yeah I was definitely not accurate enough, I wanted to use "slot" to mean "type" here but obviously I didn't make it, sorry. Hopefully the whole patchset is still clear enough anyway so no reader will get confused by it. -- Peter Xu