From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D04C4332F for ; Fri, 14 Oct 2022 23:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28BED6B0072; Fri, 14 Oct 2022 19:48:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23A976B0075; Fri, 14 Oct 2022 19:48:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DB136B0078; Fri, 14 Oct 2022 19:48:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF2626B0072 for ; Fri, 14 Oct 2022 19:48:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A83F71A0A31 for ; Fri, 14 Oct 2022 23:48:51 +0000 (UTC) X-FDA: 80021197662.19.D383AE0 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 201D0140030 for ; Fri, 14 Oct 2022 23:48:50 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id i3so6244503pfk.9 for ; Fri, 14 Oct 2022 16:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9QZI/RqGnedzhVKRkdDMdjD3VHFiD/WtMgGFjHrwV9E=; b=KnSdxaaGLSvkI99TvIbrbSUUvmAOAxfEqbL+31ZrkN1Gfp0YkJGkOui74tPIAh0NgT LLq/dGPuaCoO9WLeNv+a2y/xtSHpzCWI36EJMYq6k3DGpgsukzAzHZK+QrLLcYrxK8/W OeSrP/U8trz4hvqKw+cb/WMsaum9QXzDw92B9Iut+j5+V3qaYmq2hqn9y1wx7r0kQVl5 lDvS+o91ObQJ35vlSjpnel2jF8H3mZUFUj0o7cljURAnvW0vg06YfDJPb4XkksJYwsQ8 21AK2tB0bCX6iYQQGTVQ/mR7SSFEZYfOfUBp6wuM6q2O9h9bmMBfNLlBh9hs6usglABE n9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9QZI/RqGnedzhVKRkdDMdjD3VHFiD/WtMgGFjHrwV9E=; b=PjMD4p4KmmX7eBmARfW9Tp8UHcNzUuvECYkFP+COhS2jCCEApgw0XZ+4/3PBcqlh1o F7EKyUiKW5BcTKVZLtLNKtFTR8HeJvCKRGqkbFZuIlg7LJJhUMYrDlEsEURP1eIVlxGJ vLmeAqYRI3GvvQCekJHGcGAatht/JTgF8pKwK9aA/XhEXLoM+VO1k4LlVxkVQCeednZZ 6MUkhDqvr0oPoikh3Z4Ty13Y+OrG2ZQeCBsUwWsFLkwZpgbgeyQsrgCTry5PgNYCS9D3 OBh6T/uGTn1vvqhAWblqySXx3VZGxwl3lvwJCIhTTOyx6tTndJnUY3oMs19K4qRW6/WG R1IQ== X-Gm-Message-State: ACrzQf21s91cn29NCc89KPo9s3zQN67xTzPUn1Fna73N9IF9CcihsZgR nJDBzQfCr/1V/yq672DVHT4= X-Google-Smtp-Source: AMsMyM4gRZUkhS+sXJU511zMUbOxhDdsWoimzJmbCC2Z+UHp8Qo/CauVmIxAS4NYnTU3evUQPnNDCg== X-Received: by 2002:a63:91c9:0:b0:459:ca3:7245 with SMTP id l192-20020a6391c9000000b004590ca37245mr337385pge.94.1665791329912; Fri, 14 Oct 2022 16:48:49 -0700 (PDT) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id 73-20020a63064c000000b0043c732e1536sm1934836pgg.45.2022.10.14.16.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 16:48:48 -0700 (PDT) Date: Sat, 15 Oct 2022 08:48:43 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Guenter Roeck Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 10/17] mm/slab: kmalloc: pass requests larger than order-1 page to page allocator Message-ID: References: <20220817101826.236819-1-42.hyeyoo@gmail.com> <20220817101826.236819-11-42.hyeyoo@gmail.com> <20221014205818.GA1428667@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221014205818.GA1428667@roeck-us.net> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665791331; a=rsa-sha256; cv=none; b=XYlKe61DtVClCScXFg9Lk4qp8S6RJG/vXx5sKETtS9xfeuoX8iKaCii8KdXusWOYUYdEQu Z07trsPt0QO26SoWRrCFajCFyUcSZiSgZ7iRwvsu3C1xXsUiKj03vgc6sRVo+2DIXwXAbz SLhSH2/jJEeA8jGiBxLWShabvGKs3LI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KnSdxaaG; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665791331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9QZI/RqGnedzhVKRkdDMdjD3VHFiD/WtMgGFjHrwV9E=; b=VX0YFh3ygTlXQ2lXAxgZUWW5mQXyjNoE5gQWlBbkS913z6bT06Efxt/3NxJqY3KXKIpT7x 05VWTDYl4HX0kfQW7MnnTEha3Q1oer5OPbPLBnUNRWziVAEYeqC+yLHA1y+mG8SLVrAPas Ssq8GhFBFUNf76dIiAZwedWyvQcHit4= X-Stat-Signature: mt7jozfh14g1dwx1cmuowj1u6nuq1syu X-Rspamd-Queue-Id: 201D0140030 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KnSdxaaG; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-HE-Tag: 1665791330-280799 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 14, 2022 at 01:58:18PM -0700, Guenter Roeck wrote: > Hi, > > On Wed, Aug 17, 2022 at 07:18:19PM +0900, Hyeonggon Yoo wrote: > > There is not much benefit for serving large objects in kmalloc(). > > Let's pass large requests to page allocator like SLUB for better > > maintenance of common code. > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Reviewed-by: Vlastimil Babka > > --- > > This patch results in a WARNING backtrace in all mips and sparc64 > emulations. > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 0 at mm/slab_common.c:729 kmalloc_slab+0xc0/0xdc > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 6.0.0-11990-g9c9155a3509a #1 > Stack : ffffffff 801b2a18 80dd0000 00000004 00000000 00000000 81023cd4 00000000 > 81040000 811a9930 81040000 8104a628 81101833 00000001 81023c78 00000000 > 00000000 00000000 80f5d858 81023b98 00000001 00000023 00000000 ffffffff > 00000000 00000064 00000002 81040000 81040000 00000001 80f5d858 000002d9 > 00000000 00000000 80000000 80002000 00000000 00000000 00000000 00000000 > ... > Call Trace: > [<8010a2bc>] show_stack+0x38/0x118 > [<80cf5f7c>] dump_stack_lvl+0xac/0x104 > [<80130d7c>] __warn+0xe0/0x224 > [<80cdba5c>] warn_slowpath_fmt+0x64/0xb8 > [<8028c058>] kmalloc_slab+0xc0/0xdc > > irq event stamp: 0 > hardirqs last enabled at (0): [<00000000>] 0x0 > hardirqs last disabled at (0): [<00000000>] 0x0 > softirqs last enabled at (0): [<00000000>] 0x0 > softirqs last disabled at (0): [<00000000>] 0x0 > ---[ end trace 0000000000000000 ]--- > > Guenter Hi. Thank you so much for this report! Hmm so SLAB tries to find kmalloc cache for freelist index array using kmalloc_slab() directly, and it becomes problematic when size of the array is larger than PAGE_SIZE * 2. Will send a fix soon. -- Thanks, Hyeonggon