From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43586C4332F for ; Thu, 13 Oct 2022 14:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A056B0071; Thu, 13 Oct 2022 10:31:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CA3A8E0001; Thu, 13 Oct 2022 10:31:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843C06B0074; Thu, 13 Oct 2022 10:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74F166B0071 for ; Thu, 13 Oct 2022 10:31:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1E5BE1C263E for ; Thu, 13 Oct 2022 14:31:58 +0000 (UTC) X-FDA: 80016165558.16.EB33262 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id 0D3EC180029 for ; Thu, 13 Oct 2022 14:31:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 957D321BBD; Thu, 13 Oct 2022 14:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1665671515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8MHXO/VcwDd2Zl4hT/pNxqi1pKywIsb48dxy9NcH1w0=; b=o/9xIdbPAnQcVAEW8DeoieMLQecxGY4CNEkADiXkB+zytkQa4HjiqtdCTTSP789AP7MPbG C6PUbGtMJ8CluFdLwNIfpf1ESrIpbkIet7pNyZvVjbPRGKFl3eUV0AmnoA3r6+c2a0KayO XSujkWskoPxIJG5Q0MZEsy755tC5uew= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1665671515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8MHXO/VcwDd2Zl4hT/pNxqi1pKywIsb48dxy9NcH1w0=; b=rP/0aiCDVD8XDyVFAO4zYC01A4sydphKpL5r6s0v+aSlKmIg39vx9N1iuxZhhbijmxYDQc nkpaCPhpAi/jAJAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0F23139F3; Thu, 13 Oct 2022 14:31:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qaqQM1ohSGMRXAAAMHmgww (envelope-from ); Thu, 13 Oct 2022 14:31:54 +0000 Date: Thu, 13 Oct 2022 16:31:53 +0200 From: Oscar Salvador To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Miaohe Lin , David Hildenbrand , Mike Kravetz , Yang Shi , Muchun Song , Jane Chu , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/4] mm/hwpoison: move definitions of num_poisoned_pages_* to memory-failure.c Message-ID: References: <20221007010706.2916472-1-naoya.horiguchi@linux.dev> <20221007010706.2916472-3-naoya.horiguchi@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221007010706.2916472-3-naoya.horiguchi@linux.dev> ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="o/9xIdbP"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="rP/0aiCD"; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665671517; a=rsa-sha256; cv=none; b=4aXOwv+XFpby4sRr40RC+lWlEKwSdiWTJx3jp2i1NCRSWI4WeQNa45xbBgXJNjo+17pDxD BXY7R7UHjVNEOdt5mCCIGmamW+D0Ff5v3ENo108g5+KRR1JRS4s9IZ6Cd1JfLqvbPE67YQ gGUBw0YwmXYCc002Nx5q4B64rWZNnPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665671517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8MHXO/VcwDd2Zl4hT/pNxqi1pKywIsb48dxy9NcH1w0=; b=bJG3Kt3Y832rKTgxJ4RqtcL34DGbp/e/QGlCcjBtEMwww3dIJeIbaKNEn0IKjuV6AqDGmw VIQkQFH0cygeAyFJgX38OUmxGQXbYavjpiQNc5STVvII9JtZyWu6qz6UEq4mTCB7LJ0A1E +rT0Hs4aaPU0WbE+PXlULiBsWJZSZi4= X-Rspamd-Server: rspam05 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="o/9xIdbP"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="rP/0aiCD"; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Stat-Signature: xo9ad8crqt3dnp4mnjjejytaa5uzknki X-Rspamd-Queue-Id: 0D3EC180029 X-HE-Tag: 1665671516-485955 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 07, 2022 at 10:07:04AM +0900, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > These interfaces will be used by drivers/base/memory.c by later patch, so as a > preparatory work move them to more common header file visible to the file. > > Signed-off-by: Naoya Horiguchi > Reviewed-by: Miaohe Lin > --- > ChangeLog v3 -> v6: > - remove static in definition of num_poisoned_pages_inc() to fix build error. > > ChangeLog v2 -> v3: > - added declaration of num_poisoned_pages_inc() in #ifdef CONFIG_MEMORY_FAILURE > --- > arch/parisc/kernel/pdt.c | 3 +-- > include/linux/mm.h | 5 +++++ > include/linux/swapops.h | 24 ++---------------------- > mm/memory-failure.c | 10 ++++++++++ > 4 files changed, 18 insertions(+), 24 deletions(-) > > diff --git a/arch/parisc/kernel/pdt.c b/arch/parisc/kernel/pdt.c > index e391b175f5ec..fdc880e2575a 100644 > --- a/arch/parisc/kernel/pdt.c > +++ b/arch/parisc/kernel/pdt.c > @@ -18,8 +18,7 @@ > #include > #include > #include > -#include > -#include > +#include I am probably missing something. num_poisoned_pages_* functions are in swapops.h, but why are you removing swap.h as well? Also, reading the changelog it sounded like both functions would be in mm.h, but actually only the _inc part is. The rest looks good to me. -- Oscar Salvador SUSE Labs