From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A49C4167E for ; Thu, 13 Oct 2022 16:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B297D6B0074; Thu, 13 Oct 2022 12:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB1216B0075; Thu, 13 Oct 2022 12:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 952BE6B0078; Thu, 13 Oct 2022 12:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 837B06B0074 for ; Thu, 13 Oct 2022 12:21:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 54741AAA03 for ; Thu, 13 Oct 2022 16:21:36 +0000 (UTC) X-FDA: 80016441792.16.5A84B5D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id AE66AA0027 for ; Thu, 13 Oct 2022 16:21:34 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A34AAB81F3E; Thu, 13 Oct 2022 16:21:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5671C433D6; Thu, 13 Oct 2022 16:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1665678086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kPntWr7A6bA616PExnbnx5reDbccdV4V+F7u1oTVbdw=; b=GP4P33GoTZTXwgHWO1z/FqyjryY8qsqfXNBCumID69G06rmzAbuflrmGXm0knLxOwy6AOV r5Se8is8rcJ8teWZq2zoRDvfJGTZawQk7FulxMoGHupIBrT9us1rnRt6jRmg3GIbXoJ/w6 20UjSRmQn/6S5nyrDvb7rvSacSvCVHE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5f752f1b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 13 Oct 2022 16:21:25 +0000 (UTC) Date: Thu, 13 Oct 2022 10:21:18 -0600 From: "Jason A. Donenfeld" To: Rolf Eike Beer Cc: Florian Westphal , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrew Morton , Herbert Xu , Thomas Graf , kasan-dev@googlegroups.com, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible Message-ID: References: <20221010230613.1076905-1-Jason@zx2c4.com> <3026360.ZldQQBzMgz@eto.sf-tec.de> <20221013101635.GB11818@breakpoint.cc> <11986571.xaOnivgMc4@eto.sf-tec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <11986571.xaOnivgMc4@eto.sf-tec.de> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665678095; a=rsa-sha256; cv=none; b=vUsBT36Gp5xYb1khXpqtxLuRSVM3YaCT3vBewSYVf+MY43YbD/yfKOQ9zFAmn94pW1ssO/ IIB4bjs9o4nV5cgPePW74SvZeaCINACdeFRdGOjVBSBoDO1y4kE0AKo47/HC6J7gYd3Hgb uQ4nIKe7LGlEeb2qEoQwoR7lht/8dsA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=GP4P33Go; spf=pass (imf25.hostedemail.com: domain of "SRS0=NJAZ=2O=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=NJAZ=2O=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665678095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kPntWr7A6bA616PExnbnx5reDbccdV4V+F7u1oTVbdw=; b=nsl2UGlBZFlJZdLXvufWhN4T9nSZv0YFtnSaWMU0puH9A+JVubvwcnRX/o1XS9JJbp1iq2 EltSGhRv3APLPZ5buM7emfGl3UvL76gqquh3NiKyzcmy+Pj9krBMPS+vvPiR9Yy1/qcUC5 0FbKjI6l7/SEyuqvytobsOcm1umR61g= X-Stat-Signature: zn949jafxqbkw8kpn5yt88f656jg7hhj X-Rspamd-Queue-Id: AE66AA0027 X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=GP4P33Go; spf=pass (imf25.hostedemail.com: domain of "SRS0=NJAZ=2O=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=NJAZ=2O=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com X-HE-Tag: 1665678094-117541 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 13, 2022 at 01:40:40PM +0200, Rolf Eike Beer wrote: > Am Donnerstag, 13. Oktober 2022, 12:16:35 CEST schrieb Florian Westphal: > > Rolf Eike Beer wrote: > > > Florian, can you comment and maybe fix it? > > > > Can't comment, do not remember -- this was 5 years ago. > > > > > Or you wanted to move the variable before the loop and keep the random > > > state between the loops and only reseed when all '1' bits have been > > > consumed. > > Probably. No clue, best to NOT change it to not block Jasons series and > > then just simplify this and remove all the useless shifts. > > Sure. Jason, just in case you are going to do a v7 this could move to u8 then. Indeed I think this is one to send individually to netdev@ once the tree opens there for 6.2. Jason