From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0AEC4332F for ; Thu, 13 Oct 2022 09:21:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 255376B0071; Thu, 13 Oct 2022 05:21:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DEDA6B0073; Thu, 13 Oct 2022 05:21:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0576C8E0001; Thu, 13 Oct 2022 05:21:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E4A0C6B0071 for ; Thu, 13 Oct 2022 05:21:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AB2A21A0A47 for ; Thu, 13 Oct 2022 09:21:55 +0000 (UTC) X-FDA: 80015384190.18.F67A9F7 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf11.hostedemail.com (Postfix) with ESMTP id 2B2724002E for ; Thu, 13 Oct 2022 09:21:48 +0000 (UTC) Received: from zn.tnic (p200300ea9733e733329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e733:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 69BF11EC053B; Thu, 13 Oct 2022 11:21:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1665652901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=LnnwRuw3rWkfmMreTNatsscTtvI113RGrzj3mDZQgt8=; b=IR4M12YIlBzE0MjYoQkPm9YQGawwBKItPFR1A5j38MojCMdB6INXbCzDfJl7BCrCqwvDLk vFprQY8OXhEdV/nrLCnqbyE1/PQLJoy0lmRPhi/B8vMtKUOEl6D9FLnPNxQcdw+T18xnB+ sUmZcBp5AcpqUJo1RmRC9rh5vKxdfEY= Date: Thu, 13 Oct 2022 11:21:36 +0200 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "linux-doc@vger.kernel.org" , "Lutomirski, Andy" , "arnd@arndb.de" , "jamorris@linux.microsoft.com" , "Moreira, Joao" , "tglx@linutronix.de" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "Yang, Weijiang" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "Shankar, Ravi V" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack Message-ID: References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-3-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=IR4M12YI; spf=temperror (imf11.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665652913; a=rsa-sha256; cv=none; b=vIMjsbUmg2fEqZ81PFtKXaLeETwubdiNVxKCT75BZijyc/Bk+NghgfmKqJ4QREhJZTzgD8 /B53IY0j0mEkWEVwTL0OSZNA1WdnEr3cHZrdTM5v/MYhNnvnxDu05oo8jHW4Al9gELdxHQ V2T8nNwvbvyw/hrMy/uJaaWigQU6lsw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665652913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LnnwRuw3rWkfmMreTNatsscTtvI113RGrzj3mDZQgt8=; b=HKHImQ2xhMFbs8rpX1CKuCzHscgWejVDzopKggh25xBaDJBYyaHxIa5CM8cBuGWldxepmX 5UlTEorvO00e8Kuq0AqJUqJJCKvS1LatnYuLyu0f3roof41qQFlKPRkqwPxUtQmx+xPLv8 ZbDD9IzEiq4XAMQMX0fCUbty0JjjY+0= X-Rspamd-Server: rspam05 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=IR4M12YI; spf=temperror (imf11.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) X-Stat-Signature: 1ja5gd5cyquwc73esgbk7tg49jxu86jy X-Rspamd-Queue-Id: 2B2724002E X-HE-Tag: 1665652908-702887 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 13, 2022 at 12:31:38AM +0000, Edgecombe, Rick P wrote: > Yea, I was thinking to maybe just change it to > CONFIG_X86_USER_SHADOW_STACK in show_smap_vma_flags(). In that function > there is already CONFIG_ARM64_BTI and CONFIG_ARM64_MTE. I was thinking exactly the same thing. :-) > I'm not sure if there is any aversion to having arch CONFIGs in core > code, but it's kind of nice to have all of the potentially conflicting > strings in once place. Yeah, ok. I guess you can do the CONFIG_X86_USER_SHADOW_STACK thing for the sake of simplicity. We have *waaay* too many Kconfig symbols and we should introduce only the least amount of new ones. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette