From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F13BC433FE for ; Wed, 12 Oct 2022 20:04:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 984896B0071; Wed, 12 Oct 2022 16:04:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 933D2900002; Wed, 12 Oct 2022 16:04:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE416B0074; Wed, 12 Oct 2022 16:04:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6CAE66B0071 for ; Wed, 12 Oct 2022 16:04:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C36F141413 for ; Wed, 12 Oct 2022 20:04:27 +0000 (UTC) X-FDA: 80013374574.07.F699389 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf04.hostedemail.com (Postfix) with ESMTP id 8738E40026 for ; Wed, 12 Oct 2022 20:04:18 +0000 (UTC) Received: from zn.tnic (p200300ea9733e705329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e705:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id ADAA71EC064C; Wed, 12 Oct 2022 22:04:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1665605052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PLO4zeP3zv6Xy77o0G6Y6mDad/C0l3CRrS49slx6uWI=; b=hn4ux4Y+b3pkiTvml7dz5rvwcps6ZFCZ4Zc3OG/TCBLyIhRrcNMFCif4DE3Jyqfk9WV8yE GzWBcJhwU5qRzjX9jl+VK92HHTPT7Ury0lZALvp2EKWlx3Mnjh8d0nm7RWpqexsXqjHq1p gooxOGhJocW7MzngNOSZZ8rxXiOhFFw= Date: Wed, 12 Oct 2022 22:04:08 +0200 From: Borislav Petkov To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Subject: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack Message-ID: References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-3-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220929222936.14584-3-rick.p.edgecombe@intel.com> X-Stat-Signature: zsjt6wuxen5azmox77aewejpg1ywqc5e X-Rspamd-Queue-Id: 8738E40026 Authentication-Results: imf04.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=hn4ux4Y+; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="query timed out" header.from=alien8.de (policy=temperror) X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1665605058-552307 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 03:28:59PM -0700, Rick Edgecombe wrote: > From: Yu-cheng Yu > Subject: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack Please remove all "CET", "cet", etc strings from the text as that is confusing. We should use either shadow stack or IBT and not CET. > +config ARCH_HAS_SHADOW_STACK Do I see it correctly that this thing is needed only once in show_smap_vma_flags()? If so, can we do a arch_show_smap_vma_flags(), call it at the end of former function and avoid adding yet another Kconfig symbol? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette