From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123D3C433FE for ; Wed, 12 Oct 2022 01:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10B026B0074; Tue, 11 Oct 2022 21:32:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BACB900002; Tue, 11 Oct 2022 21:32:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9D136B0078; Tue, 11 Oct 2022 21:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D32196B0074 for ; Tue, 11 Oct 2022 21:32:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 915A61402E7 for ; Wed, 12 Oct 2022 01:32:11 +0000 (UTC) X-FDA: 80010571662.05.4177422 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id A67E540016 for ; Wed, 12 Oct 2022 01:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fUZEXqXlcvGpSMIdZIEQfkiNSUla6WCxRpNh55039dA=; b=ughmLGUmdgN3BVR4wbzhhjoqYM 01KW9e8niYprKxxIAqDLbcJ61iwJ5nO9S4M7Jn6+Amo0K30NnxA9ddjNjwZfG58MsFGTtbIq0pcmm a7rMtlcf9uBDf9dZNftSGRIBY1fS4x0SlZl5+1v2FKQ/S2oNsrgATO8y+ZoBZHmgI+FcEA4PFFD6f FoCkKGHcEiswWVhJ9c56Ay4xiUkL9IWeqs91tWT0ksLmZiev9us7FfGFq6k3dWuHaKPrzxSkx3UsU 9e7PpdwEz9dAe6FFkx8DCyz4oLkwyGgYaJIQLxZmm8m+8tULG7y5+UTaDRzJuF5nyJoJySDCM8PS4 +t8hnFKA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiQbN-005S2B-Ue; Wed, 12 Oct 2022 01:32:05 +0000 Date: Wed, 12 Oct 2022 02:32:05 +0100 From: Matthew Wilcox To: Andrew Morton Cc: nicememory@gmail.com, bugzilla-daemon@kernel.org, linux-mm@kvack.org Subject: Re: [Bug 216570] New: Pass wrong index value to DEFINE_READAHEAD which leads to almost no readahead of fsverity data Message-ID: References: <20221011172119.00ee0ce1cbd82fbb6f83ce1e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221011172119.00ee0ce1cbd82fbb6f83ce1e@linux-foundation.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665538331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fUZEXqXlcvGpSMIdZIEQfkiNSUla6WCxRpNh55039dA=; b=kJA2rFCgPVFaSUcPAsDk+XrKLcb/S8H6t/i0WV+AU44VkGd9CQIvUj6KmAv/69TIytA/pT 3KgQ54CYSidfJz36RwcT+4lOzwQZzRN53eJBtRVo0dJwGxisVN86CYVuO/eS4IK52D5JUU u+pvjBU1Pxeuz8byeOrIGaWNSQxPmdA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ughmLGUm; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665538331; a=rsa-sha256; cv=none; b=XLofM1OO+i6RIyotaQlxekjLM3W4Gl3km7P7PqpuEwl2ilNuFkKRXzUrpgjslu7GAfuW2s hYODZZTl+6h7aC6iBwUgbj5NqaCyqClVHlHdqa5rmJEfSoJwA/QYWlxRairtJ4IKJFUdxv gSyR9hUOqPHKtzUhH1SESNkWZ/TgNWQ= X-Rspam-User: X-Rspamd-Server: rspam11 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ughmLGUm; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: p65gdzhizu3eo5zr816c6kb9ato19r6m X-Rspamd-Queue-Id: A67E540016 X-HE-Tag: 1665538328-850321 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 11, 2022 at 05:21:19PM -0700, Andrew Morton wrote: > > It was introduced by commit 73bb49da50cd460bb3ba31250ed2e7fbf2115edf > > > > In function ext4_read_merkle_tree_page and f2fs_read_merkle_tree_page, > > parameter index was added by a offset and then passed to > > page_cache_readahead_unbounded. > > For now, index is passed to DEFINE_READAHEAD directly with wrong value. > > oops, yes, thanks. Matthew, could you please take a look? Oh, yes, oops indeed. I'll send a fix in the morning.