From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: nicememory@gmail.com, bugzilla-daemon@kernel.org, linux-mm@kvack.org
Subject: Re: [Bug 216570] New: Pass wrong index value to DEFINE_READAHEAD which leads to almost no readahead of fsverity data
Date: Wed, 12 Oct 2022 02:32:05 +0100 [thread overview]
Message-ID: <Y0YZFT0OjcHT2rh+@casper.infradead.org> (raw)
In-Reply-To: <20221011172119.00ee0ce1cbd82fbb6f83ce1e@linux-foundation.org>
On Tue, Oct 11, 2022 at 05:21:19PM -0700, Andrew Morton wrote:
> > It was introduced by commit 73bb49da50cd460bb3ba31250ed2e7fbf2115edf
> >
> > In function ext4_read_merkle_tree_page and f2fs_read_merkle_tree_page,
> > parameter index was added by a offset and then passed to
> > page_cache_readahead_unbounded.
> > For now, index is passed to DEFINE_READAHEAD directly with wrong value.
>
> oops, yes, thanks. Matthew, could you please take a look?
Oh, yes, oops indeed. I'll send a fix in the morning.
prev parent reply other threads:[~2022-10-12 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-216570-27@https.bugzilla.kernel.org/>
2022-10-12 0:21 ` Andrew Morton
2022-10-12 1:32 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0YZFT0OjcHT2rh+@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@kernel.org \
--cc=linux-mm@kvack.org \
--cc=nicememory@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox