From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4274EC433F5 for ; Sun, 9 Oct 2022 14:18:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 927096B0071; Sun, 9 Oct 2022 10:18:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 888F56B0073; Sun, 9 Oct 2022 10:18:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 702656B0074; Sun, 9 Oct 2022 10:18:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 58AF16B0071 for ; Sun, 9 Oct 2022 10:18:09 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 326291C5E70 for ; Sun, 9 Oct 2022 14:18:09 +0000 (UTC) X-FDA: 80001615498.26.A7F5979 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 603ED1C0022 for ; Sun, 9 Oct 2022 14:18:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F728B80C91; Sun, 9 Oct 2022 14:18:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 659D2C433D6; Sun, 9 Oct 2022 14:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1665325077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oirLAgHKzqbm2tDuRRRruxvBPFu6OuA1m1Bdo0JewVo=; b=YgHbN0I0lUsk61F/tkacjTtELz9m0jTOee92icnhvNyHJrs9iBf1nxk5rIk4LCzkioh8sG 190YFxxX+8obr4IDytSpJV/y+LGJPtZT2kSp6+N5MRfHp0a/WJLUeHRU53NaAsEmu2d/gM WcwjBCYWAwT/EnbHfbZZP/9zFIVJmUM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 76b4077f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 9 Oct 2022 14:17:57 +0000 (UTC) Date: Sun, 9 Oct 2022 08:17:41 -0600 From: "Jason A. Donenfeld" To: Kees Cook Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andreas Noever , Andrew Morton , Andy Shevchenko , Borislav Petkov , Catalin Marinas , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Christoph Hellwig , Christophe Leroy , Daniel Borkmann , Dave Airlie , Dave Hansen , "David S . Miller" , Eric Dumazet , Florian Westphal , Greg Kroah-Hartman , "H . Peter Anvin" , Heiko Carstens , Helge Deller , Herbert Xu , Huacai Chen , Hugh Dickins , Jakub Kicinski , "James E . J . Bottomley" , Jan Kara , Jason Gunthorpe , Jens Axboe , Johannes Berg , Jonathan Corbet , Jozsef Kadlecsik , KP Singh , Marco Elver , Mauro Carvalho Chehab , Michael Ellerman , Pablo Neira Ayuso , Paolo Abeni , Peter Zijlstra , Richard Weinberger , Russell King , Theodore Ts'o , Thomas Bogendoerfer , Thomas Gleixner , Thomas Graf , Ulf Hansson , Vignesh Raghavendra , WANG Xuerui , Will Deacon , Yury Norov , dri-devel@lists.freedesktop.org, kasan-dev@googlegroups.com, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 0/7] treewide cleanup of random integer usage Message-ID: References: <20221008055359.286426-1-Jason@zx2c4.com> <202210082028.692DFA21@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202210082028.692DFA21@keescook> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665325088; a=rsa-sha256; cv=none; b=h1mAysklhhAgsKYWV05datDFGv40DfDuRfXqP4zQ0P1ZNCFICPkaBLACCcCJIw980VrkUu xnGuhzZWtF4KNq7gWh5p0/LQSMyIeXCZkWekfv/5UHgMrv1n64zR3//rhI3D5TWwsBbxoI lSO+yVRqTEg25CEApWSyb4cotsa0rWA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=YgHbN0I0; spf=pass (imf18.hostedemail.com: domain of "SRS0=aaEw=2K=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=aaEw=2K=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665325088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oirLAgHKzqbm2tDuRRRruxvBPFu6OuA1m1Bdo0JewVo=; b=RkUvgkXNlHd4f7ZdAc2jcgRgS0vkjFwWBmSHrAnL4wOhbsLSiDMVgzz9IUzzhRu8e84iOY jBFwBym8t+Dl/is7owZB79Tkn2ZQq/1JZSEgo0uE3iWmDvEf4x5Tq7lfIpX37oa3ii/seX oVC96qOIcSxq1O7nfFv2S3G97uiiujo= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=YgHbN0I0; spf=pass (imf18.hostedemail.com: domain of "SRS0=aaEw=2K=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=aaEw=2K=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com X-Stat-Signature: o8b4k815nbf4stbqq5r33euzjodrgxmn X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 603ED1C0022 X-Rspam-User: X-HE-Tag: 1665325088-976005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 08, 2022 at 08:41:14PM -0700, Kees Cook wrote: > On Fri, Oct 07, 2022 at 11:53:52PM -0600, Jason A. Donenfeld wrote: > > This is a five part treewide cleanup of random integer handling. The > > rules for random integers are: > > Reviewing the delta between of my .cocci rules and your v5, everything > matches, except for get_random_int() conversions for files not in > your tree: > [...] > So, I guess I mean to say that "prandom: remove unused functions" is > going to cause some pain. :) Perhaps don't push that to -next, and do a > final pass next merge window to catch any new stuff, and then send those > updates and the removal before -rc1 closes? Ooof. Actually I think what I'll do is include a suggested diff for the merge commit that fixes up the remaining two thankfully trivial cases. Jason