From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04B2C4332F for ; Tue, 18 Oct 2022 16:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B1296B0072; Tue, 18 Oct 2022 12:55:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 741AF6B0075; Tue, 18 Oct 2022 12:55:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FEDA6B0078; Tue, 18 Oct 2022 12:55:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B51B6B0072 for ; Tue, 18 Oct 2022 12:55:19 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C270B1C676B for ; Tue, 18 Oct 2022 16:55:18 +0000 (UTC) X-FDA: 80034670716.10.0214C01 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf06.hostedemail.com (Postfix) with ESMTP id 50DB7180033 for ; Tue, 18 Oct 2022 16:55:17 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id c22so17434438lja.6 for ; Tue, 18 Oct 2022 09:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=/SAC92zkDCoOb8Cpvbv0BcWkETu3jP+yy1JmC279Q2A=; b=Ra4wyabBIp8rt9azFlOFv7RAzTCWDvDKgJPw5swQEzTJq6MKRaWjqvOKB44/IJK3b5 Fqe5fr5J5YyPnYY7au/ad5MSVNQfm968kRvremL2DDRzx3+TdnX5AtraZhZMS3neP4Op 7fLWw75qb6CTQz/HU61J8Tjo8H0q7TRIir51cuKXvQYJrDVxUIQqyONLtpOYbToi4vIa /idIGQKogtLdsMLGCFUwe4RTHoDEPBUyWi/Yb+DvNgMj3N8sTOQSM67BE2eMjSYAGwBT 7ZaPN6v9OOQjYAD1zZbb6TH9lGYW8xE2qXZ8pREFLnWRQXswbGCBMsDSwSjS7MQMQXZ5 ObgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/SAC92zkDCoOb8Cpvbv0BcWkETu3jP+yy1JmC279Q2A=; b=vdQnhoMmR91NQEmj27b5QTsIFpwlKfz1ly2O8PloqShH1tibacGwHOZJxpH49tXzpk KvmsAOVmTdn/q9th8r4jmD6QE00oaTDsIZuqrjQN6+Yt+tIuoLMx8JR2wCsZHfvwLogx fJDwBRAQAdobvgxoSgLMmJATFtfZNtgW095e4kUgktbatYcWvvL8dZfcmW4v5CX4oxZX wJXumpvsemztX0eSgPsN9qBK+7JwO1cR+iWKencugS4tVYecIeMA4NDEzC7NWB02aYsL qxHoMLaXbpR7XR2rLQEx5w62ClRWQfj7kkXXyAwVciEqceInsaW+Bimv5BgwucsVMlzr kNOg== X-Gm-Message-State: ACrzQf3OVN/TD/WR3Ik1jsVRAttNRm/g5FHxDr9KTP0iEbZxnCdfD3iO xi4SQx8pEBoKi0PT5IWb4sv//iQBSbI= X-Google-Smtp-Source: AMsMyM59JORIxeg6rOYkUZ+KB07JvYoNGW7Mv3gX1JuxcOd0SzDy/yYMNJ7CqWBTax8cH7uwpRuIaA== X-Received: by 2002:a2e:8ecc:0:b0:26f:dd45:e50f with SMTP id e12-20020a2e8ecc000000b0026fdd45e50fmr1493871ljl.48.1666112115228; Tue, 18 Oct 2022 09:55:15 -0700 (PDT) Received: from pc636 (host-90-235-12-21.mobileonline.telia.com. [90.235.12.21]) by smtp.gmail.com with ESMTPSA id a13-20020a19f80d000000b004948b667d95sm1915582lff.265.2022.10.18.09.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 09:55:14 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 18 Oct 2022 18:55:10 +0200 To: Steven Rostedt Cc: Uladzislau Rezki , Andrew Morton , kbuild-all@lists.01.org, Linux Memory Management List , LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 4/7] mm/vmalloc: Use a trace_alloc_vmap_area event Message-ID: References: <20221017160233.16582-7-urezki@gmail.com> <202210180250.V8hzNH8X-lkp@intel.com> <20221018124412.3beca846@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018124412.3beca846@gandalf.local.home> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666112117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/SAC92zkDCoOb8Cpvbv0BcWkETu3jP+yy1JmC279Q2A=; b=qMaFfyEqKg5bxgKrQIo81r4iqQvxk8caqjVvUlqXPqaR7TtQpuVfdpiAiQdcXscihGDPWt 5z7H1jhLKdpzyNAM32vBlbpkssJtL2ZsVKoaYQlGIISCO0XNK87Ge2RmMHRlc5y379N1RM XhtoLCZl7zgX1u6C88G79YDDa8RnRS8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ra4wyabB; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666112117; a=rsa-sha256; cv=none; b=h0I+DL0B+QFOwgM6EwLndDm67vBN/TMLIoBEmdxj3w0Yyh5n5BTSpDQO73oua2UW1K3GYw J10FQWbpeH8udoKczusSQexi/OfcrP8IlP2BItL+FF7DjEliOixHFdk3kHgoiuWglMxCcZ YmxhFDI+tAGH2Fhufbnpatdjvj1YZJ4= X-Rspamd-Server: rspam12 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ra4wyabB; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 351sn4hhqotpqsoee38e7ismuk1333jh X-Rspamd-Queue-Id: 50DB7180033 X-HE-Tag: 1666112117-858407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 18, 2022 at 12:44:12PM -0400, Steven Rostedt wrote: > On Tue, 18 Oct 2022 18:17:55 +0200 > Uladzislau Rezki wrote: > > > Hello, Steven. > > > > > > > > [auto build test ERROR on akpm-mm/mm-everything] > > > [also build test ERROR on linus/master v6.1-rc1 next-20221017] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Uladzislau-Rezki-Sony/Add-basic-trace-events-for-vmap-vmalloc/20221018-000544 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > > patch link: https://lore.kernel.org/r/20221017160233.16582-7-urezki%40gmail.com > > > patch subject: [PATCH 4/7] mm/vmalloc: Use a trace_alloc_vmap_area event > > > config: um-i386_defconfig > > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > > > reproduce (this is a W=1 build): > > > # https://github.com/intel-lab-lkp/linux/commit/fbc853c689b29d3bb9fe250b2653fd2dd8046fc7 > > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > > git fetch --no-tags linux-review Uladzislau-Rezki-Sony/Add-basic-trace-events-for-vmap-vmalloc/20221018-000544 > > > git checkout fbc853c689b29d3bb9fe250b2653fd2dd8046fc7 > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash > > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > In file included from include/trace/events/vmap.h:123, > > > from mm/vmalloc.c:47: > > > >> include/trace/define_trace.h:84:34: fatal error: trace/events/kernel_vmap.h: No such file or directory > > > 84 | # define __TRACE_INCLUDE(system) > > > | ^ > > > compilation terminated. > > > > > I can reproduce it. It seems it happens so far only on the ARCH=um case. > > For regular arm/x86 i do not see such build error. > > > > If i rename the TRACE_SYSTEM macro to something different then "vmap" > > it compiles fine. In case of: > > > > #define TRACE_SYSTEM vmap > > > > the prefix "kernel_" is added, thus the header name becomes as kernel_vmap.h > > > > Steven can you give some indications? Or any thoughts about it? > > > > Thank you in advance! > > It comes from this: > > arch/um/Makefile:# -Dvmap=kernel_vmap prevents anything from referencing the libpcap.o symbol so > arch/um/Makefile: $(ARCH_INCLUDE) $(MODE_INCLUDE) -Dvmap=kernel_vmap \ > > > It defines "vmap" to "kernel_vmap" which will change the above > TRACE_SYSTEM Define to: > > #define TRACE_SYSTEM kernel_vmap > > and that will confuse everything else. > Hm... Right then it goes completely crazy. So there is only one option it is to rename the trace header defined by the TRACE_SYSTEM. Thank you for your help :) -- Uladzislau Rezki