From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF710C4332F for ; Tue, 18 Oct 2022 10:48:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51BED6B0075; Tue, 18 Oct 2022 06:48:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A1526B0078; Tue, 18 Oct 2022 06:48:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 342616B007B; Tue, 18 Oct 2022 06:48:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 20AF76B0075 for ; Tue, 18 Oct 2022 06:48:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E4F1C809E2 for ; Tue, 18 Oct 2022 10:48:09 +0000 (UTC) X-FDA: 80033745498.03.BD1CD94 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 7F3B040036 for ; Tue, 18 Oct 2022 10:48:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83D2A61509; Tue, 18 Oct 2022 10:48:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69882C433C1; Tue, 18 Oct 2022 10:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666090088; bh=TmSjMdn9KzKg0YBMH9ER0S5KZL106NcpkRk9mATClwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y5ppxsgfo0DsaUPvj2xBQWV3sHMEmurar+lIlLLPJ9kLUcUjFw2IOLyhfGej2FYo8 gE9GidnUZdAJIcbE7aJK117/zL7QKqyC9lrxIyNs+yCswWQzcPoDWBdIuRFrkVtBdr DMBvwQm7joy4cw3FOiiJ0REt4gCVWb0npNAORY00= Date: Tue, 18 Oct 2022 12:48:04 +0200 From: Greg KH To: Muhammad Usama Anjum Cc: Danylo Mocherniuk , avagin@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org, corbet@lwn.net, david@redhat.com, kernel@collabora.com, krisman@collabora.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, peter.enderborg@sony.com, shuah@kernel.org, viro@zeniv.linux.org.uk, willy@infradead.org, emmir@google.com, figiel@google.com, kyurtsever@google.com, Paul Gofman , surenb@google.com Subject: Re: [PATCH v3 0/4] Implement IOCTL to get and clear soft dirty PTE Message-ID: References: <20221014134802.1361436-1-mdanylo@google.com> <474513c0-4ff9-7978-9d77-839fe775d04c@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <474513c0-4ff9-7978-9d77-839fe775d04c@collabora.com> ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Y5ppxsgf; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666090089; a=rsa-sha256; cv=none; b=0dZ3wK0jGpiKxx5ObU8tZHJO1vvweskyzbAsrV2UA1SkESs/CuwYq91MEb2Iwbel8+kLAr ElGTTXAacqApScCevUMuGo5unhNrwkZhdIfLDdKQzl2juXJZDSnCsLu5TsjiOg9MqUFtNc yLGaDloFwYZvtIFNFwQPNvINefgdCLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666090089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PfIhWynth4ZQInBvArADEuES3QuKuMfbvYDhMoIgLo=; b=D5EvXIPnR/CIYiS+IimZWGJU/eqNmcwRsSgOSRig5oXs73lya1ZSuER2H+SLFAIxBhuIA7 cu9hn/9XHyjU2P8za3hcDIUhMEDUOhKeohMtp4bckJbrvodTnrfMdqrMOyunDShjU+3VgK jUiqkcd7Jj4J85kb0eGs6Fal/iP4vIc= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Y5ppxsgf; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 14teeeux57u3y51pitx9eiewntcqynq5 X-Rspamd-Queue-Id: 7F3B040036 X-HE-Tag: 1666090089-726851 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 18, 2022 at 03:36:24PM +0500, Muhammad Usama Anjum wrote: > /** > * struct pagemap_sd_args - Soft-dirty IOCTL argument > * @start: Starting address > * @len: Length of the region > * @vec: Output page_region struct array > * @vec_len: Length of the page_region struct array > * @max_out_page: Optional max output pages (It must be less than vec_len if > specified) > * @flags: Special flags for the IOCTL > * @rmask: Special flags for the IOCTL > * @amask: Special flags for the IOCTL > * @emask: Special flags for the IOCTL What do you mean exactly by "special flags"? > * @__reserved: Reserved member to preserve data alignment. Must be 0. > */ > struct pagemap_sd_args { > __u64 __user start; > __u64 len; > __u64 __user vec; // page_region __user is a marking for a pointer, not a u64, right? Now the fact that you treat it like a pointer later in the kernel is different, but that shouldn't be on the uapi header file. You can put it in the kerneldoc, which you did not do. thanks, greg k-h