From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E72C43219 for ; Tue, 18 Oct 2022 03:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A17896B0072; Mon, 17 Oct 2022 23:07:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C7076B0075; Mon, 17 Oct 2022 23:07:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83FA06B0078; Mon, 17 Oct 2022 23:07:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 729536B0072 for ; Mon, 17 Oct 2022 23:07:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3B941120916 for ; Tue, 18 Oct 2022 03:07:20 +0000 (UTC) X-FDA: 80032584240.23.491E06A Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf09.hostedemail.com (Postfix) with ESMTP id D442D14002C for ; Tue, 18 Oct 2022 03:07:19 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id a6-20020a17090abe0600b0020d7c0c6650so16112898pjs.0 for ; Mon, 17 Oct 2022 20:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=glZFDN3AHMX7S3G0PMTlaeT9BFw4J8xiraTo5Hd9nbE=; b=mF0cQfuRXpGo2kCvszI69LFhd8M85WRTSL9PiOLxXLninjAI4t0yoRYlkrLX3Jx+WB kD6RS8LzDWcTOI2LCtu7SO/qFazY+hQ6s0I7x8675VutHMT/TDi9uo2HK6KXvzw08t9V 6ongr7McCUV99+kQPxG16SkQ/1grINwo4pe+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=glZFDN3AHMX7S3G0PMTlaeT9BFw4J8xiraTo5Hd9nbE=; b=eXFFK41B62x9RWJyJOQLoX9mbqpljfCNpdNkL/FUIYIIJowX4URKbysyn4yPwrHQAp c4Ejp3qg0bQcKwUTigkpVG/206JqqiOmPS4Xt5WNBZvySxNkFfoxCXdYjT0Niq2GuNig oWjo89BspS15Z8MYQ2UnxiTGFqK8iUFi6/sQRSwtsudaMuL/0d73NEDctRvxVHmbkmHg 844jG17f7NPeEg16RmsqIGxSw/Mopoqukm0OpckPB0ExUA9vq+BZzEvfZ0LNLaKWT/kZ XAAcIyLeJ+rfD7vUUKQ/nyNceqwdf0dBdzmpqLcp+2xyU2fg3jzgtNr6T21bmHznwq+X qo7g== X-Gm-Message-State: ACrzQf1P+XrEKBbipIrUVE7+jdoMw5ixHr4U0oBeKAzOeMKq4s+ogIu2 AwxwaKpaqrSIc6kEcw0RrMoHbw== X-Google-Smtp-Source: AMsMyM5nAaJygI9OUltDMlB7UpLcmWT2XCkim5Gt4Fln009SoeD+wO4R3Ff/mb+1stNUq8Mt0iGAUA== X-Received: by 2002:a17:902:eb86:b0:17f:f884:a62b with SMTP id q6-20020a170902eb8600b0017ff884a62bmr843423plg.153.1666062438830; Mon, 17 Oct 2022 20:07:18 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:58b4:95a3:4654:2a9f]) by smtp.gmail.com with ESMTPSA id mn7-20020a17090b188700b00205f013f275sm10423991pjb.22.2022.10.17.20.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 20:07:18 -0700 (PDT) Date: Tue, 18 Oct 2022 12:07:14 +0900 From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: Sergey Senozhatsky , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 6/8] zram: Add recompression algorithm choice to Kconfig Message-ID: References: <20221009090720.1040633-1-senozhatsky@chromium.org> <20221009090720.1040633-7-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221009090720.1040633-7-senozhatsky@chromium.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666062439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=glZFDN3AHMX7S3G0PMTlaeT9BFw4J8xiraTo5Hd9nbE=; b=kUL8gt5qk3t5Pn55TCxbd6/LqyafPtVy5D6rl+FeUZhn8C6/Hmi9gLQf4fXtK7/5Kq/J00 n6N9jObQ/xz/YmKHPDIWjW7b0rg9RyyVaA0L5bP8KP7dNF7nkTsEaE7jRMwM5hYJ9tub6M Dx3HawmCcU6Sb3o/ESQ9sRoBkQCTTPE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=mF0cQfuR; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666062440; a=rsa-sha256; cv=none; b=qWFGC7sFWEaeXOKP3kLMUsQmlOmALj9g8iGnVikx8UiwZ1r9cZiRXiOP8WaA8agyx+OTrH JItclOi+uwLrQpLqheDrgMVfglOdd9XqHTkDyuTQ8rHFOfhSUBHQYDPKE9UQzBvctFe/48 DcNB+Rq6OhC5OgGE/SLFPmaqlp08V/U= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=mF0cQfuR; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D442D14002C X-Rspam-User: X-Stat-Signature: b1upq11836zjb4kxf81yqtt4aydmfr4a X-HE-Tag: 1666062439-407028 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Make (secondary) recompression algorithm selectable just like we do it for the (primary) default one. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/Kconfig | 40 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig index 3e00656a6f8a..076a76cd1664 100644 --- a/drivers/block/zram/Kconfig +++ b/drivers/block/zram/Kconfig @@ -93,3 +93,43 @@ config ZRAM_MULTI_COMP SIZE (in bytes) parameter sets the object size watermark: idle objects that are of a smaller size will not get recompressed. + +choice + prompt "Default zram recompression algorithm" + default ZRAM_DEF_RECOMP_ZSTD + depends on ZRAM && ZRAM_MULTI_COMP + +config ZRAM_DEF_RECOMP_LZORLE + bool "lzo-rle" + depends on CRYPTO_LZO + +config ZRAM_DEF_RECOMP_ZSTD + bool "zstd" + depends on CRYPTO_ZSTD + +config ZRAM_DEF_RECOMP_LZ4 + bool "lz4" + depends on CRYPTO_LZ4 + +config ZRAM_DEF_RECOMP_LZO + bool "lzo" + depends on CRYPTO_LZO + +config ZRAM_DEF_RECOMP_LZ4HC + bool "lz4hc" + depends on CRYPTO_LZ4HC + +config ZRAM_DEF_RECOMP_842 + bool "842" + depends on CRYPTO_842 + +endchoice + +config ZRAM_DEF_RECOMP + string + default "lzo-rle" if ZRAM_DEF_RECOMP_LZORLE + default "zstd" if ZRAM_DEF_RECOMP_ZSTD + default "lz4" if ZRAM_DEF_RECOMP_LZ4 + default "lzo" if ZRAM_DEF_RECOMP_LZO + default "lz4hc" if ZRAM_DEF_RECOMP_LZ4HC + default "842" if ZRAM_DEF_RECOMP_842 -- 2.38.0.413.g74048e4d9e-goog