From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A7CC433FE for ; Tue, 18 Oct 2022 02:42:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 547FA6B0075; Mon, 17 Oct 2022 22:42:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F5AE6B0078; Mon, 17 Oct 2022 22:42:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E70C6B007B; Mon, 17 Oct 2022 22:42:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 314666B0075 for ; Mon, 17 Oct 2022 22:42:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E9031C5FF2 for ; Tue, 18 Oct 2022 02:42:45 +0000 (UTC) X-FDA: 80032522290.02.B39F27A Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf25.hostedemail.com (Postfix) with ESMTP id AAB9BA0034 for ; Tue, 18 Oct 2022 02:42:44 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id b5so12128004pgb.6 for ; Mon, 17 Oct 2022 19:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RqeqoWqCjNqsK/xnS0nJr4BZwfuoj4Sj4MC4233ZF6Y=; b=VajYXNL8heC+d3EjGeQoNV0ccBG9rW9OALdTpXtV6hFkWtgdcmad0xx0D1SkNCxEne MdBrKH84G/Z3fwCKnTAyLiH3EO/LQ9BW6TJraV3NKq5KA5uAI3JAQQs0Afi6f9ujWHEk nDUBz656iaKRHyvf3aDoKl1K2hL7bD7nodh/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RqeqoWqCjNqsK/xnS0nJr4BZwfuoj4Sj4MC4233ZF6Y=; b=19aZjU0MvkwnKdi6dri7fhagF24lksPkgJ0UfN4v6WWIBscF4zxUIFWlUBQzFHtfVJ XWCvIcoCeNY34xg1J70b6Vi1QhTZCj0UJUI5obUQjqEk8XRLUJkb/8gZuMqSATFzuQYm 91eY6Pcsf78zmGGp6td0Pj3K865CDC4E+V/gMQbgbutg8v6U0EAZ8BS8yhTgEuxRuGLd zBzCUfcY5gQb6OIaFFDcSfsiuQ6Ndo2vwmBPZHtgvAaeE+2y9yQNB6DVq6djuvYNeV6B V+LzNe+8ZxmeAKEcGfoIaqqUyrrqAZs8P+9olOFxizsHnM4v7DmvqoDPBRq42GffuzWw P4SA== X-Gm-Message-State: ACrzQf0BYatMQx9U6/lrw7OUM2hYlvNYUMDc7UH4PHPX1i4omETv/WKn di9GwcIJ0NYjFBEJc3IVqX+4ag== X-Google-Smtp-Source: AMsMyM7D2E1TUCt6bluuMstbnVzW7wwywIoeH1xxhTE5eRRjGqD1I+0xkvHquZney3KDq7SEBc067A== X-Received: by 2002:a63:1b58:0:b0:45f:e7ba:a223 with SMTP id b24-20020a631b58000000b0045fe7baa223mr737575pgm.548.1666060963676; Mon, 17 Oct 2022 19:42:43 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:58b4:95a3:4654:2a9f]) by smtp.gmail.com with ESMTPSA id 8-20020a630308000000b0043c80e53c74sm6887064pgd.28.2022.10.17.19.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 19:42:43 -0700 (PDT) Date: Tue, 18 Oct 2022 11:42:39 +0900 From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: Sergey Senozhatsky , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 4/8] zram: Introduce recompress sysfs knob Message-ID: References: <20221009090720.1040633-1-senozhatsky@chromium.org> <20221009090720.1040633-5-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221009090720.1040633-5-senozhatsky@chromium.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666060964; a=rsa-sha256; cv=none; b=vVfOmRl5TQjn7oWMpO08lqqHJ5H+ADaRe8tRkg+xASxwZtcYKjcYKM1StKjEOXVs0wkQBa yQ5wtLvRPs4IyF9JbPzx4SbUs/WJ98cm7nL5inT328U4uY2c1A5vftf9oX+ayVltMc9FAi 4UVoPR8/1+M3T6XhWAfV/LxyiqVFBWo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VajYXNL8; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666060964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RqeqoWqCjNqsK/xnS0nJr4BZwfuoj4Sj4MC4233ZF6Y=; b=UUgStDhMwtz9LzYyyl1QJUneJcm3jjvG96uwppe45FE8sUucsfBzXXxAdlbdtXtzrSL931 fMrjJHPwAhyDPE3CRVURNFXCxhuMX3ZSGNcAAJZQUNjXbghmA/RXzuAV/0+r5HVZMqDhMG QhhI+38/OQGlivaHTWEzMp8dbzAswJE= X-Rspamd-Queue-Id: AAB9BA0034 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VajYXNL8; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: igknrtd9kiryazq3cxdprm7nzpe6bdho X-HE-Tag: 1666060964-184750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A fixup patch: update Kconfig description and tweak coding styles. --- diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig index 7febf36e93eb..3e00656a6f8a 100644 --- a/drivers/block/zram/Kconfig +++ b/drivers/block/zram/Kconfig @@ -90,3 +90,6 @@ config ZRAM_MULTI_COMP echo TIMEOUT > /sys/block/zramX/idle echo SIZE > /sys/block/zramX/recompress + + SIZE (in bytes) parameter sets the object size watermark: idle + objects that are of a smaller size will not get recompressed. diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 12368e773f3d..143c33bd6783 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1623,9 +1623,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, * * Corresponding ZRAM slot should be locked. */ -static int zram_recompress(struct zram *zram, - u32 index, - struct page *page, +static int zram_recompress(struct zram *zram, u32 index, struct page *page, int size_watermark) { unsigned long handle_prev; @@ -1708,8 +1706,7 @@ static int zram_recompress(struct zram *zram, static ssize_t recompress_store(struct device *dev, struct device_attribute *attr, - const char *buf, - size_t len) + const char *buf, size_t len) { struct zram *zram = dev_to_zram(dev); unsigned long nr_pages = zram->disksize >> PAGE_SHIFT;