From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv3 4/8] zram: Introduce recompress sysfs knob
Date: Tue, 18 Oct 2022 11:42:39 +0900 [thread overview]
Message-ID: <Y04Sn50kt5qLxpbK@google.com> (raw)
In-Reply-To: <20221009090720.1040633-5-senozhatsky@chromium.org>
A fixup patch: update Kconfig description and tweak coding styles.
---
diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
index 7febf36e93eb..3e00656a6f8a 100644
--- a/drivers/block/zram/Kconfig
+++ b/drivers/block/zram/Kconfig
@@ -90,3 +90,6 @@ config ZRAM_MULTI_COMP
echo TIMEOUT > /sys/block/zramX/idle
echo SIZE > /sys/block/zramX/recompress
+
+ SIZE (in bytes) parameter sets the object size watermark: idle
+ objects that are of a smaller size will not get recompressed.
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 12368e773f3d..143c33bd6783 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1623,9 +1623,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec,
*
* Corresponding ZRAM slot should be locked.
*/
-static int zram_recompress(struct zram *zram,
- u32 index,
- struct page *page,
+static int zram_recompress(struct zram *zram, u32 index, struct page *page,
int size_watermark)
{
unsigned long handle_prev;
@@ -1708,8 +1706,7 @@ static int zram_recompress(struct zram *zram,
static ssize_t recompress_store(struct device *dev,
struct device_attribute *attr,
- const char *buf,
- size_t len)
+ const char *buf, size_t len)
{
struct zram *zram = dev_to_zram(dev);
unsigned long nr_pages = zram->disksize >> PAGE_SHIFT;
next prev parent reply other threads:[~2022-10-18 2:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 9:07 [PATCHv3 0/8] zram: Support multiple compression streams Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 1/8] zram: Preparation for multi-zcomp support Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 2/8] zram: Add recompression algorithm sysfs knob Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 3/8] zram: Factor out WB and non-WB zram read functions Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 4/8] zram: Introduce recompress sysfs knob Sergey Senozhatsky
2022-10-18 0:08 ` Andrew Morton
2022-10-18 2:12 ` Sergey Senozhatsky
2022-10-18 2:42 ` Sergey Senozhatsky [this message]
2022-10-09 9:07 ` [PATCHv3 5/8] documentation: Add recompression documentation Sergey Senozhatsky
2022-10-18 2:22 ` Sergey Senozhatsky
2022-10-18 3:11 ` Andrew Morton
2022-10-18 2:50 ` Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 6/8] zram: Add recompression algorithm choice to Kconfig Sergey Senozhatsky
2022-10-18 3:07 ` Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 7/8] zram: Add recompress flag to read_block_state() Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 8/8] zram: correct typos Sergey Senozhatsky
2022-10-18 0:08 ` Andrew Morton
2022-10-18 2:10 ` Sergey Senozhatsky
2022-10-18 3:11 ` [PATCHv3 0/8] zram: Support multiple compression streams Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y04Sn50kt5qLxpbK@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox