From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D6FC433FE for ; Tue, 18 Oct 2022 02:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 380726B0075; Mon, 17 Oct 2022 22:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32E756B0078; Mon, 17 Oct 2022 22:22:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D0636B007B; Mon, 17 Oct 2022 22:22:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0522A6B0075 for ; Mon, 17 Oct 2022 22:22:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C95CD1C5C27 for ; Tue, 18 Oct 2022 02:22:31 +0000 (UTC) X-FDA: 80032471302.18.85568CF Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf08.hostedemail.com (Postfix) with ESMTP id 729FF160034 for ; Tue, 18 Oct 2022 02:22:31 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id h185so12073002pgc.10 for ; Mon, 17 Oct 2022 19:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K2UmYtYjB3AxW1v3oEIm4p6bkGOjTrsw0+F1/l8EfQ4=; b=b1hu7ojoi04IWcUltg0vD2rHPPCwbkSM7u1EyZVNvOKIkRf0CR2h6GHUVQzmndNmGJ 7zOa40s5AyDbIAjPUJr/RpeULlFt3kI6O1C4C0Vc3K/spnhczvyrg3FCLKgeBCQoocIy gPi6CZMHhqDoVhrOBetW71xHW1rScgaN31mjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K2UmYtYjB3AxW1v3oEIm4p6bkGOjTrsw0+F1/l8EfQ4=; b=BYHyO+EY1ORu2h2waUbGmGE1ZIs5RpbMK7cbliQG1V2USyQ4+X+2fC6RuDX3Cr8a+h fjFuH+xiH40cTjDt/ob+p/+hQug5yGCrtSv025VEnSxPvHa6wgf9E44g6AetlxZnh8pV V+Ce0sVZ29SwwhkN0LeRBK2TpyPHy/MzrKv8wXSh5vMfn+i+WfJL8vQBhhS5BPirXXyZ M+ig6WTzkzt6Njs0O3oyjpZtarvyM3BHESfNWipdNMLSoeVHu5RyjVnMW+syhoMx9P5s M6o3MxXQQqRrHePShDZ1eA+YifAQRGoJgepD5oaBp5tZjkVhoVkTYWnELqo7HGUEUAl7 H92A== X-Gm-Message-State: ACrzQf2iH2hV4WYI4oa8QPOoBZvjV+mawhznBs4RjzoIXjjx6yvXCoO4 9NOIBESI1SLfhKusC9quyCMmsKDbA8b6pg== X-Google-Smtp-Source: AMsMyM7A8XtbcwUptDkHdwZmNanZOncg2z0TA8C/gn+eXyyK7g3TV09fnICR487iCCKWbWayaKjYLg== X-Received: by 2002:a63:1165:0:b0:44d:e5ba:5603 with SMTP id 37-20020a631165000000b0044de5ba5603mr732838pgr.68.1666059750422; Mon, 17 Oct 2022 19:22:30 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:58b4:95a3:4654:2a9f]) by smtp.gmail.com with ESMTPSA id b3-20020a170902d50300b00178b06fea7asm7337236plg.148.2022.10.17.19.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 19:22:30 -0700 (PDT) Date: Tue, 18 Oct 2022 11:22:25 +0900 From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: Sergey Senozhatsky , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 5/8] documentation: Add recompression documentation Message-ID: References: <20221009090720.1040633-1-senozhatsky@chromium.org> <20221009090720.1040633-6-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221009090720.1040633-6-senozhatsky@chromium.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666059751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K2UmYtYjB3AxW1v3oEIm4p6bkGOjTrsw0+F1/l8EfQ4=; b=xPaQVWFSgumFaunzGbsphJl2Ec2mbVikCoeH8v4uThBoN9RzSP6gYDL587UGBWg5lvNwIf Cp/ZLGGUgy6GREYE9igIhU+85St+G6DkJIdnhmIn4gV8iAucISGntOXrClc/bKuRbkod+J bKW+7yBX2Ls3BrMm6mCTSJBUxnAKNQU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=b1hu7ojo; spf=pass (imf08.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666059751; a=rsa-sha256; cv=none; b=M0liQNVq+yEfKQg3H4Av5trBZ6wQ0cGrVXQAnwvdihJacrmgxG3P61Gkch898WUHi9OYDd kAjHMEU2KddwMw1badrVPqwTUbCU2resMZwLOp3oFyBU9lI4UM9sSHOVdAVrpJxut5Y/AR b7FSyUgQz0X0waXzh29yT6MAbnXUx+Y= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=b1hu7ojo; spf=pass (imf08.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 729FF160034 X-Stat-Signature: 8ezgzooerfazjaqt49xfnp3q4e1dn3rs X-Rspam-User: X-HE-Tag: 1666059751-389013 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/09 18:07), Sergey Senozhatsky wrote: [..] > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 12368e773f3d..143c33bd6783 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1623,9 +1623,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, > * > * Corresponding ZRAM slot should be locked. > */ > -static int zram_recompress(struct zram *zram, > - u32 index, > - struct page *page, > +static int zram_recompress(struct zram *zram, u32 index, struct page *page, > int size_watermark) > { > unsigned long handle_prev; > @@ -1708,8 +1706,7 @@ static int zram_recompress(struct zram *zram, > > static ssize_t recompress_store(struct device *dev, > struct device_attribute *attr, > - const char *buf, > - size_t len) > + const char *buf, size_t len) > { > struct zram *zram = dev_to_zram(dev); > unsigned long nr_pages = zram->disksize >> PAGE_SHIFT; D'oh, this patch should not contain any code changes, only documentation updates. It's the previous patch in the series that should contain these coding-style tweaks. Rebasing did not go spectacularly well here... Andrew, what's the best way to handle this?