From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4AA1C4332F for ; Tue, 18 Oct 2022 02:12:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 005E86B0072; Mon, 17 Oct 2022 22:12:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDE9A6B0075; Mon, 17 Oct 2022 22:12:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4B0B6B0078; Mon, 17 Oct 2022 22:12:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BE68C6B0072 for ; Mon, 17 Oct 2022 22:12:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 978E61C67EA for ; Tue, 18 Oct 2022 02:12:15 +0000 (UTC) X-FDA: 80032445430.21.99FBD08 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf11.hostedemail.com (Postfix) with ESMTP id 37CC040031 for ; Tue, 18 Oct 2022 02:12:14 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id z20so12459845plb.10 for ; Mon, 17 Oct 2022 19:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EhunVWViOQq+jYCX/ovpRh7yWUwRqDSJab0KzFcLVZQ=; b=e5a30VeCk2RpehU6eGYBcDsz/+X2qb5BtjVnkOmFBfnooFxeeOXMJVq43vTJAZmAsa OHGrLwVEDEpUjTY/LLRcQR1f27hbjyyQyuD55dN00I+i24ePeFCV8XC2Gc8ZjOrRIKoq 4RFidxL6ZFXZR9thwNAwYzEpjRGuM0RDgsmPA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EhunVWViOQq+jYCX/ovpRh7yWUwRqDSJab0KzFcLVZQ=; b=6er/eje5QPdoMUHcconPQIKRw3x9DVutmmssZFFaF45HKAQ8NQ4/q9JdQCT78dt4xy Ora6OFHVnklRbiLd+fasbYMEwy6RKQdhUjHYLToM0JgjmuqI06U+IoCsOT2wltJdNPhC NyY8i0ENNDrI2HdU922PXttEvDFdM8OeoduNy8iQBexpepyPtU1tugAL4gZsHVZFw8Ud pfWT7ulpVJ/SjQODPXx9VhNYSQg1O8hgj7ce/YTOOx2I+snouJFvHPERrxUs0FMgHamw cZiBAhUlb1SWqLigBMEK8Da9U/M3Z2rQvnduE3VMOSp7mJPutiBSOYAc/Hk/oZuy0LuH OuoA== X-Gm-Message-State: ACrzQf0l07n5W+U+uSFQOFt/PnDxtBqkyw5w2OLCYIaC6DbQyHsXC+gy DAGfuA1fLVfJtBB+ERDsnRj67w== X-Google-Smtp-Source: AMsMyM7t1bozwiZ3hsC6aoXOk5mQp8jw6vae+hgNeUzIvaQtDLVnsnfhVNHEXfeCVGvBN6KrsbixOQ== X-Received: by 2002:a17:902:7481:b0:180:58d7:24e0 with SMTP id h1-20020a170902748100b0018058d724e0mr695847pll.49.1666059134263; Mon, 17 Oct 2022 19:12:14 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:58b4:95a3:4654:2a9f]) by smtp.gmail.com with ESMTPSA id w9-20020a628209000000b0056276519e8fsm1146716pfd.73.2022.10.17.19.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 19:12:13 -0700 (PDT) Date: Tue, 18 Oct 2022 11:12:10 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 4/8] zram: Introduce recompress sysfs knob Message-ID: References: <20221009090720.1040633-1-senozhatsky@chromium.org> <20221009090720.1040633-5-senozhatsky@chromium.org> <20221017170850.034705ad83c54b92236d14f7@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221017170850.034705ad83c54b92236d14f7@linux-foundation.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666059135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EhunVWViOQq+jYCX/ovpRh7yWUwRqDSJab0KzFcLVZQ=; b=6tXUWa9HnRFblhjffwZYCQRlyGC5fuOotLrYblCAXW4YT3jRXkFgsNt8Qst6P4jJdjPXjL AiVDGao79um1O92Ko/k1U27SJePG7PFL0boZmWLijnf8utzVMOhR8pF7YfpxK0Np/mDg+u DuclRAdDOpPX+TUNiOCX+C0h/Q33Q8I= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=e5a30VeC; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666059135; a=rsa-sha256; cv=none; b=ZYDSEoTL6hAconu1sQNSE28GMnpYQ3U4cOStIg0R146qi6Ipk4q0i5FxSR5jhOcLactMon RgaoyGulLBfLtjNSzLtIkEgHbYHdK5vRFleRctK5wi5VXA8aOigdFjXExdnjNwrHkZlUid 0vNysffxod55P+LemCsf8/OKSlUE5u4= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=e5a30VeC; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 37CC040031 X-Rspam-User: X-Stat-Signature: zbw1cheko9jwx631zx8pg8nqzwrt95pa X-HE-Tag: 1666059134-828343 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/10/17 17:08), Andrew Morton wrote: > > Allow zram to recompress (using secondary compression streams) > > pages. We support three modes: > > > > 1) IDLE pages recompression is activated by `idle` mode > > > > echo idle > /sys/block/zram0/recompress > > > > 2) Since there may be many idle pages user-space may pass a size > > watermark value and we will recompress IDLE pages only of equal > > or greater size: > > > > echo 888 > /sys/block/zram0/recompress > > It's helpful to describe the units ("bytes") here and in the > docmentation. Will send fixup patches. > > 3) HUGE pages recompression is activated by `huge` mode > > > > echo huge > /sys/block/zram0/recompress > > > > 4) HUGE_IDLE pages recompression is activated by `huge_idle` mode > > > > echo huge_idle > /sys/block/zram0/recompress > > > > ... > > > > + if (IS_ERR((void *)handle_next)) { > > IS_ERR_VALUE() avoids castsing back and forth. Thanks, I'll send a separate patch for this (if you don't mind).